[DDW-1163] Avoid running regexes for empty CPU model

Author: Marcin Mazurek

source/renderer/app/analytics/MatomoClient.ts

@@ -33,7 +33,7 @@ export class MatomoClient implements AnalyticsClient {
       action_name: pageTitle,
       url: this.getAnalyticsURL(),
       [CPU_DIMENSION_KEY]: getShortCpuDescription(
-        this.environment.cpu[0]?.model || ''
+        this.environment.cpu[0]?.model
       ),
       [RAM_DIMENSION_KEY]: formattedBytesToSize(this.environment.ram),
       [VERSION_DIMENSION_KEY]: this.environment.version,

source/renderer/app/utils/getShortCpuDescription.ts

@@ -4,7 +4,11 @@ const amdRyzenRegex = /AMD Ryzen ([0-9]+)/;
 const amdARegex = /AMD A([0-9]+)/;
 const otherAmdCpuRegex = /AMD ([A-Za-z][A-Za-z\s]*[A-Za-z]|[A-Za-z])[\s|(-]/;
 
-export const getShortCpuDescription = (cpu: string): string => {
+export const getShortCpuDescription = (cpu: string | undefined): string => {
+  if (!cpu) {
+    return 'Other';
+  }
+
   if (cpu.includes('Apple')) {
     return cpu;
   }