[DDW-738] Review changes - use lang selector

Author: Lucas Araujo

source/renderer/app/App.js

@@ -48,6 +48,8 @@ export default class App extends Component<{
       !isNodeStopping && // Daedalus is not shutting down
       !isNodeStopped; // Daedalus is not shutting down
 
+    document.documentElement.lang = locale;
+
     return (
       <Fragment>
         <ThemeManager variables={themeVars} />

source/renderer/app/components/settings/menu/SecurityMenuItem.js

@@ -14,17 +14,11 @@ import type { Intl } from '../../../types/i18nTypes';
 
 type Props = {
   intl: Intl,
-  currentLocale: string,
   isActiveItem: Function,
   onClick: Function,
 };
 
-const SecurityMenuItem = ({
-  intl,
-  isActiveItem,
-  currentLocale,
-  onClick,
-}: Props) => {
+const SecurityMenuItem = ({ intl, isActiveItem, onClick }: Props) => {
   const {
     isNotificationEnabled,
     setDiscreetModeNotification,
@@ -34,7 +28,6 @@ const SecurityMenuItem = ({
     setDiscreetModeNotification(false);
     setDiscreetModeSettingsTooltip(false);
   };
-  const isJapanese = currentLocale === 'ja-JP';
   const isActive = isActiveItem(ROUTES.SETTINGS.SECURITY);
 
   useTriggerOnRouteLeave({
@@ -46,11 +39,7 @@ const SecurityMenuItem = ({
   return (
     <NotificationDot
       enabled={isNotificationEnabled}
-      dotClassName={classnames(
-        styles.dot,
-        isActive && styles.active,
-        isJapanese && styles.jp
-      )}
+      dotClassName={classnames(styles.dot, isActive && styles.active)}
     >
       <SettingsMenuItem
         active={isActive}

source/renderer/app/components/settings/menu/SettingsMenu.js

@@ -7,24 +7,16 @@ import styles from './SettingsMenu.scss';
 import { ROUTES } from '../../../routes-config';
 import messages from './SettingsMenu.messages';
 import type { Intl } from '../../../types/i18nTypes';
-import type { Locale } from '../../../../../common/types/locales.types';
 import SecurityMenuItem from './SecurityMenuItem';
 
 type Props = {
   intl: Intl,
   isFlight: boolean,
   isActiveItem: Function,
-  currentLocale: Locale,
   onItemClick: Function,
 };
 
-const SettingsMenu = ({
-  intl,
-  currentLocale,
-  onItemClick,
-  isActiveItem,
-  isFlight,
-}: Props) => {
+const SettingsMenu = ({ intl, onItemClick, isActiveItem, isFlight }: Props) => {
   return (
     <div>
       <div className={styles.component}>
@@ -34,11 +26,7 @@ const SettingsMenu = ({
           active={isActiveItem(ROUTES.SETTINGS.GENERAL)}
           className="general"
         />
-        <SecurityMenuItem
-          isActiveItem={isActiveItem}
-          currentLocale={currentLocale}
-          onClick={onItemClick}
-        />
+        <SecurityMenuItem isActiveItem={isActiveItem} onClick={onItemClick} />
         <SettingsMenuItem
           label={intl.formatMessage(messages.wallets)}
           onClick={() => onItemClick(ROUTES.SETTINGS.WALLETS)}

source/renderer/app/components/settings/menu/SettingsMenu.scss

@@ -16,7 +16,7 @@
       right: 134px;
     }
 
-    &.jp {
+    &:lang(ja-JP) {
       right: 108px;
     }
   }

source/renderer/app/containers/settings/Settings.js

@@ -28,18 +28,16 @@ export default class Settings extends Component<InjectedContainerProps> {
   render() {
     const { isFlight } = global;
     const { actions, stores, children } = this.props;
-    const { networkStatus, app, router, profile } = stores;
+    const { networkStatus, app, router } = stores;
     const { isSynced } = networkStatus;
     const { currentRoute } = app;
     const { location } = router;
-    const { currentLocale } = profile;
 
     const menu = (
       <SettingsMenu
         isSyncing={!isSynced}
         isFlight={isFlight}
         currentRoute={currentRoute}
-        currentLocale={currentLocale}
         onItemClick={(route) => actions.router.goToRoute.trigger({ route })}
         isActiveItem={this.isActivePage}
       />