[DDW-748] Implement upcoming LedgerJS breaking changes (#2697)

* [DDW-748] Update LedgerJS to the latest v4.0.0-multisig-rc1 version and fix address derivation

* [DDW-748] Fix yarn.lock

* [DDW-748] Add breaking changes to TX sign

* [DDW-748] Update LedgerJS to the latest v4.0.0-RC4

* [DDW-748] Add LedgerJS breaking changes to delegation certs

* [DDW-748] Update CHANGELOG

* [DDW-748] Update LedgerJS to the latest v4.0.0-RC5

* [DDW-735] Merge and gix conflicts

* [DDW-735] Merge and fix conflicts

* [DDW-748] Changelog update

* [DDW-748] Update LedgerJs to the official 4.0.0 version and fix yarn.lock

* [DDW-748] Remove yarn.lock integrity hashes

Author: tomislavhoracek

CHANGELOG.md

@@ -14,6 +14,7 @@
 
 ### Chores
 
+- Covered LedgerJS v4.0.0 breaking changes ([PR 2697](https://github.com/input-output-hk/daedalus/pull/2697))
 - Added hardware wallet support for all non-public testnets ([PR 2672](https://github.com/input-output-hk/daedalus/pull/2672))
 
 ## 4.4.1

package.json

@@ -167,7 +167,7 @@
     "yarn-lockfile": "1.1.1"
   },
   "dependencies": {
-    "@cardano-foundation/ledgerjs-hw-app-cardano": "3.1.0",
+    "@cardano-foundation/ledgerjs-hw-app-cardano": "4.0.0",
     "@iohk-jormungandr/wallet-js": "0.5.0-pre7",
     "@ledgerhq/hw-transport-node-hid": "5.51.1",
     "aes-js": "3.1.2",

source/common/types/hardware-wallets.types.js

@@ -262,6 +262,7 @@ export type LedgerSignTransactionRequest = {
   validityIntervalStartStr?: ?string, // It is disabled for now
   signingMode: string,
   auxiliaryData: ?LedgerAuxiliaryDataType,
+  additionalWitnessPaths: Array<?BIP32Path>,
 };
 
 export type TrezorSignTransactionRequest = {

source/main/ipc/getHardwareWalletChannel.js

@@ -754,6 +754,7 @@ export const handleHardwareWalletRequests = async (
       auxiliaryData,
       devicePath,
       signingMode,
+      additionalWitnessPaths,
     } = params;
     logger.info('[HW-DEBUG] SIGN Ledger transaction');
     deviceConnection = devicePath
@@ -766,6 +767,7 @@ export const handleHardwareWalletRequests = async (
       }
       const signedTransaction = await deviceConnection.signTransaction({
         signingMode,
+        additionalWitnessPaths,
         tx: {
           network: {
             networkId,

source/renderer/app/stores/HardwareWalletsStore.js

@@ -1141,7 +1141,7 @@ export default class HardwareWalletsStore extends Store {
       const derivedAddress = await deriveAddressChannel.request({
         devicePath: path,
         isTrezor,
-        addressType: AddressType.BASE,
+        addressType: AddressType.BASE_PAYMENT_KEY_STAKE_KEY,
         spendingPathStr: address.spendingPath,
         stakingPathStr: `${SHELLEY_PURPOSE_INDEX}'/${ADA_COIN_TYPE}'/0'/2/0`,
         networkId: hardwareWalletsNetworkConfig.networkId,
@@ -1242,7 +1242,7 @@ export default class HardwareWalletsStore extends Store {
       await showAddressChannel.request({
         devicePath: path,
         isTrezor,
-        addressType: AddressType.BASE,
+        addressType: AddressType.BASE_PAYMENT_KEY_STAKE_KEY,
         spendingPathStr: address.spendingPath,
         stakingPathStr: `${SHELLEY_PURPOSE_INDEX}'/${ADA_COIN_TYPE}'/0'/2/0`,
         networkId: hardwareWalletsNetworkConfig.networkId,
@@ -2081,6 +2081,7 @@ export default class HardwareWalletsStore extends Store {
         certificates: certificatesData,
         withdrawals: withdrawalsData,
         signingMode: TransactionSigningMode.ORDINARY_TRANSACTION,
+        additionalWitnessPaths: [],
         auxiliaryData,
         devicePath,
       });

source/renderer/app/utils/shelleyLedger.js

@@ -4,6 +4,7 @@ import {
   TxOutputDestinationType,
   AddressType,
   TxAuxiliaryDataType, // CHECK THIS
+  StakeCredentialParamsType,
 } from '@cardano-foundation/ledgerjs-hw-app-cardano';
 import { encode } from 'borc';
 import blakejs from 'blakejs';
@@ -252,7 +253,10 @@ export const prepareLedgerCertificate = (cert: CoinSelectionCertificate) => {
   return {
     type: CERTIFICATE_TYPE[cert.certificateType],
     params: {
-      path: derivationPathToLedgerPath(cert.rewardAccountPath),
+      stakeCredential: {
+        type: StakeCredentialParamsType.KEY_PATH,
+        keyPath: derivationPathToLedgerPath(cert.rewardAccountPath),
+      },
       poolKeyHashHex: cert.pool
         ? utils.buf_to_hex(utils.bech32_decodeAddress(cert.pool))
         : null,
@@ -264,7 +268,10 @@ export const prepareLedgerWithdrawal = (
   withdrawal: CoinSelectionWithdrawal
 ) => {
   return {
-    path: derivationPathToLedgerPath(withdrawal.derivationPath),
+    stakeCredential: {
+      type: StakeCredentialParamsType.KEY_PATH,
+      keyPath: derivationPathToLedgerPath(withdrawal.derivationPath),
+    },
     amount: withdrawal.amount.quantity.toString(),
   };
 };
@@ -442,7 +449,7 @@ export const prepareLedgerOutput = (
       destination: {
         type: TxOutputDestinationType.DEVICE_OWNED,
         params: {
-          type: AddressType.BASE,
+          type: AddressType.BASE_PAYMENT_KEY_STAKE_KEY,
           params: {
             spendingPath: derivationPathToLedgerPath(output.derivationPath),
             stakingPath: utils.str_to_path("1852'/1815'/0'/2/0"),
@@ -479,7 +486,7 @@ export const prepareLedgerAuxiliaryData = (
         votingPublicKeyHex: votingPubKey,
         stakingPath: rewardDestinationAddress.stakingPath,
         rewardsDestination: {
-          type: AddressType.REWARD,
+          type: AddressType.REWARD_KEY,
           params: {
             stakingPath: rewardDestinationAddress.stakingPath,
           },

yarn.lock

@@ -1019,15 +1019,15 @@
     lodash "^4.17.19"
     to-fast-properties "^2.0.0"
 
-"@cardano-foundation/ledgerjs-hw-app-cardano@3.1.0":
-  version "3.1.0"
-  resolved "https://registry.yarnpkg.com/@cardano-foundation/ledgerjs-hw-app-cardano/-/ledgerjs-hw-app-cardano-3.1.0.tgz#7b27501a0001cb31cfc3c59ac9398bd6596c0648"
+"@cardano-foundation/ledgerjs-hw-app-cardano@4.0.0":
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/@cardano-foundation/ledgerjs-hw-app-cardano/-/ledgerjs-hw-app-cardano-4.0.0.tgz#d4532b23e2ccd652f94a469106933aad821a65e7"
   dependencies:
     "@ledgerhq/hw-transport" "^5.12.0"
     "@types/ledgerhq__hw-transport" "^4.21.3"
     base-x "^3.0.5"
     bech32 "^1.1.4"
-    node-int64 "^0.4.0"
+    int64-buffer "^1.0.1"
 
 "@dump247/[email protected]":
   version "1.6.1"
@@ -8661,6 +8661,10 @@ [email protected]:
   version "0.99.1007"
   resolved "https://registry.yarnpkg.com/int64-buffer/-/int64-buffer-0.99.1007.tgz#211ea089a2fdb960070a2e77cd6d17dc456a5220"
 
+int64-buffer@^1.0.1:
+  version "1.0.1"
+  resolved "https://registry.yarnpkg.com/int64-buffer/-/int64-buffer-1.0.1.tgz#c78d841b444cadf036cd04f8683696c740f15dca"
+
 internal-slot@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/internal-slot/-/internal-slot-1.0.2.tgz#9c2e9fb3cd8e5e4256c6f45fe310067fcfa378a3"