Skip to content

Commit 3b6305f

Browse files
committed
Merge branch 'develop' into feature/ddw-745-arm-support
2 parents 5a45cb1 + 5dfe3f6 commit 3b6305f

File tree

6 files changed

+576
-345
lines changed

6 files changed

+576
-345
lines changed

.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
{
114114
"files": "hardware-wallet-tests/**/*.ts",
115115
"rules": {
116-
"jest/no-standalone-expect": "off",
116+
"jest/no-standalone-expect": "off"
117117
}
118118
}
119119
]

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ Debug
124124
/cardano-cli
125125
/cardano-wallet
126126
.vscode
127+
.yalc
128+
yalc.lock
127129

128130
# Typescript
129131
*.scss.d.ts

CHANGELOG.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Fixes
66

7+
- Fixed incorrect behaviour of creating new wallet when paired incorrect hardware wallet during address verification ([PR 2906](https://github.com/input-output-hk/daedalus/pull/2906))
78
- Fixed phrasing of insufficient funds for tokens message ([PR 2966](https://github.com/input-output-hk/daedalus/pull/2966))
89

910
### Features
@@ -13,6 +14,7 @@
1314

1415
### Chores
1516

17+
- Added steps on how to link with `react-polymorph` and other external UI libraries ([PR 2948](https://github.com/input-output-hk/daedalus/pull/2948))
1618
- Published selfnode installers for all 3 platforms ([PR 2971](https://github.com/input-output-hk/daedalus/pull/2971))
1719

1820
## 4.10.0
@@ -100,12 +102,12 @@
100102

101103
### Fixes
102104

103-
- Improved error handling for incorrect passphrase and incorrect hardware wallet error ([PR 2860](https://github.com/input-output-hk/daedalus/pull/2860))
105+
- Improved error handling for incorrect passphrase and incorrect hardware wallet error ([PR 2860](https://github.com/input-output-hk/daedalus/pull/2860))
104106
- Fixed rewards CSV export issues ([PR 2885](https://github.com/input-output-hk/daedalus/pull/2885))
105107
- Fixed behaviour of wallet settings option of the app menu ([PR 2838](https://github.com/input-output-hk/daedalus/pull/2838))
106108
- Fixed styling of ITN rewards feature ([PR 2861](https://github.com/input-output-hk/daedalus/pull/2861))
107109
- Fixed available disk space takes a long time to show ([PR 2849](https://github.com/input-output-hk/daedalus/pull/2849))
108-
110+
109111
### Chores
110112

111113
- Migrated codebase from javascript to typescript ([PR 2843](https://github.com/input-output-hk/daedalus/pull/2843))

README.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Daedalus - Cryptocurrency Wallet
4242
trusted-substituters =
4343
trusted-public-keys = hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
4444
extra-sandbox-paths = /System/Library/Frameworks /System/Library/PrivateFrameworks /usr/lib
45+
experimental-features = nix-command flakes
4546
4647
# If you are running on a Mac with M1 chip please uncomment 'system' setting to enforce running on Rosetta2
4748
# system = x86_64-darwin
@@ -207,6 +208,26 @@ You can debug the main process by following one of these approaches:
207208

208209
The inspector runs on port 9229
209210

211+
### Linking with UI Libraries (e.g. React Polymorph)
212+
213+
You can link libraries with Daedalus using one of the following steps:
214+
215+
#### 1) Using `yalc`
216+
217+
1) Install `yalc` globally using `yarn global add yalc`.
218+
2) Run `yalc publish` from the library's root directory that you want to link with Daedalus.
219+
3) Switch to Daedalus and run `yalc add <package-name>` or preferably `yalc link <package-name>`.
220+
4) You should be able to start Daedalus and see the changes you are making locally in the library.
221+
5) To make sure your changes are reflected as you update code in the library, use `yalc push`.
222+
223+
#### 2) Using `yarn link`
224+
225+
1) From the Daedalus root directory, go to `node_modules/react` and `yarn link`.
226+
2) Navigate to the `react-dom` package in the same directory and run `yarn link` again.
227+
3) Go to the library's root directory and run `yarn link`, `yarn link react` and `yarn link react-dom`.
228+
4) Go back to the Daedalus root directory and run `yarn link <package-name>`.
229+
5) Finally, run `yarn build:watch` from the library's root directory.
230+
210231
## Testing
211232

212233
You can find more details regarding tests setup within

source/renderer/app/domains/Wallet.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export type HwDeviceStatus =
5757
| 'verifying_address_aborted'
5858
| 'verifying_address_succeeded'
5959
| 'unrecognized_wallet';
60+
6061
export const HwDeviceStatuses: {
6162
CONNECTING: HwDeviceStatus;
6263
CONNECTING_FAILED: HwDeviceStatus;

0 commit comments

Comments
 (0)