[DDW-921] Remove Discreet mode notification (#2852)

Co-authored-by: Daniel Main <[email protected]>

Author: Lucas

CHANGELOG.md

@@ -1,9 +1,10 @@
 # Changelog
 
-## 4.8.0
+## vNext
 
 ### Features
 
+- Removed Discreet mode notification ([PR 2852](https://github.com/input-output-hk/daedalus/pull/2852))
 - Unified CPU info in diagnostics dialog ([PR 2818](https://github.com/input-output-hk/daedalus/pull/2818))
 - Implemented wallet sorting on sidebar menu ([PR 2775](https://github.com/input-output-hk/daedalus/pull/2775))
 - Implemented new token picker ([PR 2787](https://github.com/input-output-hk/daedalus/pull/2787))
@@ -14,12 +15,29 @@
 - Fixed behaviour of wallet settings option of the app menu ([PR 2838](https://github.com/input-output-hk/daedalus/pull/2838))
 - Fixed styling of ITN rewards feature ([PR 2861](https://github.com/input-output-hk/daedalus/pull/2861))
 - Fixed available disk space takes a long time to show ([PR 2849](https://github.com/input-output-hk/daedalus/pull/2849))
-  
+
 ### Chores
 
 - Migrated codebase from javascript to typescript ([PR 2843](https://github.com/input-output-hk/daedalus/pull/2843))
 - Updated the list of team members ([PR 2805](https://github.com/input-output-hk/daedalus/pull/2805))
 
+## 4.8.0
+
+### Features
+
+- Added dynamic RTS flags setting ([PR 2758](https://github.com/input-output-hk/daedalus/pull/2758/files))
+- Improved UI/UX of RTS flags settings ([PR 2842](https://github.com/input-output-hk/daedalus/pull/2842), [PR 2846](https://github.com/input-output-hk/daedalus/pull/2846))
+- Updated messages about Cardano node sync on the initial screen ([PR 2827](https://github.com/input-output-hk/daedalus/pull/2827), [PR 2831](https://github.com/input-output-hk/daedalus/pull/2831))
+
+### Chores
+
+- Updated check-disk-space version ([PR 2845](https://github.com/input-output-hk/daedalus/pull/2845))
+- Updated CWB and Cardano Node ([PR 2822](https://github.com/input-output-hk/daedalus/pull/2822))
+
+### Fixes
+
+- Fixed blockchain verification progress text ([PR 2840](https://github.com/input-output-hk/daedalus/pull/2840))
+
 ## 4.8.0-FC1
 
 ### Features

source/common/config/electron-store.config.ts

@@ -14,8 +14,6 @@ export const STORAGE_KEYS: Record<string, StorageKey> = {
   CURRENCY_SELECTED: 'CURRENCY-SELECTED',
   DATA_LAYER_MIGRATION_ACCEPTANCE: 'DATA-LAYER-MIGRATION-ACCEPTANCE',
   DISCREET_MODE_ENABLED: 'DISCREET-MODE-ENABLED',
-  DISCREET_MODE_SETTINGS_TOOLTIP: 'DISCREET-MODE-SETTINGS-TOOLTIP',
-  DISCREET_MODE_NOTIFICATION: 'DISCREET-MODE-NOTIFICATION',
   DOWNLOAD_MANAGER: 'DOWNLOAD-MANAGER',
   HARDWARE_WALLETS: 'HARDWARE-WALLETS',
   HARDWARE_WALLET_DEVICES: 'HARDWARE-WALLET-DEVICES',

source/common/types/electron-store.types.ts

@@ -9,8 +9,6 @@ export type StorageKey =
   | 'CURRENCY-SELECTED'
   | 'DATA-LAYER-MIGRATION-ACCEPTANCE'
   | 'DISCREET-MODE-ENABLED'
-  | 'DISCREET-MODE-SETTINGS-TOOLTIP'
-  | 'DISCREET-MODE-NOTIFICATION'
   | 'DOWNLOAD-MANAGER'
   | 'HARDWARE-WALLET-DEVICES'
   | 'HARDWARE-WALLETS'

source/main/ipc/electronStoreConversation.ts

@@ -31,8 +31,6 @@ const reset = async () => {
   await unset(keys.CURRENCY_SELECTED);
   await unset(keys.DATA_LAYER_MIGRATION_ACCEPTANCE);
   await unset(keys.DISCREET_MODE_ENABLED);
-  await unset(keys.DISCREET_MODE_SETTINGS_TOOLTIP);
-  await unset(keys.DISCREET_MODE_NOTIFICATION);
   await unset(keys.DOWNLOAD_MANAGER);
   await unset(keys.HARDWARE_WALLET_DEVICES);
   await unset(keys.HARDWARE_WALLETS);

source/renderer/app/components/settings/menu/SecurityMenuItem.tsx

@@ -7,17 +7,4 @@
   margin: 20px 0;
   padding: 16px 0;
   width: 240px;
-
-  .dot {
-    right: 140px;
-    top: 22px;
-
-    &.active {
-      right: 134px;
-    }
-
-    &:lang(ja-JP) {
-      right: 108px;
-    }
-  }
 }

source/renderer/app/components/settings/menu/SettingsMenu.scss

@@ -7,7 +7,6 @@ import styles from './SettingsMenu.scss';
 import { ROUTES } from '../../../routes-config';
 import messages from './SettingsMenu.messages';
 import type { Intl } from '../../../types/i18nTypes';
-import SecurityMenuItem from './SecurityMenuItem';
 
 type Props = {
   intl: Intl;
@@ -26,7 +25,12 @@ const SettingsMenu = ({ intl, onItemClick, isActiveItem, isFlight }: Props) => {
           active={isActiveItem(ROUTES.SETTINGS.GENERAL)}
           className="general"
         />
-        <SecurityMenuItem isActiveItem={isActiveItem} onClick={onItemClick} />
+        <SettingsMenuItem
+          active={isActiveItem(ROUTES.SETTINGS.SECURITY)}
+          label={intl.formatMessage(messages.security)}
+          onClick={() => onItemClick(ROUTES.SETTINGS.SECURITY)}
+          className="security"
+        />
         <SettingsMenuItem
           label={intl.formatMessage(messages.wallets)}
           onClick={() => onItemClick(ROUTES.SETTINGS.WALLETS)}

source/renderer/app/components/settings/menu/SettingsMenu.tsx

@@ -5,7 +5,6 @@ import classNames from 'classnames';
 import styles from './Sidebar.scss';
 import { shouldShowWalletSubMenu } from './helpers';
 import SidebarCategory from './SidebarCategory';
-import SidebarCategoryWrapper from './SidebarCategoryWrapper';
 import SidebarCategoryNetworkInfo from './SidebarCategoryNetworkInfo';
 import SidebarWalletsMenu from './wallets/SidebarWalletsMenu';
 import { CATEGORIES_BY_NAME } from '../../config/sidebarConfig';
@@ -59,17 +58,13 @@ const Sidebar = ({
           const content = getCategoryContent(category.name, network);
           const isActive = activeSidebarCategory === category.route;
           return (
-            <SidebarCategoryWrapper
+            <SidebarCategory
               key={category.name}
-              categoryName={category.name}
-            >
-              <SidebarCategory
-                category={category}
-                isActive={isActive}
-                onClick={onActivateCategory}
-                content={content}
-              />
-            </SidebarCategoryWrapper>
+              category={category}
+              isActive={isActive}
+              onClick={onActivateCategory}
+              content={content}
+            />
           );
         })}
       </div>