[DDW-1076] Improve tests

Author: renanvalentin

source/renderer/app/components/wallet/WalletSendForm.spec.tsx

@@ -78,10 +78,14 @@ describe('wallet/Wallet Send Form', () => {
     calculateTransactionFee,
     currentNumberFormat = NUMBER_OPTIONS[0].value,
     validationDebounceWait,
+    validateAmount = jest.fn().mockResolvedValue(true),
+    onTransactionFeeChange = jest.fn(),
   }: {
     calculateTransactionFee: (...args: Array<any>) => any;
+    validateAmount?: (amount: string) => Promise<boolean>;
     currentNumberFormat?: string;
     validationDebounceWait?: number;
+    onTransactionFeeChange?: () => Promise<void>;
   }) {
     const [tokenPickerOpen, setTokenPickerOpen] = useState<boolean>(false);
     const [state, setState] = useState<{
@@ -98,7 +102,7 @@ describe('wallet/Wallet Send Form', () => {
                 currencyMaxFractionalDigits={currencyMaxFractionalDigits}
                 currencyMaxIntegerDigits={11}
                 currentNumberFormat={currentNumberFormat}
-                validateAmount={jest.fn().mockResolvedValue(true)}
+                validateAmount={validateAmount}
                 validateAssetAmount={jest.fn().mockResolvedValue(true)}
                 calculateTransactionFee={calculateTransactionFee}
                 walletAmount={new BigNumber(123)}
@@ -126,6 +130,7 @@ describe('wallet/Wallet Send Form', () => {
                 onTokenPickerDialogOpen={() => setTokenPickerOpen(true)}
                 confirmationDialogData={state.formData}
                 validationDebounceWait={validationDebounceWait}
+                onTransactionFeeChange={onTransactionFeeChange}
               />
             </MobxProvider>
           </DiscreetModeFeatureProvider>
@@ -464,87 +469,152 @@ describe('wallet/Wallet Send Form', () => {
     assertMinimumAmountNoticeMessage(minimumAda);
   });
 
-  test('should not allow to submit before fees are calculated', async () => {
-    expect.assertions(4);
-
-    const validationDebounceWait = 0;
-
-    const calculateTransactionFeeMock = jest
-      .fn()
-      .mockImplementationOnce(
-        () =>
-          new Promise(async (resolve) => {
-            await sleep(5);
-
-            return resolve({
-              fee: new BigNumber(1),
-              minimumAda: new BigNumber(1),
-            });
-          })
-      )
-      .mockImplementationOnce(
-        () =>
-          new Promise(async (resolve) => {
-            await sleep(5);
-
-            return resolve({
-              fee: new BigNumber(2),
-              minimumAda: new BigNumber(2),
-            });
-          })
-      );
-
-    render(
-      <SetupWallet
-        calculateTransactionFee={calculateTransactionFeeMock}
-        validationDebounceWait={validationDebounceWait}
-      />
-    );
-
-    enterReceiverAddress();
-
-    const adaField = await screen.findByLabelText('Ada');
-    fireEvent.change(adaField, {
-      target: {
-        value: 2.5,
-      },
-    });
-
-    await sleep(validationDebounceWait);
-
-    fireEvent.change(adaField, {
-      target: {
-        value: 1.5,
-      },
-    });
-
-    const sendButton: HTMLButtonElement = screen.getByText('Send');
-
-    expect(sendButton).not.toBeEnabled();
-
-    await waitForTransactionFee();
-
-    expect(sendButton).toBeEnabled();
-
-    fireEvent.keyPress(adaField, {
-      key: 'Enter',
-      code: 13,
-      charCode: 13,
-      target: adaField,
-    });
-
-    const adaAmountConfirmation = await screen.findByTestId(
-      'confirmation-dialog-ada-amount',
-      {}
-    );
-
-    expect(adaAmountConfirmation).toHaveTextContent('1.500000');
-
-    const totalAmountConfirmation = screen.getByTestId(
-      'confirmation-dialog-total-amount',
-      {}
-    );
-
-    expect(totalAmountConfirmation).toHaveTextContent('3.500000');
-  });
+  type Cases = [
+    Array<[number, number]>,
+    [number, number],
+    Array<[number, number]>,
+    [string, string, number]
+  ];
+
+  const cases: Cases[] = [
+    [
+      // ada inputs [delay, value]
+      [
+        [0, 2.5],
+        [0, 1.5],
+      ],
+      // validate amount [delay]
+      [50, 5],
+      // fee calculation [delay, value]
+      [
+        [50, 2],
+        [0, 1],
+      ],
+      ['1.500000', '3.500000', 1],
+    ],
+    [
+      [
+        [0, 2.5],
+        [0, 1.5],
+      ],
+      [0, 0],
+      [
+        [0, 1],
+        [0, 2],
+      ],
+      ['1.500000', '3.500000', 1],
+    ],
+    [
+      [
+        [50, 2.5],
+        [0, 1.5],
+      ],
+      [0, 0],
+      [
+        [0, 1],
+        [0, 2],
+      ],
+      ['1.500000', '3.500000', 2],
+    ],
+  ];
+
+  cases.forEach(
+    (
+      [
+        inputs,
+        validateAmountParams,
+        feeCalculationParams,
+        [expectedAdaAmount, expectedTotalAmount, expectedTimesFeeCalled],
+      ],
+      idx
+    ) => {
+      test(`case ${idx}: should not allow to submit before fees are calculated`, async () => {
+        expect.assertions(5);
+
+        const validationDebounceWait = 0;
+        const onTransactionFeeChangeSpy = jest.fn();
+
+        const calculateTransactionFeeMock = jest.fn();
+
+        feeCalculationParams.forEach(([delay, value]) => {
+          calculateTransactionFeeMock.mockImplementationOnce(
+            () =>
+              new Promise(async (resolve) => {
+                await sleep(delay);
+                return resolve({
+                  fee: new BigNumber(value),
+                  minimumAda: new BigNumber(1),
+                });
+              })
+          );
+        });
+
+        const validateAmountMock = jest.fn();
+
+        validateAmountParams.forEach((delay) => {
+          validateAmountMock.mockImplementationOnce(
+            () =>
+              new Promise(async (resolve) => {
+                await sleep(delay);
+                return resolve(true);
+              })
+          );
+        });
+
+        render(
+          <SetupWallet
+            validateAmount={validateAmountMock}
+            calculateTransactionFee={calculateTransactionFeeMock}
+            validationDebounceWait={validationDebounceWait}
+            onTransactionFeeChange={onTransactionFeeChangeSpy}
+          />
+        );
+
+        enterReceiverAddress();
+
+        const adaField = await screen.findByLabelText('Ada');
+
+        for (const [delay, value] of inputs) {
+          fireEvent.change(adaField, {
+            target: {
+              value,
+            },
+          });
+
+          await sleep(delay);
+        }
+
+        const sendButton: HTMLButtonElement = screen.getByText('Send');
+        expect(sendButton).not.toBeEnabled();
+
+        await waitForTransactionFee();
+
+        expect(sendButton).toBeEnabled();
+
+        fireEvent.keyPress(adaField, {
+          key: 'Enter',
+          code: 13,
+          charCode: 13,
+          target: adaField,
+        });
+
+        const adaAmountConfirmation = await screen.findByTestId(
+          'confirmation-dialog-ada-amount',
+          {}
+        );
+
+        expect(adaAmountConfirmation).toHaveTextContent(expectedAdaAmount);
+
+        const totalAmountConfirmation = screen.getByTestId(
+          'confirmation-dialog-total-amount',
+          {}
+        );
+
+        expect(totalAmountConfirmation).toHaveTextContent(expectedTotalAmount);
+        expect(onTransactionFeeChangeSpy).toHaveBeenCalledTimes(
+          expectedTimesFeeCalled
+        );
+      });
+    }
+  );
 });