Skip to content

Commit 5425e1d

Browse files
committed
apply fix
1 parent c3bf63b commit 5425e1d

File tree

7 files changed

+18
-17
lines changed

7 files changed

+18
-17
lines changed

source/renderer/app/components/wallet/settings/ChangeSpendingPasswordDialog.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import classnames from 'classnames';
44
import { Input } from 'react-polymorph/lib/components/Input';
55
import { defineMessages, FormattedHTMLMessage, intlShape } from 'react-intl';
66
import vjf from 'mobx-react-form/lib/validators/VJF';
7-
import { PopOver } from 'react-polymorph/lib/components/PopOver';
87
import SVGInline from 'react-svg-inline';
98
import ReactToolboxMobxForm from '../../../utils/ReactToolboxMobxForm';
109
import DialogCloseButton from '../../widgets/DialogCloseButton';
@@ -307,14 +306,14 @@ class ChangeSpendingPasswordDialog extends Component<Props> {
307306
onKeyPress={this.handleSubmitOnEnter}
308307
/>
309308
{!isSpendingPasswordSet && (
310-
<PopOver
309+
<TopLevelPopOver
311310
content={
312311
<FormattedHTMLMessage {...messages.passwordTooltip} />
313312
}
314313
key="tooltip"
315314
>
316315
<SVGInline svg={infoIconInline} className={styles.infoIcon} />
317-
</PopOver>
316+
</TopLevelPopOver>
318317
)}
319318
</div>
320319
</div>

source/renderer/app/components/wallet/settings/ICOPublicKeyQRCodeDialog.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import iconCopy from '../../../assets/images/clipboard-ic.inline.svg';
1212
import styles from './PublicKeyQRCodeDialog.scss';
1313
import globalMessages from '../../../i18n/global-messages';
1414
import { messages } from './ICOPublicKeyQRCodeDialog.messages';
15+
import TopLevelPopOver from '../../widgets/TopLevelPopOver';
1516

1617
type Props = {
1718
walletName: string;
@@ -66,9 +67,9 @@ const ICOPublicKeyQRCodeDialog = observer((props: Props) => {
6667
/>
6768
</div>
6869
<div className={styles.addressPathsWrapper}>
69-
<PopOver content={intl.formatMessage(messages.derivationPathTooltip)}>
70+
<TopLevelPopOver content={intl.formatMessage(messages.derivationPathTooltip)}>
7071
<div className={styles.spendingPath}>{derivationPath}</div>
71-
</PopOver>
72+
</TopLevelPopOver>
7273
</div>
7374

7475
<div className={styles.walletPublicKey}>{walletPublicKey}</div>

source/renderer/app/components/wallet/settings/WalletPublicKeyQRCodeDialog.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import { injectIntl, intlShape } from 'react-intl';
44
import CopyToClipboard from 'react-copy-to-clipboard';
55
import SVGInline from 'react-svg-inline';
66
import QRCode from 'qrcode.react';
7-
import { PopOver } from 'react-polymorph/lib/components/PopOver';
87
import DialogCloseButton from '../../widgets/DialogCloseButton';
98
import Dialog from '../../widgets/Dialog';
109
// @ts-ignore ts-migrate(2307) FIXME: Cannot find module '../../../assets/images/clipboa... Remove this comment to see the full error message
1110
import iconCopy from '../../../assets/images/clipboard-ic.inline.svg';
1211
import styles from './PublicKeyQRCodeDialog.scss';
1312
import globalMessages from '../../../i18n/global-messages';
1413
import type { ReactIntlMessage } from '../../../types/i18nTypes';
14+
import TopLevelPopOver from '../../widgets/TopLevelPopOver';
1515

1616
type Props = {
1717
walletName: string;
@@ -68,9 +68,9 @@ const WalletPublicKeyQRCodeDialog = observer((props: Props) => {
6868
/>
6969
</div>
7070
<div className={styles.addressPathsWrapper}>
71-
<PopOver content={intl.formatMessage(messages.derivationPathTooltip)}>
71+
<TopLevelPopOver content={intl.formatMessage(messages.derivationPathTooltip)}>
7272
<div className={styles.spendingPath}>{derivationPath}</div>
73-
</PopOver>
73+
</TopLevelPopOver>
7474
</div>
7575

7676
<div className={styles.walletPublicKey}>{walletPublicKey}</div>

source/renderer/app/components/wallet/wallet-restore/ConfigurationDialog.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { Input } from 'react-polymorph/lib/components/Input';
55
import { defineMessages, intlShape, FormattedHTMLMessage } from 'react-intl';
66
import vjf from 'mobx-react-form/lib/validators/VJF';
77
import SVGInline from 'react-svg-inline';
8-
import { PopOver } from 'react-polymorph/lib/components/PopOver';
98
import { PasswordInput } from '../../widgets/forms/PasswordInput';
109
import WalletRestoreDialog from './widgets/WalletRestoreDialog';
1110
import styles from './ConfigurationDialog.scss';
@@ -24,6 +23,7 @@ import { FORM_VALIDATION_DEBOUNCE_WAIT } from '../../../config/timingConfig';
2423
// @ts-ignore ts-migrate(2307) FIXME: Cannot find module '../../../assets/images/info-ic... Remove this comment to see the full error message
2524
import infoIconInline from '../../../assets/images/info-icon.inline.svg';
2625
import LoadingSpinner from '../../widgets/LoadingSpinner';
26+
import TopLevelPopOver from '../../widgets/TopLevelPopOver';
2727

2828
const messages = defineMessages({
2929
description1: {
@@ -276,14 +276,14 @@ class ConfigurationDialog extends Component<Props> {
276276
onKeyPress={this.handleSubmitOnEnter}
277277
{...spendingPasswordField.bind()}
278278
/>
279-
<PopOver
279+
<TopLevelPopOver
280280
content={
281281
<FormattedHTMLMessage {...messages.passwordTooltip} />
282282
}
283283
key="tooltip"
284284
>
285285
<SVGInline svg={infoIconInline} className={styles.infoIcon} />
286-
</PopOver>
286+
</TopLevelPopOver>
287287
</div>
288288
<div className={styles.spendingPasswordField}>
289289
<PasswordInput

source/renderer/app/components/widgets/TopLevelPopOver.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from 'react';
22
import { PopOver, PopOverProps } from 'react-polymorph/lib/components/PopOver';
33

4-
const topLevelZIndex = 10000;
4+
const topLevelZIndex = 9999;
55

66
const TopLevelPopOver = ({ children, ...props }: PopOverProps) => (
77
<PopOver

source/renderer/app/components/widgets/forms/FormFieldSkinTooltip.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ import type { Element } from 'react';
55
import { omit } from 'lodash';
66
import classnames from 'classnames';
77
import SVGInline from 'react-svg-inline';
8-
import { PopOver } from 'react-polymorph/lib/components/PopOver';
98
// @ts-ignore ts-migrate(2307) FIXME: Cannot find module '../../../assets/images/exclama... Remove this comment to see the full error message
109
import exclamationPointIcon from '../../../assets/images/exclamation-point.inline.svg';
1110
import styles from './FormFieldSkinTooltip.scss';
11+
import TopLevelPopOver from '../TopLevelPopOver';
12+
1213
type Props = {
1314
className: string;
1415
disabled: boolean;
@@ -40,12 +41,12 @@ export const FormFieldSkin = (props: Props) => (
4041
>
4142
{props.label}
4243
{props.error && (
43-
<PopOver content={props.error} key="tooltip" placement="bottom">
44+
<TopLevelPopOver content={props.error} key="tooltip" placement="bottom">
4445
<SVGInline
4546
svg={exclamationPointIcon}
4647
className={styles.exclamationPointIcon}
4748
/>
48-
</PopOver>
49+
</TopLevelPopOver>
4950
)}
5051
</label>
5152
)}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
$backdrop-z-index: 10000;
2-
$dialog-z-index: 10000;
1+
$backdrop-z-index: 9998;
2+
$dialog-z-index: 9998;
33
$loader-backdrop-z-index: 5;
44
$back-to-top-z-index: 5;
55
$sticky-header-z-index: 1;

0 commit comments

Comments
 (0)