Skip to content

Commit 5f4dc68

Browse files
author
Marcin Mazurek
committed
Merge remote-tracking branch 'origin/develop' into fix/ddw-985-missing-character-in-pdf
2 parents 36f45c2 + 3ef535d commit 5f4dc68

File tree

10 files changed

+32
-6
lines changed

10 files changed

+32
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
### Fixes
1313

1414
- Fixed issue with missing character when copying address from PDF ([PR 2925](https://github.com/input-output-hk/daedalus/pull/2925))
15+
- Fixed stake pool list view overlapping news feed ([PR 2917](https://github.com/input-output-hk/daedalus/pull/2917))
1516
- Restored opacity for search icon when focused ([PR 2909](https://github.com/input-output-hk/daedalus/pull/2909))
1617
- Fixed styling of the incentivized testnet rewards wallet dropdown ([PR 2907](https://github.com/input-output-hk/daedalus/pull/2907))
1718
- Fix warning sign displayed when recommend decimals is zero ([PR 2905](https://github.com/input-output-hk/daedalus/pull/2905))

source/renderer/app/components/staking/stake-pools/StakePoolsRankingLoader.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import '../../../themes/mixins/layers.scss';
2+
13
.component {
24
align-items: center;
35
background-color: var(--rp-modal-overlay-bg-color);
@@ -8,4 +10,5 @@
810
position: fixed;
911
right: 0;
1012
top: 134px;
13+
z-index: $loader-backdrop-z-index;
1114
}

source/renderer/app/components/staking/stake-pools/StakePoolsTable.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
@import '../../../themes/mixins/link';
22
@import '../../../themes/mixins/loading-spinner';
3+
@import '../../../themes/mixins/layers';
34

45
.component {
56
.headerWrapper {
@@ -105,7 +106,7 @@
105106
padding: 0 20px;
106107
position: sticky;
107108
top: 0;
108-
z-index: 999;
109+
z-index: $sticky-header-z-index;
109110

110111
tr {
111112
border: 0;

source/renderer/app/components/widgets/BackToTopButton.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import '../../themes/mixins/layers.scss';
2+
13
.component {
24
background-color: var(--theme-back-to-top-button-background-color);
35
border-radius: 5px;
@@ -15,7 +17,7 @@
1517
top: 144px;
1618
transform: translateX(-50%);
1719
transition: opacity 0.25s ease-out, top 0.25s ease-out;
18-
z-index: 1001;
20+
z-index: $back-to-top-z-index;
1921

2022
&.isActive {
2123
opacity: 1;

source/renderer/app/containers/staking/RedeemItnRewardsContainer.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,15 @@ class RedeemItnRewardsContainer extends Component<Props> {
2727
};
2828
}
2929

30+
componentDidMount() {
31+
const { app } = this.props.stores;
32+
const { closeNewsFeed } = this.props.actions.app;
33+
34+
if (app.newsFeedIsOpen) {
35+
closeNewsFeed.trigger();
36+
}
37+
}
38+
3039
render() {
3140
const { stores, actions } = this.props;
3241
const { allWallets } = stores.wallets;

source/renderer/app/containers/static/AboutDialog.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import '../../themes/mixins/overlay-backdrop';
2+
@import '../../themes/mixins/layers';
23

34
.overlay {
45
background-color: var(--theme-about-window-background-color);
@@ -9,7 +10,7 @@
910
position: fixed;
1011
right: 0;
1112
top: 0;
12-
z-index: 9999;
13+
z-index: $dialog-z-index;
1314

1415
&::-webkit-scrollbar-button {
1516
height: 21px;

source/renderer/app/containers/status/DaedalusDiagnosticsDialog.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import '../../themes/mixins/overlay-backdrop';
2+
@import '../../themes/mixins/layers';
23

34
.overlay {
45
bottom: 0;
@@ -7,7 +8,7 @@
78
position: fixed;
89
right: 0;
910
top: 0;
10-
z-index: 9999;
11+
z-index: $dialog-z-index;
1112
@include overlay-backrop;
1213

1314
*::-webkit-scrollbar-button {

source/renderer/app/stores/AppStore.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ export default class AppStore extends Store {
196196
};
197197
@action
198198
_updateActiveDialog = (currentDialog: ApplicationDialog) => {
199+
if (this.newsFeedIsOpen) {
200+
this.newsFeedIsOpen = false;
201+
}
199202
if (this.activeDialog !== currentDialog) this.activeDialog = currentDialog;
200203
};
201204
@action
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
1-
$dialog-z-index: 200;
1+
$backdrop-z-index: 10000;
2+
$dialog-z-index: 10000;
3+
$loader-backdrop-z-index: 5;
4+
$back-to-top-z-index: 5;
5+
$sticky-header-z-index: 1;

source/renderer/app/themes/overrides/ModalOverrides.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
@import '../mixins/overlay-backdrop';
2+
@import '../mixins/layers.scss';
23

34
.overlay {
45
@include overlay-backrop;
56
overflow: hidden;
6-
z-index: 100;
7+
z-index: $backdrop-z-index;
78
}
89

910
.modal {

0 commit comments

Comments
 (0)