[DW-1086] Fix hasAssetsAfterTransaction function

Author: Lucas Araujo

source/renderer/app/containers/wallet/dialogs/send-confirmation/helpers.spec.ts

@@ -0,0 +1,88 @@
+import BigNumber from 'bignumber.js';
+import { hasAssetsAfterTransaction } from './helpers';
+
+const assetWithOneQuantity = {
+  policyId: 'policyId1',
+  assetName: '54657374636f696e',
+  quantity: new BigNumber(1),
+  fingerprint: 'policyId154657374636f696e',
+  metadata: {
+    name: 'Testcoin',
+    description: 'Test coin',
+  },
+  uniqueId: 'uniqueId1',
+  decimals: 1,
+  recommendedDecimals: null,
+};
+
+const assetWithTenQuantity = {
+  policyId: 'policyId2',
+  assetName: '436f696e74657374',
+  quantity: new BigNumber(10),
+  fingerprint: 'policyId2436f696e74657374',
+  uniqueId: 'uniqueId2',
+  decimals: 1,
+  recommendedDecimals: null,
+};
+
+describe('hasAssetsAfterTransaction', () => {
+  test('Should be true when wallet has assets and tx sending no assets', () => {
+    expect(
+      hasAssetsAfterTransaction({
+        assetTokens: [assetWithOneQuantity, assetWithTenQuantity],
+        selectedAssets: [],
+        assetsAmounts: [],
+      })
+    ).toEqual(true);
+  });
+
+  test('Should be true when wallet has assets and tx is not sending all asset types', () => {
+    expect(
+      hasAssetsAfterTransaction({
+        assetTokens: [assetWithOneQuantity, assetWithTenQuantity],
+        selectedAssets: [assetWithTenQuantity],
+        assetsAmounts: ['5'],
+      })
+    ).toEqual(true);
+  });
+
+  test('Should be true when wallet has assets and tx is not sending all assets', () => {
+    expect(
+      hasAssetsAfterTransaction({
+        assetTokens: [assetWithOneQuantity, assetWithTenQuantity],
+        selectedAssets: [assetWithOneQuantity, assetWithTenQuantity],
+        assetsAmounts: ['1', '5'],
+      })
+    ).toEqual(true);
+  });
+
+  test('Should be false when wallet has no assets', () => {
+    expect(
+      hasAssetsAfterTransaction({
+        assetTokens: [],
+        selectedAssets: [],
+        assetsAmounts: [],
+      })
+    ).toEqual(false);
+  });
+
+  test('Should be false when tx is sending all assets (1 asset)', () => {
+    expect(
+      hasAssetsAfterTransaction({
+        assetTokens: [assetWithOneQuantity],
+        selectedAssets: [assetWithOneQuantity],
+        assetsAmounts: ['1'],
+      })
+    ).toEqual(false);
+  });
+
+  test('Should be false when tx is sending all assets (2 assets)', () => {
+    expect(
+      hasAssetsAfterTransaction({
+        assetTokens: [assetWithOneQuantity, assetWithTenQuantity],
+        selectedAssets: [assetWithOneQuantity, assetWithTenQuantity],
+        assetsAmounts: ['1', '10'],
+      })
+    ).toEqual(false);
+  });
+});

source/renderer/app/containers/wallet/dialogs/send-confirmation/helpers.ts

@@ -7,7 +7,12 @@ import { AssetToken } from '../../../../api/assets/types';
 import { HwDeviceStatuses } from '../../../../domains/Wallet';
 import { FORM_VALIDATION_DEBOUNCE_WAIT } from '../../../../config/timingConfig';
 import { formattedTokenWalletAmount } from '../../../../utils/formatters';
-import { CreateForm, FormFields, HasAssetsAfterTransaction } from './types';
+import {
+  CreateForm,
+  FormFields,
+  HasAssetsAfterTransaction,
+  IsSendingAllFromSelected,
+} from './types';
 
 export const doTermsNeedAcceptance = ({ isFlight, areTermsAccepted }) =>
   !areTermsAccepted && isFlight;
@@ -25,13 +30,32 @@ export const isNotEnoughFundsForTokenError = (errorId) =>
 export const isPasswordValid = ({ isHardwareWallet, isValid }) =>
   isHardwareWallet || isValid;
 
+export const isSendingAllFromSelected = ({
+  selectedAssets = [],
+  assetsAmounts = [],
+}: IsSendingAllFromSelected) =>
+  Boolean(selectedAssets.length) &&
+  selectedAssets.every(({ quantity }, i) =>
+    quantity.isEqualTo(assetsAmounts?.[i])
+  );
+
 export const hasAssetsAfterTransaction = ({
   selectedAssets = [],
   assetTokens = [],
-}: HasAssetsAfterTransaction) =>
-  selectedAssets.length
-    ? selectedAssets.length < assetTokens.length
-    : assetTokens.length > 0;
+  assetsAmounts = [],
+}: HasAssetsAfterTransaction) => {
+  const sendingTokens = Boolean(selectedAssets.length);
+  const hasTokens = Boolean(assetTokens.length);
+  const sendingAllTokenTypes = selectedAssets.length === assetTokens.length;
+  const sendingAllFromSelected = isSendingAllFromSelected({
+    assetsAmounts,
+    selectedAssets,
+  });
+
+  return sendingTokens
+    ? !(sendingAllTokenTypes && sendingAllFromSelected)
+    : hasTokens;
+};
 
 export const getFormattedAssetAmount = (
   { metadata, decimals }: AssetToken,

source/renderer/app/containers/wallet/dialogs/send-confirmation/hooks.ts

@@ -39,6 +39,7 @@ export const useForm = ({
             hasAssetsRemainingAfterTransaction: hasAssetsAfterTransaction({
               assetTokens,
               selectedAssets,
+              assetsAmounts,
             }),
             ...(selectedAssets.length
               ? { assets: selectedAssets, assetsAmounts }

source/renderer/app/containers/wallet/dialogs/send-confirmation/types.ts

@@ -94,5 +94,10 @@ export type CreateForm = Pick<ViewProps, 'intl' | 'isHardwareWallet'>;
 
 export type HasAssetsAfterTransaction = Pick<
   ViewProps,
-  'assetTokens' | 'selectedAssets'
+  'assetTokens' | 'selectedAssets' | 'assetsAmounts'
+>;
+
+export type IsSendingAllFromSelected = Pick<
+  ViewProps,
+  'selectedAssets' | 'assetsAmounts'
 >;