[DDW-1076] Clean up logs

Author: renanvalentin

source/renderer/app/components/wallet/WalletSendForm.tsx

@@ -75,6 +75,8 @@ export interface FormData {
   adaAmount: number;
 }
 
+export type ConfirmationDialogData = Omit<FormData, 'coinSelection'>;
+
 type Props = {
   currencyMaxIntegerDigits: number;
   currencyMaxFractionalDigits: number;
@@ -109,7 +111,7 @@ type Props = {
   walletName: string;
   onTokenPickerDialogOpen: (...args: Array<any>) => any;
   onTokenPickerDialogClose: (...args: Array<any>) => any;
-  confirmationDialogData?: FormData;
+  confirmationDialogData?: ConfirmationDialogData;
   validationDebounceWait?: number;
 };
 
@@ -140,10 +142,6 @@ type State = {
   hasPendingRequestTokens: boolean;
   adaInputState: AdaInputState;
   coinSelection?: CoinSelectionsResponse;
-  coinSelections?: Array<{
-    adaAmount: number;
-    coinSelection: CoinSelectionsResponse;
-  }>;
   adaAmount: number;
 };
 
@@ -178,7 +176,6 @@ class WalletSendForm extends Component<Props, State> {
     hasPendingRequestTokens: false,
     coinSelection: null,
     adaAmount: 0,
-    coinSelections: [],
   };
   // We need to track the mounted state in order to avoid calling
   // setState promise handling code after the component was already unmounted:
@@ -668,10 +665,6 @@ class WalletSendForm extends Component<Props, State> {
           adaInputState: this.state.adaInputState,
           coinSelection,
           adaAmount,
-          coinSelections: [
-            ...this.state.coinSelections,
-            { adaAmount, coinSelection },
-          ],
         };
 
         if (shouldUpdateMinimumAdaAmount) {
@@ -1349,39 +1342,6 @@ class WalletSendForm extends Component<Props, State> {
             </div>
           </BorderedBox>
         )}
-        {this.state.coinSelections.map((c, idx) => (
-          <div
-            style={{
-              margin: '20px',
-              border: '1px dashed #333',
-            }}
-            key={idx}
-          >
-            <b>ada amount: {c.adaAmount}</b>
-            <br />
-            <b>inputs:</b>
-            <p
-              style={{
-                whiteSpace: 'break-spaces',
-                lineHeight: '20px',
-                fontSize: '14px',
-              }}
-            >
-              {JSON.stringify(c.coinSelection.inputs, null, 2)}
-            </p>
-            <b>outputs:</b>
-            <p
-              style={{
-                whiteSpace: 'break-spaces',
-                lineHeight: '20px',
-                fontSize: '14px',
-              }}
-            >
-              {JSON.stringify(c.coinSelection.outputs, null, 2)}
-            </p>
-          </div>
-        ))}
-
         {isDialogOpen(WalletSendConfirmationDialogView) &&
         confirmationDialogData ? (
           <WalletSendConfirmationDialogContainer
@@ -1401,8 +1361,6 @@ class WalletSendForm extends Component<Props, State> {
             formattedTotalAmount={confirmationDialogData.totalAmount.toFormat(
               currencyMaxFractionalDigits
             )}
-            adaAmount={confirmationDialogData.adaAmount}
-            coinSelection={confirmationDialogData.coinSelection}
           />
         ) : null}
         {isDialogOpen(WalletTokenPicker) && (

source/renderer/app/containers/wallet/WalletSendPage.tsx

@@ -7,6 +7,7 @@ import {
 } from '../../config/numbersConfig';
 import WalletSendForm, {
   FormData,
+  ConfirmationDialogData,
 } from '../../components/wallet/WalletSendForm';
 import { WalletSendConfirmationDialogView } from './dialogs/send-confirmation/SendConfirmation.view';
 import WalletTokenPicker from '../../components/wallet/tokens/wallet-token-picker/WalletTokenPicker';
@@ -18,7 +19,7 @@ import { CoinSelectionsResponse } from '../../api/transactions/types';
 
 type Props = InjectedProps;
 type State = {
-  formData: FormData;
+  confirmationDialogData: ConfirmationDialogData;
 };
 
 @inject('stores', 'actions')
@@ -29,8 +30,8 @@ class WalletSendPage extends Component<Props, State> {
     stores: null,
   };
 
-  state = {
-    formData: null,
+  state: State = {
+    confirmationDialogData: null,
   };
 
   calculateTransactionFee = async (params: {
@@ -100,7 +101,7 @@ class WalletSendPage extends Component<Props, State> {
       });
     }
 
-    this.setState({ formData: { ...data, coinSelection } });
+    this.setState({ confirmationDialogData: { ...data } });
   };
 
   openTokenPickerDialog = () => {
@@ -185,7 +186,7 @@ class WalletSendPage extends Component<Props, State> {
         walletName={walletName}
         onTokenPickerDialogOpen={this.openTokenPickerDialog}
         onTokenPickerDialogClose={this.closeTokenPickerDialog}
-        confirmationDialogData={this.state.formData}
+        confirmationDialogData={this.state.confirmationDialogData}
       />
     );
   }

source/renderer/app/containers/wallet/dialogs/send-confirmation/SendConfirmation.container.tsx

@@ -18,8 +18,6 @@ export const Containter = ({
   hwDeviceStatus,
   isHardwareWallet,
   formattedTotalAmount,
-  adaAmount,
-  coinSelection,
 }: Props) => {
   const { isFlight } = global;
   const {
@@ -113,8 +111,6 @@ export const Containter = ({
       onSubmitCb={onSubmitCb}
       onTermsCheckboxClick={onTermsCheckboxClick}
       onExternalLinkClick={onExternalLinkClick}
-      adaAmount={adaAmount}
-      coinSelection={coinSelection}
     />
   );
 };

source/renderer/app/containers/wallet/dialogs/send-confirmation/SendConfirmation.view.tsx

@@ -23,7 +23,6 @@ import {
   isPasswordValid,
 } from './helpers';
 import styles from './styles.scss';
-import { toFixedUserFormat } from '../../../../utils/formatters';
 
 const View = ({
   intl,
@@ -48,8 +47,6 @@ const View = ({
   onSubmitCb,
   onTermsCheckboxClick,
   onCopyAssetParam,
-  adaAmount,
-  coinSelection,
 }: Props) => {
   const {
     passphraseField,
@@ -107,28 +104,6 @@ const View = ({
       className={styles.root}
       closeButton={<DialogCloseButton />}
     >
-      <b>ada amount: {toFixedUserFormat(adaAmount, 0)} </b>
-      <br />
-      <b>inputs:</b>
-      <p
-        style={{
-          whiteSpace: 'break-spaces',
-          lineHeight: '20px',
-          fontSize: '14px',
-        }}
-      >
-        {JSON.stringify(coinSelection.inputs, null, 2)}
-      </p>
-      <b>outputs:</b>{' '}
-      <p
-        style={{
-          whiteSpace: 'break-spaces',
-          lineHeight: '20px',
-          fontSize: '14px',
-        }}
-      >
-        {JSON.stringify(coinSelection.outputs, null, 2)}
-      </p>
       {shouldShowEmptyWalletWarning(
         totalAmount,
         wallet,

source/renderer/app/containers/wallet/dialogs/send-confirmation/types.ts

@@ -1,6 +1,5 @@
 import BigNumber from 'bignumber.js';
 import { Field } from 'mobx-react-form';
-import { CoinSelectionsResponse } from 'source/renderer/app/api/transactions/types';
 import { Intl } from '../../../../types/i18nTypes';
 import { StoresMap } from '../../../../stores/index';
 import { ActionsMap } from '../../../../actions/index';
@@ -19,8 +18,6 @@ type CommonProps = {
   totalAmount: BigNumber;
   transactionFee: string | null | undefined;
   onExternalLinkClick: (...args: Array<any>) => any;
-  adaAmount?: number;
-  coinSelection?: CoinSelectionsResponse;
 };
 
 export type ContainerProps = CommonProps & {

source/renderer/app/stores/HardwareWalletsStore.ts

@@ -644,6 +644,7 @@ export default class HardwareWalletsStore extends Store {
         },
         metadata,
       });
+      this.selectCoinsRequest.reset();
       // @ts-ignore ts-migrate(1320) FIXME: Type of 'await' operand must either be a valid pro... Remove this comment to see the full error message
       const coinSelection: CoinSelectionsResponse = await this.selectCoinsRequest.execute(
         {

source/renderer/app/utils/logging.ts

@@ -27,10 +27,6 @@ const logToLevel = (level: LoggingLevel) => (
   message: string,
   data: Record<string, any> | null | undefined
 ) => {
-  if (!message.includes('selectCoins')) {
-    return;
-  }
-
   const args = [
     formatContext({ ...messageContext, level }),
     {
@@ -43,7 +39,7 @@ const logToLevel = (level: LoggingLevel) => (
 };
 
 export const logger: Logger = {
-  debug: logToLevel('info'),
+  debug: logToLevel('debug'),
   info: logToLevel('info'),
   error: logToLevel('error'),
   warn: logToLevel('warn'),