Merge branch 'develop' into fix/ddw-941-rewards-export-remove-date-column

# Conflicts:
#	source/renderer/app/i18n/locales/defaultMessages.json

Author: DominikGuzei

.github/workflows/chromatic.yml

@@ -28,10 +28,12 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           exitZeroOnChanges: true
+          buildScriptName: 'storybook:build:chromatic'
       - name: Publish to Chromatic and auto accept changes
         if: github.ref == 'refs/heads/develop'
         uses: chromaui/action@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           autoAcceptChanges: true
+          buildScriptName: 'storybook:build:chromatic'

.gitignore

@@ -119,3 +119,6 @@ Debug
 /cardano-cli
 /cardano-wallet
 .vscode
+
+# Typescript
+*.scss.d.ts

CHANGELOG.md

@@ -4,6 +4,17 @@
 
 ### Features
 
+- Implemented error message when trying to leave wallet without enough ada to support tokens ([PR 2783](https://github.com/input-output-hk/daedalus/pull/2783))
+
+### Chores
+
+- Removed SASS ts-lint ignore comments ([PR 2870](https://github.com/input-output-hk/daedalus/pull/2870))
+- Enabled debugging of the main process ([PR 2893](https://github.com/input-output-hk/daedalus/pull/2893))
+
+## 4.9.0
+
+### Features
+
 - Added display of current/unspent rewards ([PR 2803](https://github.com/input-output-hk/daedalus/pull/2803))
 - Improve the syncing screen by showing syncing progress split into three stages ([PR 2877](https://github.com/input-output-hk/daedalus/pull/2877))
 - Improved stake pool searchbar ([PR 2847](https://github.com/input-output-hk/daedalus/pull/2847))
@@ -73,7 +84,6 @@
 
 ### Fixes
 
-- Fixed styling of the incentivized testnet rewards wallet dropdown ([PR 2816](https://github.com/input-output-hk/daedalus/pull/2816/files))
 - Fixed blockchain verification progress text ([PR 2840](https://github.com/input-output-hk/daedalus/pull/2840))
 
 ## 4.7.0
@@ -84,10 +94,12 @@
 
 ### Fixes
 
+- Fixed immediate language updates of application top menu bar ([PR 2813](https://github.com/input-output-hk/daedalus/pull/2813))
 - Fixed receiver address validation by disallowing rewards addresses ([PR 2781](https://github.com/input-output-hk/daedalus/pull/2781))
 
 ### Chores
 
+- Integrated Chromatic for visual regression testing ([PR 2776](https://github.com/input-output-hk/daedalus/pull/2776))
 - Updated `trezor-connect` dependency to version `8.2.4` ([PR 2726](https://github.com/input-output-hk/daedalus/pull/2726))
 - Updated vulnerable dependencies ([PR 2769](https://github.com/input-output-hk/daedalus/pull/2769))
 - Updated CWB and Cardano Node ([PR 2799](https://github.com/input-output-hk/daedalus/pull/2799))

README.md

@@ -194,6 +194,15 @@ Make sure to list bootstrap in externals in `webpack.config.base.js` or the app
 externals: ['bootstrap']
 ```
 
+### Debugging
+
+You can debug the main process by following one of these approaches:
+- [VSCode](https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_attaching-to-nodejs)
+- [Chrome](https://nodejs.org/en/docs/guides/debugging-getting-started/#inspector-clients)
+- [IntelliJ](https://www.jetbrains.com/help/idea/run-debug-configuration-node-js-remote-debug.html)
+
+The inspector runs on port 9229
+
 ## Testing
 
 You can find more details regarding tests setup within

gulpfile.js

@@ -8,6 +8,7 @@ const rendererWebpackConfig = require('./source/renderer/webpack.config');
 
 // Setup electron-connect server to start the app in development mode
 let electronServer;
+const electronServerAgs = ['--inspect=9229'];
 // Gulp input sources for main and renderer compilation
 const mainInputSource = () => gulp.src('source/main/index.ts');
 const rendererInputSource = () => gulp.src('source/renderer/index.ts');
@@ -47,7 +48,7 @@ const buildMainWatch = () => (done) =>
     .pipe(
       webpackStream(mainWebpackWatchConfig, webpack, () => {
         // Restart app every time after main script has been re-compiled
-        electronServer.restart();
+        electronServer.restart(electronServerAgs);
         done();
       })
     )
@@ -79,7 +80,7 @@ gulp.task(
 gulp.task('clean:dist', shell.task('rimraf ./dist'));
 
 gulp.task('server:start', (done) => {
-  electronServer.start();
+  electronServer.start(electronServerAgs);
   done();
 });
 
@@ -92,13 +93,10 @@ gulp.task('server:create:dev', (done) => {
 });
 
 gulp.task('server:create:debug', (done) => {
-  createElectronServer(
-    {
-      NODE_ENV: process.env.NODE_ENV,
-      XCURSOR_PATH: '/usr/share/icons' || 'development',
-    },
-    ['--inspect', '--inspect-brk']
-  );
+  createElectronServer({
+    NODE_ENV: process.env.NODE_ENV,
+    XCURSOR_PATH: '/usr/share/icons' || 'development',
+  });
   done();
 });
 
@@ -171,6 +169,8 @@ gulp.task(
   )
 );
 
+gulp.task('typedef:sass', shell.task('yarn typedef:sass --watch'));
+
 gulp.task(
   'build:watch',
   gulp.series(
@@ -206,7 +206,10 @@ gulp.task(
 
 gulp.task(
   'dev',
-  gulp.series('server:create:dev', 'build:watch', 'server:start')
+  gulp.parallel(
+    gulp.series('server:create:dev', 'build:watch', 'server:start'),
+    gulp.series('typedef:sass')
+  )
 );
 
 gulp.task(

package.json

@@ -35,6 +35,7 @@
     "cleanup": "mop -v",
     "lint": "eslint --format=node_modules/eslint-formatter-pretty source storybook utils  --ext .ts,.tsx",
     "compile": "tsc --noEmit",
+    "precompile": "yarn typedef:sass",
     "prettier": "./node_modules/.bin/prettier \"**/*.*\"",
     "prettier:check": "yarn prettier --check",
     "prettier:format": "yarn prettier --write --loglevel warn",
@@ -43,6 +44,7 @@
     "manage:translations": "gulp purge:translations && gulp clear:cache && gulp build && ts-node ./translations/translation-runner.ts",
     "storybook": "start-storybook -p 6006 -c storybook --ci /",
     "storybook:build": "build-storybook -c storybook -o dist/storybook",
+    "storybook:build:chromatic": "build-storybook -c storybook",
     "themes:check:createTheme": "gulp build:themes && ts-node -r esm ./dist/scripts/check.js",
     "themes:update": "gulp build:themes && ts-node -r esm ./dist/scripts/update.js && yarn prettier --loglevel warn --write source/renderer/app/themes/daedalus/*.ts",
     "themes:copy": "ts-node -r @babel/register -r @babel/polyfill source/renderer/app/themes/utils/copyTheme.ts && yarn prettier --loglevel warn --write source/renderer/app/themes/daedalus/*.ts",
@@ -62,7 +64,8 @@
     "yoroi:wallet:importer": "ts-node utils/api-importer/yoroi-wallet-importer.ts",
     "create-news-verification-hashes": "ts-node utils/create-news-verification-hashes/index.ts",
     "lockfile:check": "ts-node utils/lockfile-checker/index.ts --check",
-    "lockfile:fix": "ts-node utils/lockfile-checker/index.ts --fix"
+    "lockfile:fix": "ts-node utils/lockfile-checker/index.ts --fix",
+    "typedef:sass": "typed-scss-modules source/renderer/app"
   },
   "bin": {
     "electron": "./node_modules/.bin/electron"
@@ -148,12 +151,12 @@
     "mini-css-extract-plugin": "0.12.0",
     "minimist": "1.2.5",
     "mobx-react-devtools": "6.1.1",
-    "node-forge": "0.10.0",
+    "node-forge": "1.0.0",
     "node-libs-browser": "2.2.1",
     "node-sass": "4.14.1",
     "nodemon": "2.0.4",
     "npmlog": "4.1.2",
-    "postcss": "7.0.39",
+    "postcss": "8.2.13",
     "postcss-modules": "1.5.0",
     "prettier": "2.1.2",
     "pretty-quick": "3.0.2",
@@ -175,6 +178,7 @@
     "timemachine": "0.3.2",
     "transform-loader": "0.2.4",
     "ts-node": "^10.4.0",
+    "typed-scss-modules": "5.0.0",
     "typescript": "^4.5.5",
     "url-loader": "2.0.1",
     "utf-8-validate": "5.0.2",
@@ -232,6 +236,7 @@
     "mobx-react-form": "2.0.8",
     "mobx-react-router": "4.1.0",
     "moment": "2.29.0",
+    "nanoid": "3.2.0",
     "node-downloader-helper": "1.0.18",
     "omit-deep-lodash": "1.1.5",
     "pbkdf2": "3.0.17",
@@ -249,7 +254,7 @@
     "react-intl": "2.7.2",
     "react-lottie": "1.2.3",
     "react-markdown": "4.3.1",
-    "react-polymorph": "1.0.3",
+    "react-polymorph": "1.0.2",
     "react-router": "5.2.0",
     "react-router-dom": "5.2.0",
     "react-svg-inline": "2.1.1",

source/common/types/logging.types.ts

@@ -19,10 +19,10 @@ import type { AdaApiStakePool } from '../../renderer/app/api/staking/types';
 
 export type LoggingLevel = 'debug' | 'info' | 'error' | 'warn';
 export type Logger = {
-  debug: (arg0: string, arg1: Record<string, any> | null | undefined) => void;
-  info: (arg0: string, arg1: Record<string, any> | null | undefined) => void;
-  error: (arg0: string, arg1: Record<string, any> | null | undefined) => void;
-  warn: (arg0: string, arg1: Record<string, any> | null | undefined) => void;
+  debug: (arg0: string, arg1?: Record<string, any> | null | undefined) => void;
+  info: (arg0: string, arg1?: Record<string, any> | null | undefined) => void;
+  error: (arg0: string, arg1?: Record<string, any> | null | undefined) => void;
+  warn: (arg0: string, arg1?: Record<string, any> | null | undefined) => void;
 };
 export type FormatMessageContextParams = {
   appName: string;

source/main/ipc/downloadManagerChannel.ts

@@ -211,8 +211,9 @@ const getDownloadLocalData = async ({
 
 const getDownloadsLocalData = async (): Promise<
   DownloadsLocalDataMainResponse
-  // @ts-ignore ts-migrate(2322) FIXME: Type 'unknown' is not assignable to type 'Download... Remove this comment to see the full error message
-> => localStorage.getAll();
+> => {
+  return localStorage.getAll() as Promise<DownloadsLocalDataMainResponse>;
+};
 
 const clearDownloadLocalData = async ({
   fileName,

source/renderer/app/actions/lib/Action.ts

@@ -30,7 +30,7 @@ export default class Action<Params> {
     this.listeners.push(listener);
   }
 
-  trigger(params: Params) {
+  trigger(params?: Params) {
     this.listeners.forEach((listener) => listener(params));
   }
 

source/renderer/app/actions/wallets-actions.ts

@@ -60,6 +60,7 @@ export default class WalletsActions {
     passphrase: string;
     assets?: Array<AssetToken>;
     assetsAmounts?: Array<string>;
+    hasAssetsRemainingAfterTransaction?: boolean;
   }> = new Action();
   chooseWalletExportType: Action<{
     walletExportType: WalletExportTypeChoices;