Skip to content

Commit aa05372

Browse files
author
Marcin Mazurek
authored
Merge pull request #3126 from input-output-hk/chore/ddw-1221-fix-chromatic
[DDW-1221] Remove Chromatic from project
2 parents ffaace8 + 619cd98 commit aa05372

File tree

7 files changed

+5
-51
lines changed

7 files changed

+5
-51
lines changed

.github/pull_request_template.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
4141
- [ ] PR assigned to the PR author(s)
4242
- [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers
4343
- [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
44-
- [ ] All visual regression testing has been reviewed (assign `run Chromatic` label to PR to trigger the run)
4544
- [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`)
4645
- [ ] PR link is added to a Jira ticket, ticket moved to In Review
4746
- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)

.github/workflows/chromatic.yml

Lines changed: 0 additions & 39 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
### Chores
1010

11+
- Removed Chromatic from project ([PR 3126](https://github.com/input-output-hk/daedalus/pull/3126))
1112
- Upgraded Electron to 24.2, and Node.js to 18.× ([PR 3124](https://github.com/input-output-hk/daedalus/pull/3124))
1213
- Defined a proxy for currency conversions ([PR 3121](https://github.com/input-output-hk/daedalus/pull/3121))
1314
- Switched Daedalus to be built with Nix flakes ([PR 3008](https://github.com/input-output-hk/daedalus/pull/3008))

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
"i18n:manage": "yarn i18n:extract && yarn i18n:check",
5555
"storybook": "start-storybook -p 6006 -c storybook --ci /",
5656
"storybook:build": "build-storybook -c storybook -o dist/storybook",
57-
"storybook:build:chromatic": "build-storybook -c storybook",
5857
"themes:check:createTheme": "gulp build:themes && yarn node-swc ./dist/scripts/check.js",
5958
"themes:update": "gulp build:themes && yarn node-swc ./dist/scripts/update.js && yarn prettier --loglevel warn --write source/renderer/app/themes/daedalus/*.ts",
6059
"themes:copy": "yarn node-swc source/renderer/app/themes/utils/copyTheme.ts && yarn prettier --loglevel warn --write source/renderer/app/themes/daedalus/*.ts",

source/renderer/app/components/loading/syncing-connecting/LogosDisplay.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default class LogosDisplay extends Component<Props> {
4646
return (
4747
<div className={styles.component}>
4848
<SVGInline svg={adaLogo} className={currencyLogoStyles} />
49-
<div className={daedalusLogoStyles} data-chromatic="ignore">
49+
<div className={daedalusLogoStyles}>
5050
<Lottie options={logoAnimationOptionsLottie} />
5151
</div>
5252
<SVGInline svg={cardanoLogo} className={apiLogoStyles} />

storybook/monkeyPatchDateTime.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

storybook/stories/settings/general/General.stories.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ const getParamName = (obj, itemName): any =>
3737
Object.entries(obj).find((entry: [any, any]) => itemName === entry[1]);
3838

3939
/* eslint-disable consistent-return */
40+
// @ts-ignore
41+
// @ts-ignore
4042
storiesOf('Settings / General', module)
4143
.addDecorator(SettingsWrapper) // ====== Stories ======
4244
.add(
@@ -99,6 +101,7 @@ storiesOf('Settings / General', module)
99101
}}
100102
/>
101103
))
104+
// @ts-ignore ts-migrate(2345)
102105
.add('Terms of Service', (_, props) => {
103106
const termsOfUseSource = require(`../../../../source/renderer/app/i18n/locales/terms-of-use/${props.locale}.md`);
104107

0 commit comments

Comments
 (0)