Merge branch 'develop' into chore/ddw-895-update-cardano-launcher

Author: Lucas Araujo

.babelrc

@@ -2,7 +2,7 @@
   "presets": [
     "@babel/preset-env",
     "@babel/preset-react",
-    "@babel/preset-flow"
+    "@babel/preset-typescript"
   ],
   "plugins": [
     ["@babel/plugin-proposal-decorators", { "legacy": true }],

.eslintrc

@@ -1,17 +1,17 @@
 {
-  "parser": "@babel/eslint-parser",
+  "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "ecmaFeatures": {
       "legacyDecorators": true
     }
   },
   "extends": [
     "airbnb",
-    "plugin:flowtype/recommended",
+    "plugin:@typescript-eslint/recommended",
     "plugin:react/recommended",
     "prettier",
     "prettier/babel",
-    "prettier/flowtype",
+    "prettier/@typescript-eslint",
     "prettier/react",
     "plugin:jest/recommended"
   ],
@@ -24,7 +24,7 @@
   "rules": {
     "class-methods-use-this": 0,
     "consistent-return": "warn",
-    "flowtype/generic-spacing": 0,
+    "@typescript-eslint/generic-spacing": 0,
     "jsx-a11y/alt-text": 0,
     "lines-between-class-members": 0,
     "global-require": 0,
@@ -69,19 +69,24 @@
     "react/no-array-index-key": "warn",
     "react/no-unused-prop-types": "warn",
     "react/prefer-stateless-function": 0,
-    "react/prop-types": "warn",
+    "react/prop-types": 0,
     "react/require-default-props": 0,
+    "react/jsx-first-prop-new-line": [1, "multiline-multiprop"],
+    "@typescript-eslint/ban-ts-comment": 1,
+    "@typescript-eslint/no-empty-function": 1,
+    "@typescript-eslint/ban-types": 1,
+    "import/no-unresolved": 1,
+    "@typescript-eslint/no-var-requires": 1,
+    "camelcase": 1,
+    "no-empty": 1,
+    "@typescript-eslint/no-explicit-any": 1,
+    "no-shadow": 1,
+    "react/no-did-update-set-state": 1,
     "react/sort-comp": 0,
     "react/state-in-constructor": 0,
     "react/static-property-placement": 0
   },
-  "plugins": [
-    "flowtype",
-    "import",
-    "promise",
-    "react",
-    "jest"
-  ],
+  "plugins": ["@typescript-eslint", "import", "promise", "react", "jest"],
   "globals": {
     "API": true,
     "API_VERSION": true,
@@ -91,6 +96,19 @@
     "Process": true // TODO: remove after fix
   },
   "settings": {
-    "import/resolver": "webpack"
-  }
+    "import/resolver": {
+      "node": {
+        "extensions": [".js", ".jsx", ".ts", ".tsx"]
+      }
+    }
+  },
+  "overrides": [
+    {
+      "files": "**/*.ts",
+      "rules": {
+          "no-useless-constructor": "off",
+          "@typescript-eslint/no-useless-constructor": "error"
+      }
+    }
+  ]
 }

.flowconfig

@@ -20,7 +20,7 @@ or animated GIFs of important UI changes in both English and Japanese.
 Do not use shadow or any effects. On macOS this can be accomplished the following way:
 1. Use the Command+Shift+4 keyboard shortcut.
 2. Press the Spacebar.
-3. Hold the Option button and click the window you want to capture. 
+3. Hold the Option button and click the window you want to capture.
 -->
 
 ## Testing Checklist
@@ -29,7 +29,6 @@ Do not use shadow or any effects. On macOS this can be accomplished the followin
 Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam`, link the thread below
 -->
 
-
 - [Slack QA thread](https://input-output-rnd.slack.com/messages/GGKFXSKC6)
 - [ ] Test
 
@@ -38,34 +37,38 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
 ## Review Checklist
 
 ### Basics
-- [ ] PR assigned to the PR author(s) 
+
+- [ ] PR assigned to the PR author(s)
 - [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers
 - [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
-- [ ] All visual regression testing has been reviewed (Go to Github Actions tab -> Select Chromatic workflow -> Run on your working branch)
+- [ ] All visual regression testing has been reviewed (assign `run Chromatic` label to PR to trigger the run)
 - [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`)
 - [ ] PR link is added to a Jira ticket, ticket moved to In Review
 - [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
 - [ ] PR has a good description that summarizes all changes
 - [ ] PR contains screenshots (in case of UI changes)
-- [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub
+- [ ] CHANGELOG entry has been added to the top of the appropriate section (_Features_, _Fixes_, _Chores_) and is linked to the correct PR on GitHub
 - [ ] There are no missing translations (running `yarn manage:translations` produces no changes)
 - [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
 - [ ] Japanese text changes are proofread and approved (Junko Oda)
 - [ ] Storybook works and no stories are broken (`yarn storybook`)
 - [ ] In case of dependency changes `yarn.lock` file is updated
 
 ### Code Quality
+
 - [ ] Important parts of the code are properly commented and documented
-- [ ] Code is properly typed with flow
+- [ ] Code is properly typed with typescript types
 - [ ] React components are split-up enough to avoid unnecessary re-renderings
 - [ ] Any code that only works in main process is neatly separated from components
 
 ### Testing
+
 - [ ] New feature/change is covered by acceptance tests
 - [ ] New feature/change is manually tested and approved by QA team
 - [ ] All existing acceptance tests are still up-to-date
 - [ ] New feature/change is covered by Daedalus Testing scenario
 - [ ] All existing Daedalus Testing scenarios are still up-to-date
 
 ### After Review
+
 - [ ] Update Slack QA thread by marking it with a green checkmark

.github/pull_request_template.md

@@ -1,13 +1,18 @@
 name: 'Chromatic'
 on:
-  workflow_dispatch:
+  pull_request:
+    types:
+      - labeled
   push:
     branches:
       - develop
 
 jobs:
   chromatic-deployment:
+    if: contains(github.event.pull_request.labels.*.name, 'run Chromatic') || github.ref == 'refs/heads/develop'
     runs-on: ubuntu-latest
+    env:
+      STORYBOOK_FREEZE_DATE: "true"
     steps:
       - uses: actions/checkout@v1
       - name: Setup Node.js
@@ -23,10 +28,12 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           exitZeroOnChanges: true
+          buildScriptName: 'storybook:build:chromatic'
       - name: Publish to Chromatic and auto accept changes
         if: github.ref == 'refs/heads/develop'
         uses: chromaui/action@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           autoAcceptChanges: true
+          buildScriptName: 'storybook:build:chromatic'

.github/workflows/chromatic.yml

@@ -0,0 +1,26 @@
+name: Verify Pull Request
+on:
+  pull_request:
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2
+      - name: Setup Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: "14"
+      - name: Restore node_modules from cache
+        uses: actions/cache@v2
+        with:
+          path: '**/node_modules'
+          key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
+      - name: Install dependencies
+        run: yarn --frozen-lockfile
+      - name: Run checks
+        run: yarn check:all
+      - name: Ensure there are no uncommited changes
+        run: git diff --exit-code || (echo "Did you forget to run 'yarn check:all' and commit changes?" && exit 1)
+      - name: Run tests
+        run: yarn test:jest --maxWorkers=3

.github/workflows/linter.yml

@@ -119,3 +119,6 @@ Debug
 /cardano-cli
 /cardano-wallet
 .vscode
+
+# Typescript
+*.scss.d.ts

.github/workflows/run_tests_on_pr.yml

@@ -11,6 +11,8 @@
 
 # But not these file types
 !*.js
+!*.ts
+!*.tsx
 !*.scss
 !*.json