Merge pull request #3117 from input-output-hk/chore/ddw-1202-regenerate-dev-certs

Author: danielmain

.buildkite/pipeline.yml

@@ -11,8 +11,6 @@ steps:
   - label: 'daedalus-x86_64-darwin'
     command: 'scripts/with-nix-2.5.sh scripts/build-installer-unix.sh --build-id $BUILDKITE_BUILD_NUMBER'
     depends_on: 'trigger-x86_64-darwin'
-    env:
-      NIX_SSL_CERT_FILE: /nix/var/nix/profiles/default/etc/ssl/certs/ca-bundle.crt
     agents:
       queue: daedalus
       system: x86_64-darwin
@@ -21,7 +19,6 @@ steps:
     command: 'scripts/with-nix-2.5.sh scripts/build-installer-unix.sh --build-id $BUILDKITE_BUILD_NUMBER'
     depends_on: 'trigger-aarch64-darwin'
     env:
-      NIX_SSL_CERT_FILE: /nix/var/nix/profiles/default/etc/ssl/certs/ca-bundle.crt
       UPLOAD_DIR_OVERRIDE: UNSAFE-internal-build
     agents:
       queue: daedalus

.gitignore

@@ -51,10 +51,6 @@ installers/csl-daedalus/
 installers/delegation.cert
 installers/signing.key
 
-# temporary certs for daedalus dev
-tls/client
-tls/server
-
 # App packaged
 dist
 release

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Chores
 
 - Updated `@cardano-foundation/ledgerjs-hw-app-cardano` to version `6.0.0` ([PR 3093](https://github.com/input-output-hk/daedalus/pull/3093))
+- Added regeneration of dev TLS certificates for cardano-wallet on each nix-shell entry ([PR 3117](https://github.com/input-output-hk/daedalus/pull/3117))
 
 ## 5.2.0
 

scripts/package.js

@@ -37,7 +37,6 @@ const DEFAULT_OPTS = {
     /^\/storybook($|\/)/,
     /^\/tests($|\/)/,
     /^\/tests-report($|\/)/,
-    /^\/tls($|\/)/,
     /^\/translations($|\/)/,
   ],
 };

shell.nix

@@ -52,6 +52,7 @@ let
       daedalusPkgs.daedalus-installer
       daedalusPkgs.darwin-launcher
       daedalusPkgs.mock-token-metadata-server
+      regenerateDevCerts
     ] ++ (with pkgs; [
       nix bash binutils coreutils curl gnutar
       git python27 curl jq
@@ -74,7 +75,17 @@ let
     name = "daedalus-build";
     buildInputs = daedalusShellBuildInputs;
   };
-
+  regenerateDevCerts = let
+    moddedConfig = pkgs.writeText "launcher-config.yaml" (builtins.toJSON (
+      daedalusPkgs.launcherConfigs.launcherConfig
+      // {
+        daedalusBin = "true";
+      }
+    ));
+  in
+    pkgs.writeShellScriptBin "regenerate-dev-certs" ''
+      ${daedalusPkgs.daedalus-bridge}/bin/cardano-launcher --config ${moddedConfig}
+    '';
   gcRoot = pkgs.runCommandLocal "gc-root" {
     properBuildShell = buildShell.overrideAttrs (old: { buildCommand = "export >$out"; });
     cardanoWalletsHaskellNix = daedalusPkgs.walletFlake.outputs.legacyPackages.${system}.roots;
@@ -182,6 +193,17 @@ let
 
       echo 'jq < $LAUNCHER_CONFIG'
       echo debug the node by running debug-node
+
+      echo 'Resolving environment variables to absolute paths…'
+      # XXX: they originally contain references to HOME or XDG_DATA_HOME in launcher-config.yaml:
+      export CARDANO_WALLET_TLS_PATH="${daedalusPkgs.launcherConfigs.launcherConfig.tlsPath}"
+
+      echo 'Re-generating dev certificates for ‘cardano-wallet’…'
+      mkdir -p "$CARDANO_WALLET_TLS_PATH"
+      regenerate-dev-certs >/dev/null
+
+      echo
+      echo 'Now, run ‘yarn dev’.'
     '';
   });
   daedalus = daedalusShell.overrideAttrs (oldAttrs: {

source/main/cardano/CardanoWalletLauncher.ts

@@ -83,15 +83,6 @@ export async function CardanoWalletLauncher(
     svCert: path.join(tlsPath, 'server/server.crt'),
     svKey: path.join(tlsPath, 'server/server.key'),
   };
-  // Prepare development TLS files
-  const { isProduction } = environment;
-
-  if (
-    !isProduction &&
-    nodeImplementation === CardanoNodeImplementationOptions.CARDANO
-  ) {
-    await fs.copy('tls', tlsPath);
-  }
 
   let tokenMetadataServer;
   // This switch statement handles any node specific