Address PR feedback

Author: Marcin Mazurek

source/renderer/app/stores/VotingStore.ts

@@ -11,10 +11,13 @@ import { formattedArrayBufferToHexString } from '../utils/formatters';
 import walletUtils from '../utils/walletUtils';
 import {
   VOTING_PHASE_CHECK_INTERVAL,
-  VOTING_REGISTRATION_TRANSACTION_POLLING_INTERVAL,
   VOTING_REGISTRATION_MIN_TRANSACTION_CONFIRMATIONS,
+  VOTING_REGISTRATION_TRANSACTION_POLLING_INTERVAL,
 } from '../config/votingConfig';
-import { votingPDFGenerator } from '../utils/votingPDFGenerator';
+import {
+  votingPDFGenerator,
+  VotingPDFGeneratorResult,
+} from '../utils/votingPDFGenerator';
 import { i18nContext } from '../utils/i18nContext';
 import type { PathRoleIdentityType } from '../utils/hardwareWalletUtils';
 import type {
@@ -423,7 +426,7 @@ export default class VotingStore extends Store {
     const { network, isMainnet } = this.environment;
     const intl = i18nContext(currentLocale);
 
-    const wasSaved = await votingPDFGenerator({
+    const result = await votingPDFGenerator({
       nextVotingFundNumber,
       qrCode,
       walletName,
@@ -436,7 +439,7 @@ export default class VotingStore extends Store {
       intl,
     });
 
-    if (wasSaved) {
+    if (result === VotingPDFGeneratorResult.FileSaved) {
       this.actions.voting.saveAsPDFSuccess.trigger();
     }
   };

source/renderer/app/utils/votingPDFGenerator.ts

@@ -34,6 +34,7 @@ const messages = defineMessages({
     description: 'PDF author',
   },
 });
+
 type Params = {
   nextVotingFundNumber: number;
   qrCode: string;
@@ -46,6 +47,12 @@ type Params = {
   isMainnet: boolean;
   intl: Record<string, any>;
 };
+
+export enum VotingPDFGeneratorResult {
+  FileSaved = 'FileSaved',
+  CancelledByUser = 'CancelledByUser',
+}
+
 export const votingPDFGenerator = async ({
   nextVotingFundNumber,
   qrCode,
@@ -57,7 +64,7 @@ export const votingPDFGenerator = async ({
   network,
   isMainnet,
   intl,
-}: Params): Promise<boolean> => {
+}: Params): Promise<VotingPDFGeneratorResult> => {
   // Consolidate data
   const title = intl.formatMessage(messages.title, {
     nextVotingFundNumber,
@@ -95,7 +102,7 @@ export const votingPDFGenerator = async ({
   const filePath = dialogPath.filePath || '';
 
   if (dialogPath.canceled || !!filePath) {
-    return false;
+    return VotingPDFGeneratorResult.CancelledByUser;
   }
 
   await generateVotingPDFChannel.send({
@@ -112,5 +119,5 @@ export const votingPDFGenerator = async ({
     author,
   });
 
-  return true;
+  return VotingPDFGeneratorResult.FileSaved;
 };