Skip to content

Commit d105ca6

Browse files
committed
[DDW-1011] prevent news feed from overlapping full screen dialogs
1 parent 3bf4547 commit d105ca6

File tree

6 files changed

+20
-4
lines changed

6 files changed

+20
-4
lines changed

source/renderer/app/containers/staking/dialogs/redeem-itn-rewards/Step1ConfigurationContainer.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,15 @@ class Step1ConfigurationContainer extends Component<Props> {
4141
return walletAmount && walletAmount.gte(minRewardsFunds);
4242
};
4343

44+
componentDidMount() {
45+
const { app } = this.props.stores;
46+
const { closeNewsFeed } = this.props.actions.app;
47+
48+
if (app.newsFeedIsOpen) {
49+
closeNewsFeed.trigger();
50+
}
51+
}
52+
4453
render() {
4554
const { actions, stores, onBack, onClose } = this.props;
4655
const { app, staking, wallets } = stores;

source/renderer/app/containers/static/AboutDialog.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import '../../themes/mixins/overlay-backdrop';
2+
@import '../../themes/mixins/layers';
23

34
.overlay {
45
background-color: var(--theme-about-window-background-color);
@@ -9,7 +10,7 @@
910
position: fixed;
1011
right: 0;
1112
top: 0;
12-
z-index: 9999;
13+
z-index: $dialog-z-index;
1314

1415
&::-webkit-scrollbar-button {
1516
height: 21px;

source/renderer/app/containers/status/DaedalusDiagnosticsDialog.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import '../../themes/mixins/overlay-backdrop';
2+
@import '../../themes/mixins/layers';
23

34
.overlay {
45
bottom: 0;
@@ -7,7 +8,7 @@
78
position: fixed;
89
right: 0;
910
top: 0;
10-
z-index: 9999;
11+
z-index: $dialog-z-index;
1112
@include overlay-backrop;
1213

1314
*::-webkit-scrollbar-button {

source/renderer/app/stores/AppStore.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ export default class AppStore extends Store {
196196
};
197197
@action
198198
_updateActiveDialog = (currentDialog: ApplicationDialog) => {
199+
if (this.newsFeedIsOpen) {
200+
this.newsFeedIsOpen = false;
201+
}
199202
if (this.activeDialog !== currentDialog) this.activeDialog = currentDialog;
200203
};
201204
@action
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
$dialog-z-index: 10001;
1+
$backdrop-z-index: 10000;
2+
$dialog-z-index: 10000;
23
$loader-backdrop-z-index: 5;
34
$back-to-top-z-index: 5;
45
$sticky-header-z-index: 1;

source/renderer/app/themes/overrides/ModalOverrides.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
@import '../mixins/overlay-backdrop';
2+
@import '../mixins/layers.scss';
23

34
.overlay {
45
@include overlay-backrop;
56
overflow: hidden;
6-
z-index: 100;
7+
z-index: $backdrop-z-index;
78
}
89

910
.modal {

0 commit comments

Comments
 (0)