[DDW-738] Review changes

Author: Lucas Araujo

source/renderer/app/components/sidebar/Sidebar.js

@@ -26,12 +26,10 @@ type Props = {
   isShelleyActivated: boolean,
 };
 
-const getCategoryContent = (categoryName: string, network) => {
-  if (categoryName === 'NETWORK_INFO') {
-    return <SidebarCategoryNetworkInfo network={network} />;
-  }
-  return null;
-};
+const getCategoryContent = (categoryName: string, network) =>
+  categoryName === 'NETWORK_INFO' ? (
+    <SidebarCategoryNetworkInfo network={network} />
+  ) : null;
 
 const Sidebar = ({
   menus,
@@ -81,10 +79,8 @@ const Sidebar = ({
         <SidebarWalletsMenu
           wallets={menus?.wallets?.items || []}
           onAddWallet={onAddWallet}
-          onWalletItemClick={menus?.wallets?.actions?.onWalletItemClick || null}
-          isActiveWallet={(id) =>
-            id === (menus?.wallets?.activeWalletId || null)
-          }
+          onWalletItemClick={menus?.wallets?.actions?.onWalletItemClick}
+          isActiveWallet={(id) => id === menus?.wallets?.activeWalletId}
           isAddWalletButtonActive={pathname === ROUTES.WALLETS.ADD}
           isShelleyActivated={isShelleyActivated}
           visible={isShowingSubMenus}

source/renderer/app/components/sidebar/helpers.js

@@ -1,14 +1,9 @@
 // @flow
 import type { ShouldShowWalletSubMenu } from './types';
 
-export const isCategoryActive = (
-  activeSidebarCategory: string,
-  currentRoute: string
-) => activeSidebarCategory === currentRoute;
-
 export const shouldShowWalletSubMenu = ({
   activeSidebarCategory,
   walletRoute,
   menus,
 }: ShouldShowWalletSubMenu) =>
-  menus?.wallets?.items && isCategoryActive(activeSidebarCategory, walletRoute);
+  menus?.wallets?.items && activeSidebarCategory === walletRoute;