Merge pull request #2915 from input-output-hk/chore/ddw-1009-fix-spelling-and-typos

Author: danielmain

BESTPRACTICES.md

@@ -1108,7 +1108,7 @@ type Props = {
 };
 ```
 
-For preventing syntax errors, leave a comma after the last key/value pair incase the type definition's properties are rearranged or expanded upon in the future.
+For preventing syntax errors, leave a comma after the last key/value pair in case the type definition's properties are rearranged or expanded upon in the future.
 
 :white_check_mark: ***Do***
 
@@ -1204,7 +1204,7 @@ const Names = () => (<div>
 ## Formatting Selectors
 
 * Use class selectors instead of ID selectors.
-* Use camelCase or dashed-case instead of PascelCase or names_with_underscores.
+* Use camel case or dashed-case instead of pascal case or names_with_underscores.
 * Give each selector its own line.
 * Put a space before the opening brace `{` in rule declarations.
 * Put closing braces `}` of rule declarations on a new line.

CHANGELOG.md

@@ -9,6 +9,7 @@
 
 ### Chores
 
+- Fixed spelling issues and typos ([PR 2915](https://github.com/input-output-hk/daedalus/pull/2915))
 - Removed SASS ts-lint ignore comments ([PR 2870](https://github.com/input-output-hk/daedalus/pull/2870))
 - Enabled debugging of the main process ([PR 2893](https://github.com/input-output-hk/daedalus/pull/2893))
 

default.nix

@@ -40,7 +40,7 @@ let
   inherit (pkgs.lib) optionalString optional concatStringsSep;
   inherit (pkgs) writeTextFile;
   crossSystem = lib: (crossSystemTable lib).${target} or null;
-  # TODO, nsis cant cross-compile with the nixpkgs daedalus currently uses
+  # TODO, nsis can't cross-compile with the nixpkgs daedalus currently uses
   nsisNixPkgs = import localLib.sources.nixpkgs-nsis {};
   installPath = ".daedalus";
   needSignedBinaries = (signingKeys != null) || (HSMServer != null);

nix/nsis-inner.nix

@@ -43,7 +43,7 @@ in stdenv.mkDerivation {
   '';
 
   meta = with lib; {
-    descripition = "System to create Windows installers";
+    description = "System to create Windows installers";
     homepage = "https://nsis.sourceforge.io/";
   };
 }

source/common/config/downloadManagerConfig.ts

@@ -1,14 +1,13 @@
 // https://www.npmjs.com/package/node-downloader-helper
 import type {
-  AllowedDownloadDirectories,
+  AllowedDownloadDirectoriesValues,
+  AllowedDownloadDirectoriesKeys,
+  AllowedDownloadDirectoriesMap,
   DownloadState,
   DownloadEventType,
 } from '../types/downloadManager.types';
 
-export const ALLOWED_DOWNLOAD_DIRECTORIES: Record<
-  string,
-  AllowedDownloadDirectories
-> = {
+export const ALLOWED_DOWNLOAD_DIRECTORIES: AllowedDownloadDirectoriesMap = {
   DOWNLOADS: 'downloads',
   DESKTOP: 'desktop',
   STATE_DIRECTORY: 'stateDirectory',

source/common/ipc/api.ts

@@ -478,8 +478,8 @@ export type getCardanoAdaAppRendererRequest = {
 export type getCardanoAdaAppMainResponse = HardwareWalletCardanoAdaAppResponse;
 export const GET_HARDWARE_WALLET_CONNECTION_CHANNEL =
   'GET_HARDWARE_WALLET_CONNECTION_CHANNEL';
-export type getHardwareWalletConnectiontMainRequest = HardwareWalletConnectionRequest;
-export type getHardwareWalletConnectiontRendererResponse = Record<string, any>;
+export type getHardwareWalletConnectionMainRequest = HardwareWalletConnectionRequest;
+export type getHardwareWalletConnectionRendererResponse = Record<string, any>;
 export const SIGN_TRANSACTION_LEDGER_CHANNEL =
   'SIGN_TRANSACTION_LEDGER_CHANNEL';
 export type signTransactionLedgerRendererRequest = LedgerSignTransactionRequest;

source/common/types/downloadManager.types.ts

@@ -1,7 +1,17 @@
-export type AllowedDownloadDirectories =
+export type AllowedDownloadDirectoriesValues =
   | 'stateDirectory'
   | 'downloads'
   | 'desktop';
+
+export type AllowedDownloadDirectoriesKeys =
+  | 'DOWNLOADS'
+  | 'DESKTOP'
+  | 'STATE_DIRECTORY';
+
+export type AllowedDownloadDirectoriesMap = {
+  [day in AllowedDownloadDirectoriesKeys]: AllowedDownloadDirectoriesValues;
+};
+
 // https://www.npmjs.com/package/node-downloader-helper
 export type DownloadRequest = {
   /**
@@ -12,7 +22,7 @@ export type DownloadRequest = {
    */
   id?: string;
   fileUrl: string;
-  destinationDirectoryName?: AllowedDownloadDirectories;
+  destinationDirectoryName?: AllowedDownloadDirectoriesValues;
   options?: DownloadRequestOptions | null | undefined;
   resumeDownload?: {
     temporaryFilename: string;
@@ -47,7 +57,7 @@ export type DownloadRequestOptions = {
   httpsRequestOptions?: Record<string, any>;
   // Override the https request options, ex: to add SSL Certs
   progressIsThrottled?: boolean;
-  // by default, the progress is sent every second. if `false` it will be sent every milisecond
+  // by default, the progress is sent every second. if `false` it will be sent every millisecond
   persistLocalData?: boolean; // by default, the localdata information is deleted after the end of the download
 };
 // https://www.npmjs.com/package/node-downloader-helper
@@ -82,7 +92,7 @@ export type DownloadInfo = {
   fileUrl: string;
   originalFilename: string;
   temporaryFilename: string;
-  destinationDirectoryName: AllowedDownloadDirectories;
+  destinationDirectoryName: AllowedDownloadDirectoriesValues;
   destinationPath: string;
   options: DownloadRequestOptions;
 };
@@ -138,7 +148,7 @@ export type DownloadInfoProgress = {
   downloaded: number;
   // downloaded size in bytes
   progress: number;
-  // progress porcentage 0-100%
+  // progress percentage 0-100%
   speed: number; // download speed in bytes
 };
 export type DownloadInfoEnd = {
@@ -147,7 +157,7 @@ export type DownloadInfoEnd = {
   totalSize: number;
   // total file size got from the server
   incomplete: boolean;
-  // true/false if the download endend but still incomplete
+  // true/false if the download ended but still incomplete
   onDiskSize: number;
   // total size of file on the disk
   downloadedSize: number; // the total size downloaded

source/main/cardano/CardanoNode.ts

@@ -522,7 +522,7 @@ export class CardanoNode {
   }
 
   /**
-   * Kills cardano-node and waitsup to `killTimeout` for the node to
+   * Kills cardano-node and waits up to `killTimeout` for the node to
    * report the exit message.
    *
    * @returns {Promise<void>} resolves if the node could be killed, rejects with error otherwise.

source/main/ipc/getHardwareWalletChannel.ts

@@ -22,8 +22,8 @@ import type {
   getCardanoAdaAppRendererRequest,
   getExtendedPublicKeyMainResponse,
   getExtendedPublicKeyRendererRequest,
-  getHardwareWalletConnectiontMainRequest,
-  getHardwareWalletConnectiontRendererResponse,
+  getHardwareWalletConnectionMainRequest,
+  getHardwareWalletConnectionRendererResponse,
   getHardwareWalletTransportMainResponse,
   getHardwareWalletTransportRendererRequest,
   handleInitLedgerConnectMainResponse,
@@ -80,8 +80,8 @@ const getCardanoAdaAppChannel: MainIpcChannel<
   getCardanoAdaAppMainResponse
 > = new MainIpcChannel(GET_CARDANO_ADA_APP_CHANNEL);
 const getHardwareWalletConnectionChannel: MainIpcChannel<
-  getHardwareWalletConnectiontMainRequest,
-  getHardwareWalletConnectiontRendererResponse
+  getHardwareWalletConnectionMainRequest,
+  getHardwareWalletConnectionRendererResponse
 > = new MainIpcChannel(GET_HARDWARE_WALLET_CONNECTION_CHANNEL);
 const signTransactionLedgerChannel: MainIpcChannel<
   signTransactionLedgerRendererRequest,

source/main/utils/downloadManager.ts

@@ -17,7 +17,7 @@ import type {
   DownloadMainResponse,
 } from '../../common/ipc/api';
 import type {
-  AllowedDownloadDirectories,
+  AllowedDownloadDirectoriesValues,
   DownloadInfoInit,
   DownloadInfoProgress,
   DownloadInfoEnd,
@@ -31,15 +31,15 @@ export const downloads = {};
 export const getIdFromFileName = (fileName: string): string =>
   fileName.replace(/\./g, '-');
 export const getPathFromDirectoryName = (
-  directoryName: AllowedDownloadDirectories
+  directoryName: AllowedDownloadDirectoriesValues
 ) => {
   const downloadsDirectory = `${stateDirectoryPath}/Downloads`;
 
   switch (directoryName) {
     case ALLOWED_DOWNLOAD_DIRECTORIES.DESKTOP:
       return app.getPath('desktop');
 
-    case ALLOWED_DOWNLOAD_DIRECTORIES.DOWLOADS:
+    case ALLOWED_DOWNLOAD_DIRECTORIES.DOWNLOADS:
       return app.getPath('downloads');
 
     default: