fix: not use ld.gold on aarch32 (#548)

It seems that using ld.gold for cross-compilation to aarch32 results in Haskell programs segfaulting when launched.

Co-authored-by: Michivi <[email protected]>

Author: michivi

builder/comp-builder.nix

@@ -75,8 +75,9 @@ let
       [ "--with-gcc=${stdenv.cc.targetPrefix}cc"
       ] ++
       # BINTOOLS
-      (if stdenv.hostPlatform.isLinux
+      (if stdenv.hostPlatform.isLinux && !stdenv.targetPlatform.isAarch32
         # use gold as the linker on linux to improve link times
+        # Causes segfaults on Aarch32 though.
         then [
           "--with-ld=${stdenv.cc.bintools.targetPrefix}ld.gold"
           "--ghc-option=-optl-fuse-ld=gold"

compiler/ghc/default.nix

@@ -42,13 +42,7 @@
   # specific flavour and falls back to ghc default values.
   ghcFlavour ? stdenv.lib.optionalString haskell-nix.haskellLib.isCrossTarget (
     if useLLVM
-      then (
-        # TODO check if the issues with qemu and Aarch32 persist. See
-        # https://github.com/input-output-hk/haskell.nix/pull/411/commits/1986264683067198e7fdc1d665351622b664712e
-        if stdenv.targetPlatform.isAarch32
-          then "quick-cross"
-          else "perf-cross"
-      )
+      then "perf-cross"
       else "perf-cross-ncg"
     )
 
@@ -218,13 +212,15 @@ in let configured-src = stdenv.mkDerivation (rec {
             "--with-iconv-includes=${libiconv}/include" "--with-iconv-libraries=${libiconv}/lib"
         ] ++ stdenv.lib.optionals (targetPlatform != hostPlatform) [
             "--enable-bootstrap-with-devel-snapshot"
-        ] ++ stdenv.lib.optionals (targetPlatform.isAarch32) [
-            "CFLAGS=-fuse-ld=gold"
-            "CONF_GCC_LINKER_OPTS_STAGE1=-fuse-ld=gold"
-            "CONF_GCC_LINKER_OPTS_STAGE2=-fuse-ld=gold"
         ] ++ stdenv.lib.optionals (disableLargeAddressSpace) [
             "--disable-large-address-space"
         ];
+        # FIXME Currently causes segfaults on armv6l cross-compilation.
+        # ++ stdenv.lib.optionals (targetPlatform.isAarch32) [
+        #     "CFLAGS=-fuse-ld=gold"
+        #     "CONF_GCC_LINKER_OPTS_STAGE1=-fuse-ld=gold"
+        #     "CONF_GCC_LINKER_OPTS_STAGE2=-fuse-ld=gold"
+        # ] ;
 
         outputs = [ "out" ];
         phases = [ "unpackPhase" "patchPhase" ]