Skip to content

Replace isDragonfly with isDragonFly in nix-tools #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2025
Merged

Replace isDragonfly with isDragonFly in nix-tools #2384

merged 4 commits into from
Jun 9, 2025

Conversation

@hamishmack
Copy link
Collaborator

@hamishmack hamishmack commented Jun 7, 2025

Fixes #2312

@hamishmack hamishmack merged commit 26acfef into master Jun 9, 2025
@thomasjm
Copy link
Contributor

thomasjm commented Jun 11, 2025

Hi @hamishmack -- there are a couple other cases of irregular capitalization that need to be handled to fully fix #2312.

I think the following cases need to be added to the fixSystem function:

fixSystem "isHpux" = "isHPUX"
fixSystem "isIos" = "isIOS"
fixSystem "isIrix" = "isIRIX"

I'm looking at the values here:

haskell.nix/lib/cabal-os-arch-comp.nix

Lines 18 to 38 in 70b7857

os = {
# OSs
isLinux = false;
isWindows = false;
isOsx = false;
isIos = false;
isFreebsd = false;
isOpenbsd = false;
isNetbsd = false;
isDragonFly = false;
isSolaris = false;
isAix = false;
isHPUX = false;
isIRIX = false;
isHalvm = false;
isHurd = false;
isIOS = false;
isAndroid = false;
isGhcjs = false;
isWasi = false;
};

I tried to do this myself but it looks like I'd have to deploy a new nix-tools to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isDragonfly instead of isDragonFly causes vty-crossplatform to fail to build

3 participants

@hamishmack @thomasjm