Fix TH code in checks for android cross compilation #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Android cross‐compilation checks and test executables to use haskellLib.check, and refactors the component builder to preserve default flags when overridden.
- Wraps
just-template-haskellbinaries inhaskellLib.checkfor both standard and “ei” builds. - Adjusts
lib/check.nixoverride to append to any existingsetupBuildFlagson Android. - Refactors
builder/comp-builder.nixto uselib.makeOverridableafter applying default arguments, with an expanded argument list.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/th-dlls/default.nix | Switches just-template-haskell executables to use haskellLib.check |
| lib/check.nix | Updates Android override to preserve and append to existing flags |
| builder/comp-builder.nix | Moves makeOverridable call below defaults and duplicates the arg list |
| , smallAddressSpace ? false | ||
|
|
||
| }: | ||
| # makeOverridable is called here after all the `? DEFAULT` arguments |
There was a problem hiding this comment.
[nitpick] The large duplicated argument list between the function signature and the final inherit block can be error-prone to maintain. Consider generating the inherit list programmatically or centralizing the parameter list to avoid drift.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.