feat(hermes): dynamic init constuctor fix. (#527)

stevenj · no30bit · bkioshn · web-flow · commit 03916a5acf82 · 2025-09-03T17:07:57.000+07:00
* feat(hermes): New runtime extension initialization/finalization traits.

* fix(hermes): remove file made when debugging

* fix(hermes): spelling

* fix(hermes): dependencies

* fix(hermes): format

* Update hermes/bin/src/runtime_extensions/init/errors.rs

Co-authored-by: Artur Helmanau &lt;artur.helmanau@innowise.com&gt;

* fix(hermes): Update the runtime init errors and executor based on suggestions

* fix(hermes): Add TODO and comment to linked issue for making a key locked concurrent map.

* fix(hermes): bump wasmtime

* fix(hermes): recreated module id, instead of using the one we already created.

* fix(hermes): comments

* Update hermes/bin/src/runtime_extensions/init/errors.rs

Co-authored-by: bkioshn &lt;35752733+bkioshn@users.noreply.github.com&gt;

* Update hermes/bin/src/runtime_extensions/init/errors.rs

Co-authored-by: bkioshn &lt;35752733+bkioshn@users.noreply.github.com&gt;

* fix(hermes): ignore hermes target artifacts

* fix(hermes): bump earthfiles to latest cat-ci to fix build issues

* docs(hermes): Put commented out line in tun-athena showing how to enable debug level logs.

* fix(hermes): Error message now properly explains whats wrong.

* fix(hermes): put back missing constructor argument for traitreg traits

* fix(hermes): Fixup the app name inconsistencies and move app initialization to try and move it before modules

* fix(general): rust standard configs

* fix(hermes): add unit tests to detect improperly configured runtime extension initialization

* fix(general): cleanup CODEOWNERS for all team members

* fix(general): typo

* fix(general): spelling

---------

Co-authored-by: Artur Helmanau &lt;artur.helmanau@innowise.com&gt;
Co-authored-by: bkioshn &lt;35752733+bkioshn@users.noreply.github.com&gt;
diff --git a/.config/dictionaries/project.dic b/.config/dictionaries/project.dic
@@ -3,6 +3,7 @@ aarch
 abnf
 addrr
 adminer
+aido
 apskhem
 asat
 asyncio
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,7 +1,5 @@
-/dashboard/ @minikin
+* @stevenj @cong-or @rafal-ch @no30bit @bkioshn @aido-mth
 
-/hermes/ @stevenj @cong-or @rafal-ch
+/dashboard/ @minikin @stevenj
 
-/wasm/ @stevenj @cong-or @rafal-ch @no30bit 
-
-.md  @stevenj @minikin
+.md @stevenj @minikin
diff --git a/.gitignore b/.gitignore
@@ -97,4 +97,4 @@ Cargo.lock
 *.hmod
 *.wasm
 *.happ
-
+**/target/**/*
diff --git a/Earthfile b/Earthfile
@@ -1,7 +1,7 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/mdlint:v3.5.4 AS mdlint-ci
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/cspell:v3.5.4 AS cspell-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/mdlint:v3.5.14 AS mdlint-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/cspell:v3.5.14 AS cspell-ci
 
 # cspell: words livedocs sitedocs
     
diff --git a/docs/Earthfile b/docs/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/docs:v3.5.4 AS docs-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/docs:v3.5.14 AS docs-ci
 
 IMPORT .. AS repo
 IMPORT ../hermes AS hermes
diff --git a/hermes/.config/nextest.toml b/hermes/.config/nextest.toml
@@ -47,3 +47,14 @@ store-success-output = true
 # Note that if a description can be extracted from the output, it is always stored in the
 # <description> element.
 store-failure-output = true
+
+[test-groups]
+serial-integration = { max-threads = 1 }
+
+[[profile.default.overrides]]
+filter = 'test(/^serial::/)'
+test-group = 'serial-integration'
+
+[[profile.ci.overrides]]
+filter = 'test(/^serial::/)'
+test-group = "serial-integration"
diff --git a/hermes/Earthfile b/hermes/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.11 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.14 AS rust-ci
 #IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:feat/disallow-debug-format AS rust-ci
 
 # Use when debugging cat-ci locally.
diff --git a/hermes/apps/athena/modules/.gitignore b/hermes/apps/athena/modules/.gitignore
@@ -0,0 +1 @@
+hermes
diff --git a/hermes/apps/athena/modules/Earthfile b/hermes/apps/athena/modules/Earthfile
@@ -7,7 +7,7 @@ VERSION 0.8
 
 # Catalyst CI Rust Environment - provides pre-configured Rust toolchain with WASM support
 # This includes: rustc, cargo, wasm32-wasip2 target, optimization tools, and build utilities
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.4.5 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.14 AS rust-ci
 
 # Alternative for local catalyst-ci debugging (uncomment when needed):
 # IMPORT ../../../catalyst-ci/earthly/rust AS rust-ci
diff --git a/hermes/bin/src/app.rs b/hermes/bin/src/app.rs
@@ -51,7 +51,7 @@ impl Application {
     /// Create a new Hermes app
     #[must_use]
     pub(crate) fn new(
-        app_name: String,
+        app_name: ApplicationName,
         vfs: Vfs,
         modules: Vec<Module>,
     ) -> Self {
@@ -60,7 +60,7 @@ impl Application {
             .map(|module| (module.id().clone(), module))
             .collect();
         Self {
-            name: ApplicationName(app_name),
+            name: app_name,
             indexed_modules,
             vfs: Arc::new(vfs),
         }
diff --git a/hermes/bin/src/cli/playground.rs b/hermes/bin/src/cli/playground.rs
@@ -108,13 +108,13 @@ fn collect_modules(components: &[PathBuf]) -> anyhow::Result<Vec<(String, Module
 
 /// Create one-module application with temp directory VFS.
 fn create_one_module_app(
-    name: String,
+    name: &str,
     vfs_dir_path: &Path,
     module: Module,
 ) -> anyhow::Result<Application> {
-    let vfs_name = [name.as_str(), "_vfs"].concat();
+    let vfs_name = [name, "_vfs"].concat();
     let vfs = VfsBootstrapper::new(vfs_dir_path, vfs_name).bootstrap()?;
-    let app = Application::new(name, vfs, vec![module]);
+    let app = Application::new(ApplicationName::new(name), vfs, vec![module]);
 
     Ok(app)
 }
@@ -140,7 +140,7 @@ fn collect_apps(
     for (module_name, module) in modules {
         let vfs_dir_path =
             create_temp_dir_child(temp_dir, Path::new("vfs").join(&module_name).as_path())?;
-        let app = create_one_module_app(module_name, vfs_dir_path.as_path(), module)?;
+        let app = create_one_module_app(&module_name, vfs_dir_path.as_path(), module)?;
         apps.push(app);
     }
     Ok(apps)
diff --git a/hermes/bin/src/packaging/app/app_builder.rs b/hermes/bin/src/packaging/app/app_builder.rs
@@ -3,6 +3,7 @@
 use super::ApplicationPackage;
 use crate::{
     app::{Application, ApplicationName},
+    runtime_extensions::init::trait_app::{RteApp, RteInitApp},
     vfs::{PermissionLevel, Vfs, VfsBootstrapper},
 };
 
@@ -12,18 +13,21 @@ pub(crate) fn build_app<P: AsRef<std::path::Path>>(
     vfs_dir_path: P,
 ) -> anyhow::Result<Application> {
     let app_name = package.get_app_name()?;
-    let mut bootstrapper = VfsBootstrapper::new(vfs_dir_path, app_name.clone());
+    let application_name = ApplicationName::new(&app_name);
+
+    // If this does not run here, then apps are not initialized before their modules.
+    RteApp::new().init(&application_name)?;
+
+    let mut bootstrapper = VfsBootstrapper::new(vfs_dir_path, app_name);
     mount_to_vfs(package, &mut bootstrapper)?;
     let vfs = bootstrapper.bootstrap()?;
 
-    let application_name = ApplicationName::new(&app_name);
-
     let mut modules = Vec::new();
     for module_info in package.get_modules()? {
         let module = module_info.get_component(&application_name)?;
         modules.push(module);
     }
-    let app = Application::new(app_name, vfs, modules);
+    let app = Application::new(application_name, vfs, modules);
 
     Ok(app)
 }
diff --git a/hermes/bin/src/reactor.rs b/hermes/bin/src/reactor.rs
@@ -6,10 +6,7 @@ use once_cell::sync::OnceCell;
 use crate::{
     app::{Application, ApplicationName},
     event::{self, queue::ExitLock},
-    runtime_extensions::{
-        hermes::init,
-        init::trait_app::{RteApp, RteInitApp},
-    },
+    runtime_extensions::hermes::init,
 };
 
 /// Global Hermes reactor state
@@ -54,8 +51,6 @@ pub(crate) fn load_app(app: Application) -> anyhow::Result<()> {
         "Reactor not been initialized. Call `HermesEventQueue::init` first."
     ))?;
 
-    RteApp::new().init(app.name())?;
-
     let app_name = app.name().clone();
     reactor.apps.insert(app_name.clone(), app);
 
diff --git a/hermes/bin/src/runtime_extensions/hermes/cron/queue.rs b/hermes/bin/src/runtime_extensions/hermes/cron/queue.rs
@@ -352,7 +352,7 @@ mod tests {
         let vfs = VfsBootstrapper::new(temp_dir.path(), APP_NAME.to_string())
             .bootstrap()
             .unwrap();
-        let hermes_app = Application::new(APP_NAME.to_string(), vfs, vec![]);
+        let hermes_app = Application::new(ApplicationName::new(APP_NAME), vfs, vec![]);
 
         crate::reactor::init().unwrap();
         crate::reactor::load_app(hermes_app).unwrap();
diff --git a/hermes/bin/src/runtime_extensions/hermes/logging/mod.rs b/hermes/bin/src/runtime_extensions/hermes/logging/mod.rs
@@ -19,7 +19,7 @@ mod log_msg;
 #[derive(Default)]
 struct RteLogging;
 
-#[traitreg::register]
+#[traitreg::register(default)]
 impl RteInitRuntime for RteLogging {
     fn init(self: Box<Self>) -> RteInitResult {
         debug!("Hermes Runtime Extensions Initialized: Node Runtime");
@@ -44,7 +44,7 @@ impl RteInitRuntime for RteLogging {
     }
 }
 
-#[traitreg::register]
+#[traitreg::register(default)]
 impl RteInitApp for RteLogging {
     fn init(
         self: Box<Self>,
@@ -75,7 +75,7 @@ impl RteInitApp for RteLogging {
     }
 }
 
-#[traitreg::register]
+#[traitreg::register(default)]
 impl RteInitModule for RteLogging {
     fn init(
         self: Box<Self>,
@@ -108,7 +108,7 @@ impl RteInitModule for RteLogging {
     }
 }
 
-#[traitreg::register]
+#[traitreg::register(default)]
 impl RteInitEvent for RteLogging {
     fn init(
         self: Box<Self>,
diff --git a/hermes/bin/src/runtime_extensions/init/executor.rs b/hermes/bin/src/runtime_extensions/init/executor.rs
@@ -51,7 +51,7 @@ macro_rules! run_init_fini {
                     file = registered.file(),
                     trait_name = registered.trait_name(),
                     module_path = registered.module_path(),
-                    "Failed to create an instance of the runtime extension for runtime initialization."
+                    "Missing Constructor in the registered runtime extension."
                 );
             }
         }
diff --git a/hermes/bin/src/runtime_extensions/init/trait_app.rs b/hermes/bin/src/runtime_extensions/init/trait_app.rs
@@ -161,3 +161,23 @@ impl RteInitApp for RteApp {
         errors
     }
 }
+
+#[cfg(all(test, debug_assertions))]
+mod tests {
+    use super::RTE_INIT_APP_REGISTRY;
+
+    /// Tests that a new `RuntimeExtensionErrors` is empty
+    #[test]
+    fn test_all_registered_apps_have_constructors() {
+        for registered in RTE_INIT_APP_REGISTRY.iter() {
+            // Check all registered App Initializers have constructors.
+            assert!(registered.instanciate().is_some(), "Missing Constructor in the registered runtime extension [ name:{} - path:{} - file:{} - trait_name:{} - module_path:{} ]",
+                    registered.name(),
+                    registered.path(),
+                    registered.file(),
+                    registered.trait_name(),
+                    registered.module_path(),
+                );
+        }
+    }
+}
diff --git a/hermes/bin/src/runtime_extensions/init/trait_event.rs b/hermes/bin/src/runtime_extensions/init/trait_event.rs
@@ -187,3 +187,23 @@ impl RteInitEvent for RteEvent {
         errors
     }
 }
+
+#[cfg(all(test, debug_assertions))]
+mod tests {
+    use super::RTE_INIT_EVENT_REGISTRY;
+
+    /// Tests that a new `RuntimeExtensionErrors` is empty
+    #[test]
+    fn test_all_registered_apps_have_constructors() {
+        for registered in RTE_INIT_EVENT_REGISTRY.iter() {
+            // Check all registered App Initializers have constructors.
+            assert!(registered.instanciate().is_some(), "Missing Constructor in the registered runtime extension [ name:{} - path:{} - file:{} - trait_name:{} - module_path:{} ]",
+                    registered.name(),
+                    registered.path(),
+                    registered.file(),
+                    registered.trait_name(),
+                    registered.module_path(),
+                );
+        }
+    }
+}
diff --git a/hermes/bin/src/runtime_extensions/init/trait_module.rs b/hermes/bin/src/runtime_extensions/init/trait_module.rs
@@ -178,3 +178,23 @@ impl RteInitModule for RteModule {
         errors
     }
 }
+
+#[cfg(all(test, debug_assertions))]
+mod tests {
+    use super::RTE_INIT_MODULE_REGISTRY;
+
+    /// Tests that a new `RuntimeExtensionErrors` is empty
+    #[test]
+    fn test_all_registered_apps_have_constructors() {
+        for registered in RTE_INIT_MODULE_REGISTRY.iter() {
+            // Check all registered App Initializers have constructors.
+            assert!(registered.instanciate().is_some(), "Missing Constructor in the registered runtime extension [ name:{} - path:{} - file:{} - trait_name:{} - module_path:{} ]",
+                    registered.name(),
+                    registered.path(),
+                    registered.file(),
+                    registered.trait_name(),
+                    registered.module_path(),
+                );
+        }
+    }
+}
diff --git a/hermes/bin/src/runtime_extensions/init/trait_runtime.rs b/hermes/bin/src/runtime_extensions/init/trait_runtime.rs
@@ -196,3 +196,23 @@ impl RteInitRuntime for RteRuntime {
         }
     }
 }
+
+#[cfg(all(test, debug_assertions))]
+mod tests {
+    use super::RTE_INIT_RUNTIME_REGISTRY;
+
+    /// Tests that a new `RuntimeExtensionErrors` is empty
+    #[test]
+    fn test_all_registered_apps_have_constructors() {
+        for registered in RTE_INIT_RUNTIME_REGISTRY.iter() {
+            // Check all registered App Initializers have constructors.
+            assert!(registered.instanciate().is_some(), "Missing Constructor in the registered runtime extension [ name:{} - path:{} - file:{} - trait_name:{} - module_path:{} ]",
+                    registered.name(),
+                    registered.path(),
+                    registered.file(),
+                    registered.trait_name(),
+                    registered.module_path(),
+                );
+        }
+    }
+}
diff --git a/hermes/rust-toolchain.toml b/hermes/rust-toolchain.toml
@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.89"
+channel = "1.88"
 profile = "default"
diff --git a/justfile b/justfile
@@ -205,6 +205,7 @@ run-athena:
     echo ""
 
     # Execute the application with security sandboxing
+    # HERMES_LOG_LEVEL="debug" 
     target/release/hermes run --untrusted hermes/apps/athena/app.happ
 
 # Complete build and run workflow - recommended for most use cases
diff --git a/wasm/examples/c/cardano_age/Earthfile b/wasm/examples/c/cardano_age/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/wasm/c:v3.5.4 AS wasm-c-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/wasm/c:v3.5.14 AS wasm-c-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../../../catalyst-ci/earthly/wasm/c AS wasm-c-ci
 
diff --git a/wasm/examples/c/next_century/Earthfile b/wasm/examples/c/next_century/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/wasm/c:v3.5.4 AS wasm-c-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/wasm/c:v3.5.14 AS wasm-c-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../../../catalyst-ci/earthly/wasm/c AS wasm-c-ci
 
diff --git a/wasm/examples/rust/cardano/Earthfile b/wasm/examples/rust/cardano/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.11 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.14 AS rust-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../../catalyst-ci/earthly/rust AS rust-ci
 
diff --git a/wasm/examples/rust/cardano_age/Earthfile b/wasm/examples/rust/cardano_age/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.11 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.14 AS rust-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../../catalyst-ci/earthly/rust AS rust-ci
 
diff --git a/wasm/examples/rust/next_century/Earthfile b/wasm/examples/rust/next_century/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.11 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.14 AS rust-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../../catalyst-ci/earthly/rust AS rust-ci
 
diff --git a/wasm/integration-test/cardano/Earthfile b/wasm/integration-test/cardano/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.11 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.14 AS rust-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../catalyst-ci/earthly/rust AS rust-ci
 
diff --git a/wasm/integration-test/clocks/Earthfile b/wasm/integration-test/clocks/Earthfile
@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/wasm/c:v3.5.4 AS wasm-c-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/wasm/c:v3.5.14 AS wasm-c-ci
 # Use when debugging cat-ci locally.
 # IMPORT ../../../catalyst-ci/earthly/wasm/c AS wasm-c-ci
 
diff --git a/wasm/integration-test/cron/Earthfile b/wasm/integration-test/cron/Earthfile
diff --git a/wasm/integration-test/crypto/Earthfile b/wasm/integration-test/crypto/Earthfile
diff --git a/wasm/integration-test/golang/Earthfile b/wasm/integration-test/golang/Earthfile
diff --git a/wasm/integration-test/hashing/Earthfile b/wasm/integration-test/hashing/Earthfile
diff --git a/wasm/integration-test/http_reply/Earthfile b/wasm/integration-test/http_reply/Earthfile
diff --git a/wasm/integration-test/ipfs/Earthfile b/wasm/integration-test/ipfs/Earthfile
diff --git a/wasm/integration-test/localtime/Earthfile b/wasm/integration-test/localtime/Earthfile
diff --git a/wasm/integration-test/logger/Earthfile b/wasm/integration-test/logger/Earthfile
diff --git a/wasm/integration-test/smoke-test/Earthfile b/wasm/integration-test/smoke-test/Earthfile
diff --git a/wasm/integration-test/sqlite/Earthfile b/wasm/integration-test/sqlite/Earthfile
diff --git a/wasm/integration-test/wasi-filesystem/Earthfile b/wasm/integration-test/wasi-filesystem/Earthfile
diff --git a/wasm/stub-module/Earthfile b/wasm/stub-module/Earthfile
diff --git a/wasm/wasi/Earthfile b/wasm/wasi/Earthfile

-Original file line number
+Diff line change
 abnf
 addrr
 adminer
 +aido
 apskhem
 asat
 asyncio