Merge #3172

3172: Fix signature of `Control.Monad.Class.MonadSTM.Strict.stateTVar` r=coot a=coot

This PR requires a careful review.  There are various places where
```
stateTVar :: MonadSTM m => StrictTVar m s -> (s -> (s, s)) -> STM m s
```
is used, and thus the change made is not visible in types.

`IOLike` module in consensus exports `Control.Monad.Class.MonadSTM.Strict` so
this inlucdes all the places in consensus which use it.

- io-sim-classes: fix type signature of `Strict.stateTVar`
- Updated call sites of `Strict.stateTVar`


Co-authored-by: Marcin Szamotulski <[email protected]>

Author: iohk-bors[bot]

io-sim-classes/src/Control/Monad/Class/MonadSTM/Strict.hs

@@ -138,10 +138,10 @@ writeTVar StrictTVar { tvar, invariant } !a =
 modifyTVar :: MonadSTM m => StrictTVar m a -> (a -> a) -> STM m ()
 modifyTVar v f = readTVar v >>= writeTVar v . f
 
-stateTVar :: MonadSTM m => StrictTVar m a -> (a -> (a, b)) -> STM m b
+stateTVar :: MonadSTM m => StrictTVar m s -> (s -> (a, s)) -> STM m a
 stateTVar v f = do
     a <- readTVar v
-    let (a', b) = f a
+    let (b, a') = f a
     writeTVar v a'
     return b
 
@@ -152,7 +152,7 @@ swapTVar v a' = do
     return a
 
 
-updateTVar :: MonadSTM m => StrictTVar m a -> (a -> (a, b)) -> STM m b
+updateTVar :: MonadSTM m => StrictTVar m s -> (s -> (a, s)) -> STM m a
 updateTVar = stateTVar
 {-# DEPRECATED updateTVar "Use stateTVar" #-}