Review comments

Author: MaximilianAlgehed

io-sim/src/Control/Monad/IOSimPOR/Internal.hs

@@ -768,8 +768,7 @@ threadInterruptible thread =
 
 deschedule :: Deschedule -> Thread s a -> SimState s a -> ST s (SimTrace a)
 
-deschedule Yield thread@Thread { threadId     = tid
-                               , threadEffect = effect }
+deschedule Yield thread@Thread { threadId = tid }
                  simstate@SimState{runqueue, threads, control} =
 
     -- We don't interrupt runnable threads anywhere else.
@@ -779,7 +778,8 @@ deschedule Yield thread@Thread { threadId     = tid
         runqueue' = insertThread thread' runqueue
         threads'  = Map.insert tid thread' threads
         control'  = advanceControl (threadStepId thread) control in
-    reschedule simstate { runqueue = runqueue', threads  = threads',
+    reschedule simstate { runqueue = runqueue',
+                          threads  = threads',
                           races    = updateRacesInSimState thread simstate,
                           control  = control' }
 

io-sim/src/Control/Monad/IOSimPOR/Types.hs

@@ -74,6 +74,7 @@ racingEffects e e' =
    || effectWrites e       `intersects`  effectReads  e'
    || effectWrites e       `intersects`  effectWrites e'
    || effectStatusReads e  `intersectsL` effectStatusWrites e'
+   || effectStatusWrites e `intersectsL` effectStatusReads  e'
    || effectStatusWrites e `intersectsL` effectStatusWrites e'
   where
     intersects :: Ord a => Set a -> Set a -> Bool