Add tests evm transactions jcli (#3822)

Author: saibatizoku

Cargo.lock

@@ -37,6 +37,9 @@ thiserror = "1.0"
 bytes = "1.1"
 rpassword = "5.0"
 
+[features]
+evm = ["jormungandr-lib/evm"]
+
 [dependencies.clap]
 version = "2.33"
 default-features = false
@@ -50,6 +53,10 @@ features = ["blocking", "rustls-tls", "json"]
 [dev-dependencies]
 assert_fs = "1.0"
 predicates = "2.0"
+quickcheck = "0.9"
+# FIXME required to work with quickcheck 0.9. Remove after migrating another crate or newer quickcheck
+rand07 = { package = "rand", version = "0.7" }
+chain-impl-mockchain = { git = "https://github.com/input-output-hk/chain-libs.git", branch = "master", features = [ "property-test-api" ] }
 
 [build-dependencies]
 versionisator = "1.0.2"

jcli/Cargo.toml

@@ -2,7 +2,7 @@ use crate::jcli_lib::transaction::{common, Error};
 use jormungandr_lib::interfaces::EvmTransaction;
 use structopt::StructOpt;
 
-#[derive(StructOpt)]
+#[derive(StructOpt, Debug)]
 #[structopt(rename_all = "kebab-case")]
 pub struct AddEvmTransaction {
     #[structopt(flatten)]
@@ -19,3 +19,41 @@ impl AddEvmTransaction {
         self.common.store(&transaction)
     }
 }
+
+#[cfg(all(test, feature = "evm"))]
+mod test {
+    use super::*;
+    use chain_impl_mockchain::evm;
+    use quickcheck::Arbitrary;
+
+    impl Arbitrary for AddEvmTransaction {
+        fn arbitrary<G: quickcheck::Gen>(g: &mut G) -> Self {
+            Self {
+                common: common::CommonTransaction { staging_file: None },
+                evm_transaction: EvmTransaction(evm::EvmTransaction::arbitrary(g)),
+            }
+        }
+    }
+
+    impl Clone for AddEvmTransaction {
+        fn clone(&self) -> Self {
+            Self {
+                common: common::CommonTransaction { staging_file: None },
+                evm_transaction: self.evm_transaction.clone(),
+            }
+        }
+    }
+
+    impl PartialEq for AddEvmTransaction {
+        fn eq(&self, other: &AddEvmTransaction) -> bool {
+            self.evm_transaction == other.evm_transaction
+        }
+    }
+
+    quickcheck! {
+        fn evm_transaction_encode(add_evm_tx: AddEvmTransaction) -> bool {
+            let hex_tx = format!("{}", add_evm_tx.evm_transaction);
+            AddEvmTransaction::from_iter(&["", &hex_tx]) == add_evm_tx
+        }
+    }
+}

jcli/src/jcli_lib/transaction/add_evm_transaction.rs

@@ -32,7 +32,7 @@ pub struct CommonFees {
     pub certificate_vote_cast: Option<u64>,
 }
 
-#[derive(StructOpt)]
+#[derive(StructOpt, Debug)]
 #[structopt(rename_all = "kebab-case")]
 pub struct CommonTransaction {
     /// place where the transaction is going to be save during its staging phase

jcli/src/jcli_lib/transaction/common.rs

@@ -1,2 +1,6 @@
+#[cfg(all(test, feature = "evm"))]
+#[macro_use]
+extern crate quickcheck;
+
 pub mod jcli_lib;
 pub use crate::jcli_lib::*;

jcli/src/lib.rs

@@ -6,7 +6,7 @@ use thiserror::Error;
 use typed_bytes::ByteBuilder;
 
 #[derive(Debug, Clone, PartialEq, Eq)]
-pub struct EvmTransaction(evm::EvmTransaction);
+pub struct EvmTransaction(pub evm::EvmTransaction);
 
 #[derive(Debug, Error)]
 pub enum EvmTransactionFromStrError {