Skip to content

Conversation

mkazlauskas
Copy link
Member

@mkazlauskas mkazlauskas commented Aug 11, 2024

a variant of PasswordBox that doesn't have 'value' property
also, 'onChange' callback provides both the password and the input el

This component should eventually replace the original PasswordBox. At that point we'll update the stories.

a variant of PasswordBox that doesn't have 'value' property
also, 'onChange' callback provides both the password and the input el
@mkazlauskas mkazlauskas requested a review from mchappell August 11, 2024 10:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 Great work @mkazlauskas

@mchappell mchappell merged commit 21c44ee into main Aug 11, 2024
2 of 3 checks passed
@mchappell mchappell deleted the feat/uncontrolled-input branch August 11, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants