Move Artifact trait to 'mithril-common'

Author: jpraynaud

mithril-aggregator/src/artifact_builder/artifact_builder_service.rs

@@ -2,13 +2,11 @@ use std::sync::Arc;
 
 use mithril_common::{
     entities::{Certificate, SignedEntityType},
-    signable_builder::DummyBeacon,
+    signable_builder::{Artifact, DummyBeacon},
     StdResult,
 };
 
-use crate::artifact_builder::{Artifact, DummyArtifactBuilder};
-
-use super::ArtifactBuilder;
+use crate::artifact_builder::{ArtifactBuilder, DummyArtifactBuilder};
 
 /// ArtifactBuilder Service
 // TODO: temporary implementation

mithril-aggregator/src/artifact_builder/dummy_artifact.rs

@@ -1,10 +1,14 @@
 use std::marker::PhantomData;
 
 use async_trait::async_trait;
-use mithril_common::{entities::Certificate, signable_builder::DummyBeacon, StdResult};
+use mithril_common::{
+    entities::Certificate,
+    signable_builder::{Artifact, DummyBeacon},
+    StdResult,
+};
 use serde::{Deserialize, Serialize};
 
-use crate::artifact_builder::{Artifact, ArtifactBuilder};
+use crate::artifact_builder::ArtifactBuilder;
 
 /// Dummy artifact
 #[derive(Serialize, Deserialize, PartialEq, Debug)]

mithril-aggregator/src/artifact_builder/interface.rs

@@ -1,10 +1,9 @@
 use async_trait::async_trait;
-use mithril_common::{entities::Certificate, signable_builder::Beacon, StdResult};
-use serde::{Deserialize, Serialize};
-use std::fmt::Debug;
-
-/// Artifact is a trait for types that represent signed artifacts
-pub trait Artifact<'a>: Serialize + Deserialize<'a> + PartialEq + Debug {}
+use mithril_common::{
+    entities::Certificate,
+    signable_builder::{Artifact, Beacon},
+    StdResult,
+};
 
 /// ArtifactBuilder is trait for building an artifact
 #[async_trait]

mithril-common/src/signable_builder/interface.rs

@@ -1,4 +1,6 @@
 use async_trait::async_trait;
+use serde::{Deserialize, Serialize};
+use std::fmt::Debug;
 
 use crate::{entities::ProtocolMessage, StdResult};
 
@@ -11,6 +13,9 @@ pub trait Signable: Send + Sync {
     fn compute_protocol_message(&self) -> StdResult<ProtocolMessage>;
 }
 
+/// Artifact is a trait for types that represent signed artifacts
+pub trait Artifact<'a>: Serialize + Deserialize<'a> + PartialEq + Debug {}
+
 /// SignableBuilder is trait for building a signable for a beacon
 #[async_trait]
 pub trait SignableBuilder<U, V>