Cleanup certificate creator and working certificate

Author: jpraynaud

mithril-aggregator/src/certificate_creator.rs

@@ -19,7 +19,6 @@ use slog_scope::{debug, error, info, warn};
 use thiserror::Error;
 use tokio::sync::RwLock;
 
-use crate::certificate_creator::CertificateCreationError;
 use crate::database::provider::{
     CertificateRepository, OpenMessage, OpenMessageRepository, OpenMessageWithSingleSignatures,
     SingleSignatureRepository,
@@ -54,6 +53,10 @@ pub enum CertifierServiceError {
         "No parent certificate could be found, this certifier cannot create genesis certificates."
     )]
     NoParentCertificateFound,
+
+    /// Codec error.
+    #[error("codec error: '{0}'")]
+    Codec(String),
 }
 
 /// ## CertifierService
@@ -287,7 +290,7 @@ impl CertifierService for MithrilCertifierService {
             sealed_at,
             signers,
         );
-        let multi_signature = key_encode_hex(signature).map_err(CertificateCreationError::Codec)?;
+        let multi_signature = key_encode_hex(signature).map_err(CertifierServiceError::Codec)?;
         let parent_certificate_hash = self
             .certificate_repository
             .get_master_certificate_for_epoch(open_message.epoch)

mithril-aggregator/src/certifier_service.rs

@@ -12,7 +12,6 @@
 //! You can find more information on how it works reading the [documentation website](https://mithril.network/doc/mithril/mithril-network/aggregator).
 
 mod artifact_builder;
-mod certificate_creator;
 pub mod certifier_service;
 mod command_args;
 mod configuration;
@@ -39,7 +38,6 @@ pub use crate::configuration::{
 };
 pub use crate::multi_signer::{MultiSigner, MultiSignerImpl, ProtocolError};
 pub use crate::snapshot_stores::{LocalSnapshotStore, SnapshotStore};
-pub use certificate_creator::{CertificateCreator, MithrilCertificateCreator};
 pub use command_args::MainOpts;
 pub use dependency::DependencyManager;
 pub use message_adapters::{

mithril-aggregator/src/lib.rs

@@ -57,24 +57,18 @@ impl From<Box<dyn StdError + Sync + Send>> for RuntimeError {
 /// Errors returned when the runner cannot fulfil its missions with no subsystem
 /// to fail.
 #[derive(Debug, Error)]
+// TODO: Are these errors still relevant, do we need to remove them?
+#[allow(clippy::enum_variant_names)]
 pub enum RunnerError {
     /// Protocol message part is missing
     #[error("Missing protocol message: '{0}'.")]
     MissingProtocolMessage(String),
 
-    /// Epoch out of bounds
-    #[error("Epoch out of bounds: '{0}'.")]
-    EpochOutOfBounds(String),
-
     /// No stack distribution found
     #[error("Missing stack distribution: '{0}'.")]
     MissingStakeDistribution(String),
 
     /// Missing protocol parameters
     #[error("Missing protocol parameters: '{0}'.")]
     MissingProtocolParameters(String),
-
-    /// No AVK issued by the multisigner
-    #[error("No MultiSignature issued: '{0}'.")]
-    NoComputedMultiSignature(String),
 }

mithril-aggregator/src/runtime/error.rs

@@ -1,9 +1,7 @@
 mod error;
 mod runner;
 mod state_machine;
-mod working_certificate;
 
 pub use error::RuntimeError;
 pub use runner::{AggregatorConfig, AggregatorRunner, AggregatorRunnerTrait};
 pub use state_machine::*;
-pub use working_certificate::WorkingCertificate;