Skip to content

Commit 062a315

Browse files
committed
Customize error message to help investigation on a time depend test
1 parent 388ce53 commit 062a315

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed

mithril-client-cli/src/utils/progress_reporter.rs

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,13 @@ mod tests {
235235

236236
#[test]
237237
fn check_seconds_left_and_elapsed_time_are_used_by_the_formatter() {
238+
let expected_milliseconds_left: u128 = 450;
239+
let expected_milliseconds_elapsed: u128 = 150;
240+
238241
// 4 steps
239242
let progress_bar = ProgressBar::new(4);
240243
// 1 step done in 150 ms, left 450ms to finish the 4th steps
241-
sleep(Duration::from_millis(150));
244+
sleep(Duration::from_millis(expected_milliseconds_elapsed as u64));
242245
progress_bar.set_position(1);
243246

244247
let json_string = ProgressBarJsonFormatter::format(&progress_bar);
@@ -250,14 +253,26 @@ mod tests {
250253
// We need to have a difference not more than 49ms to keep the same 1 first milliseconds digits.
251254
let delta = 49;
252255

253-
assert!(((450 - delta)..=(450 + delta)).contains(&milliseconds_left));
256+
assert!(
257+
((expected_milliseconds_left - delta)..=(expected_milliseconds_left + delta))
258+
.contains(&milliseconds_left),
259+
"milliseconds_left should be close to {} but it's {}",
260+
&expected_milliseconds_left,
261+
&milliseconds_left
262+
);
254263
assert!(
255264
json_string.contains(r#""seconds_left": 0.4"#), // Should be close to 0.450
256265
"Not expected value in json output: {}",
257266
json_string
258267
);
259268

260-
assert!(((150 - delta)..(150 + delta)).contains(&milliseconds_elapsed));
269+
assert!(
270+
((expected_milliseconds_elapsed - delta)..=(expected_milliseconds_elapsed + delta))
271+
.contains(&milliseconds_elapsed),
272+
"milliseconds_elapsed should be close to {} but it's {}",
273+
&expected_milliseconds_elapsed,
274+
&milliseconds_elapsed
275+
);
261276
assert!(
262277
json_string.contains(r#""seconds_elapsed": 0.1"#), // Should be close to 0.150
263278
"Not expected value in json output: {}",

0 commit comments

Comments
 (0)