Fixed clippy warnings from Rust 1.66.0

Author: jpraynaud

mithril-aggregator/src/certificate_creator.rs

@@ -51,7 +51,7 @@ impl CertificateCreator for MithrilCertificateCreator {
             signers,
         );
         let multi_signature =
-            key_encode_hex(&multi_signature).map_err(CertificateCreationError::Codec)?;
+            key_encode_hex(multi_signature).map_err(CertificateCreationError::Codec)?;
         let genesis_signature = "".to_string();
 
         Ok(entities::Certificate::new(

mithril-aggregator/src/multi_signer.rs

@@ -564,7 +564,7 @@ impl MultiSigner for MultiSignerImpl {
                         signer.verification_key_signature.to_owned(),
                         signer.operational_certificate.to_owned(),
                         signer.kes_period.to_owned(),
-                        *stake as u64,
+                        *stake,
                     )
                 })
             })
@@ -598,7 +598,7 @@ impl MultiSigner for MultiSignerImpl {
                         signer.verification_key_signature.to_owned(),
                         signer.operational_certificate.to_owned(),
                         signer.kes_period.to_owned(),
-                        *stake as u64,
+                        *stake,
                     )
                 })
             })
@@ -851,7 +851,7 @@ mod tests {
 
         offset_epoch(
             &mut multi_signer,
-            (SIGNER_EPOCH_RECORDING_OFFSET - SIGNER_EPOCH_RETRIEVAL_OFFSET) as i64,
+            SIGNER_EPOCH_RECORDING_OFFSET - SIGNER_EPOCH_RETRIEVAL_OFFSET,
         )
         .await;
 
@@ -887,7 +887,7 @@ mod tests {
 
         offset_epoch(
             &mut multi_signer,
-            (SIGNER_EPOCH_RECORDING_OFFSET - SIGNER_EPOCH_RETRIEVAL_OFFSET) as i64,
+            SIGNER_EPOCH_RECORDING_OFFSET - SIGNER_EPOCH_RETRIEVAL_OFFSET,
         )
         .await;
 
@@ -952,7 +952,7 @@ mod tests {
 
         offset_epoch(
             &mut multi_signer,
-            (SIGNER_EPOCH_RECORDING_OFFSET - SIGNER_EPOCH_RETRIEVAL_OFFSET) as i64,
+            SIGNER_EPOCH_RECORDING_OFFSET - SIGNER_EPOCH_RETRIEVAL_OFFSET,
         )
         .await;
         // We have to update the current message AFTER we reached the epoch for

mithril-aggregator/src/runtime/runner.rs

@@ -549,8 +549,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
             .get_single_signatures(&working_certificate.beacon)
             .await?
             .unwrap_or_default()
-            .into_iter()
-            .map(|(party_id, _single_signature)| party_id)
+            .into_keys()
             .collect::<Vec<_>>();
         let multi_signature = multisigner.get_multi_signature().await?.ok_or_else(|| {
             RuntimeError::General("no multi signature generated".to_string().into())

mithril-client/src/aggregator.rs

@@ -443,7 +443,7 @@ mod tests {
         let location = server.url(url_path);
         let local_file_path = aggregator_client.download_snapshot(digest, &location).await;
         local_file_path.as_ref().expect("unexpected error");
-        let data_downloaded = fs::read_to_string(&local_file_path.unwrap()).unwrap();
+        let data_downloaded = fs::read_to_string(local_file_path.unwrap()).unwrap();
 
         assert_eq!(data_downloaded, data_expected);
     }

mithril-common/src/crypto_helper/cardano/codec.rs

@@ -67,7 +67,7 @@ pub trait SerDeShelleyFileFormat: Serialize + DeserializeOwned {
 
     /// Serialize a Cardano Key to file
     fn to_file<P: AsRef<Path>>(&self, path: P) -> Result<(), ParseError> {
-        let cbor_string = hex::encode(&serde_cbor::to_vec(&self)?);
+        let cbor_string = hex::encode(serde_cbor::to_vec(&self)?);
 
         let file_format = ShelleyFileFormat {
             file_type: Self::TYPE.to_string(),

mithril-common/src/crypto_helper/tests_setup.rs

@@ -296,7 +296,7 @@ pub fn setup_certificate_chain(
                             fake_certificate.signed_message.as_bytes(),
                         )
                         .unwrap();
-                    fake_certificate.multi_signature = key_encode_hex(&multi_signature).unwrap();
+                    fake_certificate.multi_signature = key_encode_hex(multi_signature).unwrap();
                     fake_certificate.genesis_signature = "".to_string()
                 }
             }

mithril-common/src/digesters/immutable_file.rs

@@ -138,7 +138,7 @@ mod tests {
     fn create_fake_files(parent_dir: &Path, child_filenames: &[&str]) {
         for filename in child_filenames {
             let file = parent_dir.join(Path::new(filename));
-            let mut source_file = File::create(&file).unwrap();
+            let mut source_file = File::create(file).unwrap();
             write!(source_file, "This is a test file named '{}'", filename).unwrap();
         }
     }

mithril-stm/benches/size_benches.rs

@@ -57,7 +57,7 @@ where
         k,
         m,
         nparties,
-        aggr.to_bytes().len() as usize,
+        aggr.to_bytes().len(),
     );
 }
 

mithril-stm/src/stm.rs

@@ -903,7 +903,7 @@ mod tests {
                     .map(|(a, stake)| (*a, (stake * adversary_stake) / adversary_sum))
                     .collect();
 
-                let adversaries = adversaries.into_iter().map(|(key, _)| key).collect();
+                let adversaries = adversaries.into_keys().collect();
                 (
                     Just(adversaries),
                     arb_honest_for_adversaries(