Move Cardano chain adpater to submodule

Author: jpraynaud

mithril-common/src/era/cardano_chain_adapter.rs renamed to mithril-common/src/era/adapters/cardano_chain.rs

@@ -4,7 +4,7 @@ use crate::{
         key_decode_hex, EraMarkersSigner, EraMarkersVerifier, EraMarkersVerifierSignature,
         EraMarkersVerifierVerificationKey,
     },
-    entities::Epoch,
+    era::{EraMarker, EraReaderAdapter},
 };
 use async_trait::async_trait;
 use hex::{FromHex, ToHex};
@@ -15,35 +15,6 @@ use thiserror::Error;
 
 type GeneralError = Box<dyn StdError + Sync + Send>;
 
-// TODO: remove EraMarker & EraReaderAdapter w/ they are available
-
-/// Value object that represents a tag of Era change.
-#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
-pub struct EraMarker {
-    /// Era name
-    pub name: String,
-
-    /// Eventual information that advertises the Epoch of transition.
-    pub epoch: Option<Epoch>,
-}
-
-impl EraMarker {
-    /// instanciate a new [EraMarker].
-    pub fn new(name: &str, epoch: Option<Epoch>) -> Self {
-        let name = name.to_string();
-
-        Self { name, epoch }
-    }
-}
-
-#[async_trait]
-pub trait EraReaderAdapter: Sync + Send {
-    /// Read era markers from the underlying adapter.
-    async fn read(&self) -> Result<Vec<EraMarker>, GeneralError>;
-}
-
-// TODO: Keep Cardano Chain Adapter part below
-
 type HexEncodeEraMarkerSignature = String;
 
 /// [EraMarkersPayload] related errors.
@@ -158,6 +129,7 @@ impl EraReaderAdapter for CardanoChainAdapter {
 mod test {
     use crate::chain_observer::{FakeObserver, TxDatum};
     use crate::crypto_helper::{key_encode_hex, EraMarkersSigner};
+    use crate::entities::Epoch;
 
     use super::*;
 

mithril-common/src/era/adapters/mod.rs

@@ -1,6 +1,8 @@
 //! Module dedicated to EraReaderAdapter implementations.
 mod bootstrap;
+mod cardano_chain;
 mod dummy;
 
 pub use bootstrap::BootstrapAdapter as EraReaderBootstrapAdapter;
+pub use cardano_chain::CardanoChainAdapter;
 pub use dummy::DummyAdapter as EraReaderDummyAdapter;

mithril-common/src/era/era_reader.rs

@@ -1,13 +1,13 @@
-use std::{error::Error as StdError, str::FromStr};
-
 use crate::entities::Epoch;
 use async_trait::async_trait;
+use serde::{Deserialize, Serialize};
+use std::{error::Error as StdError, str::FromStr};
 use thiserror::Error;
 
 use super::{supported_era::UnsupportedEraError, SupportedEra};
 
 /// Value object that represents a tag of Era change.
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 pub struct EraMarker {
     /// Era name
     pub name: String,

mithril-common/src/era/mod.rs

@@ -1,7 +1,6 @@
 //! The module used for handling eras
 
 pub mod adapters;
-mod cardano_chain_adapter;
 mod era_checker;
 mod era_reader;
 mod supported_era;