fix: support new stake address creation of registration certificate in infra

Author: jpraynaud

mithril-infra/assets/tools/pool/create-keys.sh

@@ -62,9 +62,20 @@ CARDANO_CLI_CMD node issue-op-cert \
 --out-file ${POOL_ARTIFACTS_DIR}/opcert.cert
 
 ### Create a registration certificate
-CARDANO_CLI_CMD stake-address registration-certificate \
---stake-verification-key-file ${POOL_ARTIFACTS_DIR}/stake.vkey \
---out-file ${POOL_ARTIFACTS_DIR}/stake.cert
+if [ "${CARDANO_ERA}" == "conway"]; then
+    KEY_REGISTRATION_DEPOSIT_ANOUNT=$(CARDANO_CLI_CMD ${CARDANO_ERA} query gov-state --testnet-magic ${NETWORK_MAGIC} | jq -r .enactState.curPParams.keyDeposit)
+    # Conway specific creation of registration certificate
+    CARDANO_CLI_CMD stake-address registration-certificate \
+    --stake-verification-key-file ${POOL_ARTIFACTS_DIR}/stake.vkey \
+    --out-file ${POOL_ARTIFACTS_DIR}/stake.cert \
+    --key-reg-deposit-amt $KEY_REGISTRATION_DEPOSIT_ANOUNT
+else
+    # Legacy creation of registration certificate
+    CARDANO_CLI_CMD stake-address registration-certificate \
+    --stake-verification-key-file ${POOL_ARTIFACTS_DIR}/stake.vkey \
+    --out-file ${POOL_ARTIFACTS_DIR}/stake.cert
+fi
+
 
 ### Compute Pool Id
 POOL_ID=$(CARDANO_CLI_CMD stake-pool id --cold-verification-key-file ${POOL_ARTIFACTS_DIR}/cold.vkey)

mithril-test-lab/mithril-devnet/mkfiles/mkfiles-cardano.sh

@@ -4,6 +4,17 @@ mkdir -p ${ARTIFACTS_DIR_TEMP}
 # Step 1: Bootstrap the devnet artifacts
 # Adapted from https://github.com/IntersectMBO/cardano-node/blob/master/scripts/babbage/mkfiles.sh
 
+# Is semver on the first argument strictly lower than equal to the second argument?
+version_lt() {
+  VERSION_LHS=$1
+  VERSION_RHS=$2
+  if [ "${VERSION_LHS}" != "${VERSION_RHS}" ] && [ "${VERSION_LHS}" = "`echo -e "${VERSION_LHS}\n${VERSION_RHS}" | sort -V | head -n1`" ]; then
+    echo "true"
+  else
+    echo "false"
+  fi
+}
+
 UNAME=$(uname -s) SED=
 case $UNAME in
   Darwin )      SED="gsed";;
@@ -77,8 +88,8 @@ if [ "${CARDANO_NODE_VERSION_RELEASE}" = "8.1.2" ]; then
   mv ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json.tmp && cat ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json.tmp | jq '. += {"genDelegs":{}}' > ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json && rm ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json.tmp
 fi
 
-if [ "${CARDANO_NODE_VERSION_RELEASE}" = "8.8.0" ]; then
-  # Fix 8.8.0, to avoid the following errors: 'Command failed: genesis create-staked  Error: Error: Error while decoding Shelley genesis at: ./temp/genesis.conway.spec.json Error: Error in $.poolVotingThresholds: key "motionNoConfidence" not found
+if [ $(version_lt "${CARDANO_NODE_VERSION_RELEASE}" "8.8.0") = "false" ]; then
+  # Fix >=8.8.0, to avoid the following errors: 'Command failed: genesis create-staked  Error: Error: Error while decoding Shelley genesis at: ./temp/genesis.conway.spec.json Error: Error in $.poolVotingThresholds: key "motionNoConfidence" not found
   mv ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json.tmp && cat ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json.tmp | jq '. += {"poolVotingThresholds": {"motionNoConfidence": 0.51, "committeeNormal": 0.51, "committeeNoConfidence": 0.51, "hardForkInitiation": 0.51, "ppSecurityGroup": 0.51}, "dRepVotingThresholds": {"motionNoConfidence": 0.51, "committeeNormal": 0.51, "committeeNoConfidence": 0.51, "updateToConstitution": 0.51, "hardForkInitiation": 0.51, "ppNetworkGroup": 0.51, "ppEconomicGroup": 0.51, "ppTechnicalGroup": 0.51, "ppGovGroup": 0.51, "treasuryWithdrawal": 0.51}}' > ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json && rm ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json.tmp
   cat ${ARTIFACTS_DIR_TEMP}/genesis.conway.spec.json
 fi

mithril-test-lab/mithril-devnet/mkfiles/mkfiles-mithril-delegation.sh

@@ -21,11 +21,23 @@ CURRENT_EPOCH=\$(CARDANO_NODE_SOCKET_PATH=node-pool${N}/ipc/node.sock ./cardano-
                     --testnet-magic ${NETWORK_MAGIC} | jq .epoch)
 echo ">>>> Current Epoch: \${CURRENT_EPOCH}"
 
+# Is semver on the first argument strictly lower than equal to the second argument?
+version_lt() {
+  VERSION_LHS=\$1
+  VERSION_RHS=\$2
+  if [ "\${VERSION_LHS}" != "\${VERSION_RHS}" ] && [ "\${VERSION_LHS}" = "`echo -e "\${VERSION_LHS}\n\${VERSION_RHS}" | sort -V | head -n1`" ]; then
+    echo "true"
+  else
+    echo "false"
+  fi
+}
+
 # Stake addresses registration certs
 for ADDR in ${USER_ADDRS}; do
-  if [ "\${CURRENT_CARDANO_ERA}" == "conway" ]; then
-    KEY_REGISTRATION_DEPOSIT_ANOUNT=\$(CARDANO_NODE_SOCKET_PATH=node-pool${N}/ipc/node.sock ./cardano-cli \${CURRENT_CARDANO_ERA} query gov-state --testnet-magic ${NETWORK_MAGIC} | jq -r .enactState.curPParams.keyDeposit)
-    if [ "\${KEY_REGISTRATION_DEPOSIT_ANOUNT}" != "null" ]; then
+  if [ \$(version_lt "${CARDANO_NODE_VERSION_RELEASE}" "8.8.0") = "false" ]; then
+    #KEY_REGISTRATION_DEPOSIT_ANOUNT=\$(CARDANO_NODE_SOCKET_PATH=node-pool${N}/ipc/node.sock ./cardano-cli \${CURRENT_CARDANO_ERA} query gov-state --testnet-magic ${NETWORK_MAGIC} | jq -r .enactState.curPParams.keyDeposit)
+    KEY_REGISTRATION_DEPOSIT_ANOUNT=0
+    if [ "\${CURRENT_CARDANO_ERA}" == "conway" ]; then
       # Conway specific creation of registration certificate
       ./cardano-cli \${CURRENT_CARDANO_ERA} stake-address registration-certificate \
       --stake-verification-key-file addresses/\${ADDR}-stake.vkey \
@@ -50,7 +62,7 @@ EOF
 # User N will delegate to pool N
 for N in ${POOL_NODES_N}; do
   cat >> delegate.sh <<EOF
-    if [ "\${CURRENT_CARDANO_ERA}" == "conway" ]; then
+    if [ \$(version_lt "${CARDANO_NODE_VERSION_RELEASE}" "8.8.0") = "false" ]; then
       # Stake address delegation certs
       ./cardano-cli \${CURRENT_CARDANO_ERA} stake-address stake-delegation-certificate \
           --stake-verification-key-file addresses/user${N}-stake.vkey \