Fix warnings with Rust '1.73.0'

Author: jpraynaud

mithril-aggregator/src/runtime/state_machine.rs

@@ -75,14 +75,14 @@ impl AggregatorRuntime {
     ) -> Result<Self, RuntimeError> {
         info!("initializing runtime");
 
-        let state = if init_state.is_none() {
+        let state = if let Some(init_state) = init_state {
+            trace!("got initial state from caller");
+            init_state
+        } else {
             trace!("idle state, no current beacon");
             AggregatorState::Idle(IdleState {
                 current_beacon: None,
             })
-        } else {
-            trace!("got initial state from caller");
-            init_state.unwrap()
         };
 
         Ok::<Self, RuntimeError>(Self {

mithril-client/src/aggregator_client/certificate_client.rs

@@ -32,7 +32,7 @@ impl CertificateClient {
         let response = self.http_client.get_content(&url).await;
 
         match response {
-            Err(e) if matches!(e, AggregatorHTTPClientError::RemoteServerLogical(_)) => Ok(None),
+            Err(AggregatorHTTPClientError::RemoteServerLogical(_)) => Ok(None),
             Err(e) => Err(e.into()),
             Ok(response) => {
                 let message =

mithril-client/src/aggregator_client/mithril_stake_distribution_client.rs

@@ -50,7 +50,7 @@ impl MithrilStakeDistributionClient {
 
                 Ok(Some(stake_distribution_entity))
             }
-            Err(e) if matches!(e, AggregatorHTTPClientError::RemoteServerLogical(_)) => Ok(None),
+            Err(AggregatorHTTPClientError::RemoteServerLogical(_)) => Ok(None),
             Err(e) => Err(e.into()),
         }
     }

mithril-client/src/services/snapshot.rs

@@ -194,9 +194,7 @@ impl SnapshotService for MithrilClientSnapshotService {
             .show(&self.expand_eventual_snapshot_alias(digest).await?)
             .await
             .map_err(|e| match &e.downcast_ref::<AggregatorHTTPClientError>() {
-                Some(error)
-                    if matches!(error, &&AggregatorHTTPClientError::RemoteServerLogical(_)) =>
-                {
+                Some(AggregatorHTTPClientError::RemoteServerLogical(_)) => {
                     SnapshotServiceError::SnapshotNotFound(digest.to_owned()).into()
                 }
                 _ => e,

mithril-common/src/database/version_checker.rs

@@ -154,7 +154,7 @@ impl SqlMigration {
 
 impl PartialOrd for SqlMigration {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        self.version.partial_cmp(&other.version)
+        Some(self.version.cmp(&other.version))
     }
 }
 

mithril-common/src/entities/certificate.rs

@@ -130,7 +130,7 @@ impl PartialOrd for Certificate {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
         // Order by beacon first then per hash
         match self.beacon.partial_cmp(&other.beacon) {
-            Some(ordering) if ordering == Ordering::Equal => self.hash.partial_cmp(&other.hash),
+            Some(Ordering::Equal) => self.hash.partial_cmp(&other.hash),
             Some(other) => Some(other),
             // Beacons may be not comparable (most likely because the network isn't the same) in
             // that case we can still order per hash

mithril-common/src/entities/signer.rs

@@ -152,7 +152,7 @@ impl PartialEq for SignerWithStake {
 
 impl PartialOrd for SignerWithStake {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.party_id.partial_cmp(&other.party_id)
+        Some(self.party_id.cmp(&other.party_id))
     }
 }