Fix backward compatibility for Snapshot as Signed Entity

Author: jpraynaud

Cargo.lock

@@ -1,6 +1,5 @@
 use async_trait::async_trait;
 use chrono::Utc;
-use uuid::Uuid;
 
 use std::sync::Arc;
 
@@ -94,7 +93,7 @@ impl ArtifactBuilderService for MithrilArtifactBuilderService {
         artifact: Arc<dyn Artifact>,
     ) -> StdResult<()> {
         let signed_entity = SignedEntityRecord {
-            signed_entity_id: Uuid::new_v4().to_string(),
+            signed_entity_id: artifact.get_id(),
             signed_entity_type,
             certificate_id: certificate.hash.clone(),
             entity: serde_json::to_string(&artifact)?,

mithril-aggregator/src/artifact_builder/artifact_builder_service.rs

@@ -50,6 +50,7 @@ strum_macros = "0.24.1"
 thiserror = "1.0.31"
 tokio = { version = "1.17.0", features = ["full"] }
 typetag = "0.2.8"
+uuid = { version = "1.3.0", features = ["v4", "fast-rng", "macro-diagnostics"] }
 walkdir = "2"
 warp = "0.3"
 

mithril-common/Cargo.toml

@@ -45,4 +45,8 @@ impl Snapshot {
 }
 
 #[typetag::serde]
-impl Artifact for Snapshot {}
+impl Artifact for Snapshot {
+    fn get_id(&self) -> String {
+        self.digest.clone()
+    }
+}

mithril-common/src/entities/snapshot.rs

@@ -1,5 +1,6 @@
 use async_trait::async_trait;
 use std::fmt::Debug;
+use uuid::Uuid;
 
 use crate::{entities::ProtocolMessage, StdResult};
 
@@ -11,7 +12,12 @@ pub trait Beacon: Send + Sync {}
 
 /// Artifact is a trait for types that represent signed artifacts
 #[typetag::serde(tag = "type")]
-pub trait Artifact: Debug + Send + Sync {}
+pub trait Artifact: Debug + Send + Sync {
+    /// Get artifact identifier
+    fn get_id(&self) -> String {
+        Uuid::new_v4().to_string()
+    }
+}
 
 /// SignableBuilder is trait for building a protocol message for a beacon
 #[cfg_attr(test, automock)]