Cleanup legacy SingleSignatureStore in aggregator

Which was creating unwanted 'single_signature_legacy' table.

Author: jpraynaud

mithril-aggregator/src/dependency.rs

@@ -20,8 +20,7 @@ use crate::{
     configuration::*, database::provider::StakePoolStore, signable_builder::SignableBuilderService,
     signer_registerer::SignerRecorder, ticker_service::TickerService, CertificatePendingStore,
     CertificateStore, ProtocolParametersStore, ProtocolParametersStorer, SignerRegisterer,
-    SignerRegistrationRoundOpener, SingleSignatureStore, Snapshotter, VerificationKeyStore,
-    VerificationKeyStorer,
+    SignerRegistrationRoundOpener, Snapshotter, VerificationKeyStore, VerificationKeyStorer,
 };
 use crate::{event_store::EventMessage, snapshot_stores::SnapshotStore};
 use crate::{event_store::TransmitterService, multi_signer::MultiSigner};
@@ -64,9 +63,6 @@ pub struct DependencyManager {
     /// Verification key store.
     pub verification_key_store: Arc<VerificationKeyStore>,
 
-    /// Signer single signature store.
-    pub single_signature_store: Arc<SingleSignatureStore>,
-
     /// Protocol parameter store.
     pub protocol_parameters_store: Arc<ProtocolParametersStore>,
 

mithril-aggregator/src/dependency_injection/builder.rs

@@ -1,4 +1,4 @@
-use std::{collections::HashMap, sync::Arc};
+use std::sync::Arc;
 
 use mithril_common::{
     api_version::APIVersionProvider,
@@ -11,7 +11,7 @@ use mithril_common::{
         CardanoImmutableDigester, DumbImmutableFileObserver, ImmutableDigester,
         ImmutableFileObserver, ImmutableFileSystemObserver,
     },
-    entities::{Beacon, CertificatePending, Epoch, PartyId, SingleSignatures},
+    entities::{CertificatePending, Epoch},
     era::{
         adapters::{EraReaderAdapterBuilder, EraReaderDummyAdapter},
         EraChecker, EraMarker, EraReader, EraReaderAdapter, SupportedEra,
@@ -52,8 +52,8 @@ use crate::{
     CertificateStore, Configuration, DependencyManager, DumbSnapshotUploader, DumbSnapshotter,
     GzipSnapshotter, LocalSnapshotStore, LocalSnapshotUploader, MithrilSignerRegisterer,
     MultiSigner, MultiSignerImpl, ProtocolParametersStore, ProtocolParametersStorer,
-    RemoteSnapshotUploader, SingleSignatureStore, SnapshotStore, SnapshotUploader,
-    SnapshotUploaderType, Snapshotter, VerificationKeyStore,
+    RemoteSnapshotUploader, SnapshotStore, SnapshotUploader, SnapshotUploaderType, Snapshotter,
+    VerificationKeyStore,
 };
 
 use super::{DependenciesBuilderError, Result};
@@ -100,9 +100,6 @@ pub struct DependenciesBuilder {
     /// Verification key store.
     pub verification_key_store: Option<Arc<VerificationKeyStore>>,
 
-    /// Signer single signature store.
-    pub single_signature_store: Option<Arc<SingleSignatureStore>>,
-
     /// Protocol parameter store.
     pub protocol_parameters_store: Option<Arc<ProtocolParametersStore>>,
 
@@ -192,7 +189,6 @@ impl DependenciesBuilder {
             certificate_pending_store: None,
             certificate_store: None,
             verification_key_store: None,
-            single_signature_store: None,
             protocol_parameters_store: None,
             cardano_cli_runner: None,
             chain_observer: None,
@@ -434,49 +430,6 @@ impl DependenciesBuilder {
         Ok(self.verification_key_store.as_ref().cloned().unwrap())
     }
 
-    async fn build_single_signature_store(&mut self) -> Result<Arc<SingleSignatureStore>> {
-        let adapter: Box<
-            dyn StoreAdapter<Key = Beacon, Record = HashMap<PartyId, SingleSignatures>>,
-        > = match self.configuration.environment {
-            ExecutionEnvironment::Production => {
-                let adapter = SQLiteAdapter::new(
-                    "single_signature_legacy",
-                    self.get_sqlite_connection().await?,
-                )
-                .map_err(|e| DependenciesBuilderError::Initialization {
-                    message: "Cannot create SQLite adapter for SingleSignatureStore.".to_string(),
-                    error: Some(e.into()),
-                })?;
-
-                Box::new(adapter)
-            }
-            _ => {
-                let adapter = MemoryAdapter::new(None).map_err(|e| {
-                    DependenciesBuilderError::Initialization {
-                        message: "Cannot create Memory adapter for SingleSignatureStore."
-                            .to_string(),
-                        error: Some(e.into()),
-                    }
-                })?;
-                Box::new(adapter)
-            }
-        };
-
-        Ok(Arc::new(SingleSignatureStore::new(
-            adapter,
-            self.configuration.store_retention_limit,
-        )))
-    }
-
-    /// Get a configured [SingleSignatureStore].
-    pub async fn get_single_signature_store(&mut self) -> Result<Arc<SingleSignatureStore>> {
-        if self.single_signature_store.is_none() {
-            self.single_signature_store = Some(self.build_single_signature_store().await?);
-        }
-
-        Ok(self.single_signature_store.as_ref().cloned().unwrap())
-    }
-
     async fn build_protocol_parameters_store(&mut self) -> Result<Arc<ProtocolParametersStore>> {
         Ok(Arc::new(ProtocolParametersStore::new(
             Box::new(EpochSettingStore::new(self.get_sqlite_connection().await?)),
@@ -965,7 +918,6 @@ impl DependenciesBuilder {
             certificate_pending_store: self.get_certificate_pending_store().await?,
             certificate_store: self.get_certificate_store().await?,
             verification_key_store: self.get_verification_key_store().await?,
-            single_signature_store: self.get_single_signature_store().await?,
             protocol_parameters_store: self.get_protocol_parameters_store().await?,
             chain_observer: self.get_chain_observer().await?,
             beacon_provider: self.get_beacon_provider().await?,

mithril-aggregator/src/lib.rs

@@ -57,7 +57,7 @@ pub use snapshot_uploaders::{
 pub use snapshotter::{DumbSnapshotter, GzipSnapshotter, SnapshotError, Snapshotter};
 pub use store::{
     CertificatePendingStore, CertificateStore, ProtocolParametersStore, ProtocolParametersStorer,
-    SingleSignatureStore, VerificationKeyStore, VerificationKeyStorer,
+    VerificationKeyStore, VerificationKeyStorer,
 };
 
 #[cfg(test)]

mithril-aggregator/src/store/mod.rs

@@ -1,11 +1,9 @@
 mod certificate_store;
 mod pending_certificate_store;
 mod protocol_parameters_store;
-mod single_signature_store;
 mod verification_key_store;
 
 pub use certificate_store::CertificateStore;
 pub use pending_certificate_store::CertificatePendingStore;
 pub use protocol_parameters_store::{ProtocolParametersStore, ProtocolParametersStorer};
-pub use single_signature_store::{SingleSignatureStore, SingleSignatureStorer};
 pub use verification_key_store::{VerificationKeyStore, VerificationKeyStorer};