Merge pull request #2148 from input-output-hk/djo/2147/rust_1.83

Fix Rust 1.83 clippy warnings

Author: Alenar

CHANGELOG.md

@@ -22,6 +22,8 @@ As a minor extension, we have adopted a slightly different versioning convention
 
 - Add a one line shell installation script for the Mithril nodes.
 
+- Update to Rust `1.83`.
+
 - **UNSTABLE** Cardano database incremental certification:
 
   - Implement the new signed entity type `CardanoDatabase`.

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-metric"
-version = "0.1.2"
+version = "0.1.3"
 description = "Common tools to expose metrics."
 authors = { workspace = true }
 edition = { workspace = true }

internal/mithril-metric/Cargo.toml

@@ -88,12 +88,13 @@ macro_rules! build_metrics_service {
 }
 
 #[cfg(test)]
-pub mod test_tools {
+pub(crate) mod test_tools {
     use std::{io, sync::Arc};
 
     use slog::{Drain, Logger};
     use slog_async::Async;
     use slog_term::{CompactFormat, PlainDecorator};
+
     pub struct TestLogger;
 
     impl TestLogger {

internal/mithril-metric/src/helper.rs

@@ -10,6 +10,3 @@ mod server;
 pub use metric::*;
 pub use server::MetricsServer;
 pub use server::MetricsServiceExporter;
-
-#[cfg(test)]
-pub use helper::test_tools::TestLogger;

internal/mithril-metric/src/lib.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-persistence"
-version = "0.2.37"
+version = "0.2.38"
 description = "Common types, interfaces, and utilities to persist data for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }

internal/mithril-persistence/Cargo.toml

@@ -17,7 +17,7 @@ pub use version_checker::{DatabaseVersionChecker, SqlMigration};
 pub type DbVersion = i64;
 
 #[cfg(test)]
-pub mod test_helper {
+pub(crate) mod test_helper {
     use sqlite::ConnectionThreadSafe;
 
     use mithril_common::StdResult;

internal/mithril-persistence/src/database/mod.rs

@@ -362,9 +362,10 @@ mod tests {
 
     #[test]
     fn expression_get_all_default() {
-        impl GetAllCondition for String {}
+        struct Expression;
+        impl GetAllCondition for Expression {}
 
-        let expression = String::get_all_condition();
+        let expression = Expression::get_all_condition();
         let (sql, params) = expression.expand();
 
         assert_eq!("true".to_string(), sql);

internal/mithril-persistence/src/sqlite/condition.rs

@@ -20,7 +20,7 @@ impl<'a, T> EntityCursor<'a, T> {
     }
 }
 
-impl<'a, T> Iterator for EntityCursor<'a, T>
+impl<T> Iterator for EntityCursor<'_, T>
 where
     T: SqLiteEntity,
 {

internal/mithril-persistence/src/sqlite/cursor.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.5.115"
+version = "0.5.116"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }