Merge pull request #2349 from input-output-hk/dlachaume/fix-job-succeed-with-notification-failure

Fix: `notify-on-failure` job succeeds despite email sending failure

Author: dlachaume

.github/workflows/nightly-dispatcher.yml

@@ -24,3 +24,4 @@ jobs:
     uses: ./.github/workflows/test-notify-on-failure.yml
     needs: [docker-builds, aggregator-stress-test, test-client]
     if: failure()
+    secrets: inherit

.github/workflows/scripts/notify-nightly-failure.js

@@ -32,4 +32,7 @@ sgMail
     console.log("Mail sent successfully");
     console.log("Message details:", msg);
   })
-  .catch((error) => console.error("Error sending email:", error));
+  .catch((error) => {
+    console.error("Error sending email:", error);
+    process.exit(1);
+  });