Fix missing runner inform new epoch

Author: jpraynaud

mithril-aggregator/src/runtime/runner.rs

@@ -169,6 +169,12 @@ pub trait AggregatorRunnerTrait: Sync + Send {
         beacon: &Beacon,
     ) -> Result<(), Box<dyn StdError + Sync + Send>>;
 
+    /// Certifier inform new epoch
+    async fn certifier_inform_new_epoch(
+        &self,
+        epoch: &Epoch,
+    ) -> Result<(), Box<dyn StdError + Sync + Send>>;
+
     /// Create new open message
     async fn create_open_message(
         &self,
@@ -689,6 +695,18 @@ impl AggregatorRunnerTrait for AggregatorRunner {
         Ok(())
     }
 
+    async fn certifier_inform_new_epoch(
+        &self,
+        epoch: &Epoch,
+    ) -> Result<(), Box<dyn StdError + Sync + Send>> {
+        self.dependencies
+            .certifier_service
+            .inform_epoch(*epoch)
+            .await?;
+
+        Ok(())
+    }
+
     async fn create_open_message(
         &self,
         signed_entity_type: &SignedEntityType,
@@ -703,6 +721,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
 
 #[cfg(test)]
 pub mod tests {
+    use crate::certifier_service::MockCertifierService;
     use crate::dependency::SimulateFromChainParams;
     use crate::multi_signer::MockMultiSigner;
     use crate::runtime::WorkingCertificate;
@@ -713,12 +732,10 @@ pub mod tests {
     };
     use crate::{MithrilSignerRegisterer, ProtocolParametersStorer, SignerRegistrationRound};
     use mithril_common::chain_observer::FakeObserver;
-    use mithril_common::crypto_helper::{
-        tests_setup::setup_certificate_chain, };
+    use mithril_common::crypto_helper::tests_setup::setup_certificate_chain;
     use mithril_common::digesters::DumbImmutableFileObserver;
     use mithril_common::entities::{
-        Beacon, CertificatePending, ProtocolMessage, SignedEntityType,
-        StakeDistribution,
+        Beacon, CertificatePending, Epoch, ProtocolMessage, SignedEntityType, StakeDistribution,
     };
     use mithril_common::store::StakeStorer;
     use mithril_common::test_utils::MithrilFixtureBuilder;
@@ -1215,4 +1232,19 @@ pub mod tests {
         runner.update_era_checker(&beacon).await.unwrap();
         assert_eq!(beacon.epoch, era_checker.current_epoch());
     }
+
+    #[tokio::test]
+    async fn test_certifier_inform_new_epoch() {
+        let mut mock_certifier_service = MockCertifierService::new();
+        mock_certifier_service
+            .expect_inform_epoch()
+            .returning(|_| Ok(()))
+            .times(1);
+
+        let (mut deps, config) = initialize_dependencies().await;
+        deps.certifier_service = Arc::new(mock_certifier_service);
+
+        let runner = AggregatorRunner::new(config, Arc::new(deps));
+        runner.certifier_inform_new_epoch(&Epoch(1)).await.unwrap();
+    }
 }

mithril-aggregator/src/runtime/state_machine.rs

@@ -245,6 +245,9 @@ impl AggregatorRuntime {
                 .update_era_checker(&new_beacon)
                 .await
                 .map_err(|e| RuntimeError::critical("transiting IDLE → READY", Some(e)))?;
+            self.runner
+                .certifier_inform_new_epoch(&new_beacon.epoch)
+                .await?;
             self.runner.update_stake_distribution(&new_beacon).await?;
             self.runner
                 .open_signer_registration_round(&new_beacon)
@@ -437,6 +440,11 @@ mod tests {
             .with(predicate::eq(fake_data::beacon()))
             .once()
             .returning(|_| Ok(()));
+        runner
+            .expect_certifier_inform_new_epoch()
+            .with(predicate::eq(fake_data::beacon().epoch))
+            .once()
+            .returning(|_| Ok(()));
 
         let mut runtime = init_runtime(
             Some(AggregatorState::Idle(IdleState {
@@ -489,6 +497,11 @@ mod tests {
             .with(predicate::eq(fake_data::beacon()))
             .once()
             .returning(|_| Ok(()));
+        runner
+            .expect_certifier_inform_new_epoch()
+            .with(predicate::eq(fake_data::beacon().epoch))
+            .once()
+            .returning(|_| Ok(()));
 
         let mut runtime = init_runtime(
             Some(AggregatorState::Idle(IdleState {