Fix clippy warnings (mostly dead code)

Author: Alenar

mithril-client-cli/src/commands/snapshot/download.rs

@@ -59,7 +59,7 @@ impl SnapshotDownloadCommand {
         let progress_output_type = if self.json {
             ProgressOutputType::JsonReporter
         } else {
-            ProgressOutputType::TTY
+            ProgressOutputType::Tty
         };
         let progress_printer = ProgressPrinter::new(progress_output_type, 5);
         let client = ClientBuilder::aggregator(

mithril-client-cli/src/configuration.rs

@@ -24,6 +24,7 @@ impl ConfigParameters {
     }
 
     /// Useful constructor for testing
+    #[cfg(test)]
     pub fn build(parameters: &[(&str, &str)]) -> Self {
         let parameters = parameters
             .iter()
@@ -34,6 +35,7 @@ impl ConfigParameters {
     }
 
     /// Add or replace a parameter in the holder
+    #[cfg(test)]
     pub fn add_parameter(&mut self, name: &str, value: &str) -> &mut Self {
         let _ = self.parameters.insert(name.to_string(), value.to_string());
 

mithril-client-cli/src/utils/feedback_receiver.rs

@@ -35,7 +35,7 @@ impl FeedbackReceiver for IndicatifFeedbackReceiver {
                 download_id: _,
                 size,
             } => {
-                let pb = if self.output_type == ProgressOutputType::TTY {
+                let pb = if self.output_type == ProgressOutputType::Tty {
                     ProgressBar::new(size)
                 } else {
                     ProgressBar::with_draw_target(Some(size), ProgressDrawTarget::hidden())
@@ -68,7 +68,7 @@ impl FeedbackReceiver for IndicatifFeedbackReceiver {
             MithrilEvent::CertificateChainValidationStarted {
                 certificate_chain_validation_id: _,
             } => {
-                let pb = if self.output_type == ProgressOutputType::TTY {
+                let pb = if self.output_type == ProgressOutputType::Tty {
                     ProgressBar::new_spinner()
                 } else {
                     ProgressBar::hidden()

mithril-client-cli/src/utils/progress_reporter.rs

@@ -14,7 +14,7 @@ pub enum ProgressOutputType {
     /// Output to json
     JsonReporter,
     /// Output to tty
-    TTY,
+    Tty,
     /// No output
     Hidden,
 }
@@ -23,7 +23,7 @@ impl From<ProgressOutputType> for ProgressDrawTarget {
     fn from(value: ProgressOutputType) -> Self {
         match value {
             ProgressOutputType::JsonReporter => ProgressDrawTarget::hidden(),
-            ProgressOutputType::TTY => ProgressDrawTarget::stdout(),
+            ProgressOutputType::Tty => ProgressDrawTarget::stdout(),
             ProgressOutputType::Hidden => ProgressDrawTarget::hidden(),
         }
     }
@@ -54,7 +54,7 @@ impl ProgressPrinter {
                 timestamp = Utc::now().to_rfc3339(),
                 number_of_steps = self.number_of_steps,
             ),
-            ProgressOutputType::TTY => self
+            ProgressOutputType::Tty => self
                 .multi_progress
                 .println(format!("{step_number}/{} - {text}", self.number_of_steps))?,
             ProgressOutputType::Hidden => (),

mithril-client-cli/src/utils/snapshot.rs

@@ -67,21 +67,15 @@ mod test {
 
     #[test]
     fn check_disk_space_error_should_return_error_if_error_is_not_error_not_enough_space() {
-        let error = SnapshotUnpackerError::UnpackFailed {
-            dirpath: PathBuf::from(""),
-            error: anyhow::Error::msg("Some error message"),
-        };
+        let error = SnapshotUnpackerError::UnpackDirectoryAlreadyExists(PathBuf::new());
 
         let error = SnapshotUtils::check_disk_space_error(anyhow!(error))
             .expect_err("check_disk_space_error should fail");
 
         assert!(
             matches!(
                 error.downcast_ref::<SnapshotUnpackerError>(),
-                Some(SnapshotUnpackerError::UnpackFailed {
-                    dirpath: _,
-                    error: _
-                })
+                Some(SnapshotUnpackerError::UnpackDirectoryAlreadyExists(_))
             ),
             "Unexpected error: {:?}",
             error

mithril-client-cli/src/utils/unpacker.rs

@@ -38,17 +38,6 @@ pub enum SnapshotUnpackerError {
     /// Cannot write in the given directory.
     #[error("Unpack directory '{0}' is not writable.")]
     UnpackDirectoryIsNotWritable(PathBuf, #[source] StdError),
-
-    /// Unpacking error
-    #[error("Could not unpack from streamed data snapshot to directory '{dirpath}'")]
-    UnpackFailed {
-        /// Location where the archive is to be extracted.
-        dirpath: PathBuf,
-
-        /// Subsystem error
-        #[source]
-        error: StdError,
-    },
 }
 
 impl SnapshotUnpacker {