Merge pull request #1608 from input-output-hk/jpraynaud/1577-fix-transaction-parsing-conway

Fix Conway transactions parsing

Author: jpraynaud

Cargo.lock

@@ -741,8 +741,8 @@ impl DependenciesBuilder {
     }
 
     async fn build_transaction_parser(&mut self) -> Result<Arc<dyn TransactionParser>> {
-        // TODO: 'allow_unparsable_block' parameter should be configurable and its default value set to false
-        let allow_unparsable_block = true;
+        // TODO: 'allow_unparsable_block' parameter should be configurable
+        let allow_unparsable_block = false;
         let transaction_parser =
             CardanoTransactionParser::new(self.get_logger().await?, allow_unparsable_block);
 

mithril-aggregator/src/dependency_injection/builder.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.3.26"
+version = "0.3.27"
 description = "Common types, interfaces, and utilities for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }
@@ -44,12 +44,12 @@ kes-summed-ed25519 = { version = "0.2.1", features = [
     "sk_clone_enabled",
 ] }
 nom = "7.1.3"
-pallas-addresses = { version = "0.24.0", optional = true }
-pallas-codec = { version = "0.24.0", optional = true }
-pallas-hardano = { version = "0.24.0", optional = true }
-pallas-network = { version = "0.24.0", optional = true }
-pallas-primitives = { version = "0.24.0", optional = true }
-pallas-traverse = { version = "0.24.0", optional = true }
+pallas-addresses = { version = "0.25.0", optional = true }
+pallas-codec = { version = "0.25.0", optional = true }
+pallas-hardano = { version = "0.25.0", optional = true }
+pallas-network = { version = "0.25.0", optional = true }
+pallas-primitives = { version = "0.25.0", optional = true }
+pallas-traverse = { version = "0.25.0", optional = true }
 rand_chacha = "0.3.1"
 rand_core = "0.6.4"
 rayon = "1.8.1"
@@ -89,7 +89,7 @@ wasm-bindgen = "0.2.90"
 [dev-dependencies]
 criterion = { version = "0.5.1", features = ["html_reports", "async_tokio"] }
 mockall = "0.12.1"
-pallas-crypto = "0.24.0"
+pallas-crypto = "0.25.0"
 rand_core = { version = "0.6.4", features = ["getrandom"] }
 reqwest = { version = "0.12.0", features = ["json"] }
 slog-async = "2.8.0"

mithril-common/Cargo.toml

@@ -326,7 +326,7 @@ mod tests {
             cardano_transaction_parser
                 .parse(db_path, &beacon)
                 .await
-                .unwrap();
+                .expect_err("parse should have failed");
         }
 
         let log_file = std::fs::read_to_string(&filepath).unwrap();

mithril-common/src/cardano_transaction_parser.rs

@@ -266,8 +266,8 @@ impl<'a> ServiceBuilder for ProductionServiceBuilder<'a> {
             ));
         let mithril_stake_distribution_signable_builder =
             Arc::new(MithrilStakeDistributionSignableBuilder::default());
-        // TODO: 'allow_unparsable_block' parameter should be configurable and its default value set to false
-        let allow_unparsable_block = true;
+        // TODO: 'allow_unparsable_block' parameter should be configurable
+        let allow_unparsable_block = false;
         let transaction_parser = Arc::new(CardanoTransactionParser::new(
             slog_scope::logger(),
             allow_unparsable_block,

mithril-signer/src/runtime/signer_services.rs

@@ -7,5 +7,5 @@
 > [!NOTE]
 > The immutable files (`.chunk`, `.primary` and `.secondary`) files are data that are the result of
 > the `mithril-end-to-end` test command execution.
-> The `parsing_error/` directory contains the `04831` and `04832` immutable files with some unparsable blocks in the first one (`04831` have been produced by the Sanchonet network, and `04832` created manually).
+> The `parsing_error/` directory contains the `04831` and `04832` immutable files with some unparsable blocks in the first one (`04831` have been produced by the Sanchonet network and altered manually with the command `echo " $(cat immutable/04831.chunk)" > immutable/04831.chunk`, and `04832` created manually).
 > They are needed for testing of the Cardano transactions parser.