Remove unnecessary clone() uses after impl Copy on VerificationKey

Author: Damien LACHAUME / PALO-IT

mithril-aggregator/src/signer_registerer.rs

@@ -236,9 +236,9 @@ impl SignerRegisterer for MithrilSignerRegisterer {
         let party_id_save = key_registration.register(
             party_id_register.clone(),
             signer.operational_certificate.clone(),
-            signer.verification_key_signature.clone(),
+            signer.verification_key_signature,
             kes_period,
-            signer.verification_key.clone(),
+            signer.verification_key,
         )?;
         let mut signer_save = SignerWithStake::from_signer(
             signer.to_owned(),

mithril-common/src/crypto_helper/conversions.rs

@@ -69,8 +69,7 @@ pub mod tests {
             .with_signers(1)
             .build()
             .signers_with_stake()[0]
-            .verification_key
-            .clone();
+            .verification_key;
         let signer_with_stake_expected = &entities::SignerWithStake::new(
             "1".to_string(),
             verification_key,

mithril-common/src/crypto_helper/genesis.rs

@@ -110,7 +110,7 @@ impl ProtocolGenesisVerifier {
 
     /// ProtocolGenesisVerifier to ProtocolGenesisVerificationKey
     pub fn to_verification_key(&self) -> ProtocolGenesisVerificationKey {
-        self.verification_key.clone()
+        self.verification_key
     }
 
     /// Verifies the signature of a message

mithril-common/src/crypto_helper/types/protocol_key.rs

@@ -85,6 +85,8 @@ where
     }
 }
 
+impl<T> Copy for ProtocolKey<T> where T: Copy + Serialize + DeserializeOwned {}
+
 impl<T> Serialize for ProtocolKey<T>
 where
     T: ProtocolKeyCodec<T> + Serialize + DeserializeOwned,

mithril-common/src/entities/signer.rs

@@ -253,10 +253,8 @@ mod tests {
             .with_signers(1)
             .build()
             .signers_with_stake()[0]
-            .verification_key
-            .clone();
-        let signer_expected =
-            Signer::new("1".to_string(), verification_key.clone(), None, None, None);
+            .verification_key;
+        let signer_expected = Signer::new("1".to_string(), verification_key, None, None, None);
         let signer_with_stake =
             SignerWithStake::new("1".to_string(), verification_key, None, None, None, 100);
 
@@ -324,8 +322,7 @@ mod tests {
         }
         {
             let mut signer_different_verification_key = signer.clone();
-            signer_different_verification_key.verification_key =
-                signers[1].verification_key.clone();
+            signer_different_verification_key.verification_key = signers[1].verification_key;
 
             assert_ne!(
                 EXPECTED_HASH,

mithril-common/src/protocol/signer_builder.rs

@@ -52,9 +52,9 @@ impl SignerBuilder {
                 .register(
                     Some(signer.party_id.to_owned()),
                     signer.operational_certificate.clone(),
-                    signer.verification_key_signature.clone(),
+                    signer.verification_key_signature,
                     signer.kes_period,
-                    signer.verification_key.clone(),
+                    signer.verification_key,
                 )
                 .with_context(|| {
                     format!("Registration failed for signer: '{}'", signer.party_id)

mithril-common/src/test_utils/mithril_fixture.rs

@@ -242,12 +242,12 @@ impl SignerFixture {
 
     /// Decode this signer verification key certificate
     pub fn verification_key(&self) -> ProtocolSignerVerificationKey {
-        self.signer_with_stake.verification_key.clone()
+        self.signer_with_stake.verification_key
     }
 
     /// Decode this signer verification key signature certificate if any
     pub fn verification_key_signature(&self) -> Option<ProtocolSignerVerificationKeySignature> {
-        self.signer_with_stake.verification_key_signature.clone()
+        self.signer_with_stake.verification_key_signature
     }
 
     /// Get the path to this signer kes secret key