Apply review comments

Author: jpraynaud

mithril-aggregator/src/dependency_injection/builder.rs

@@ -878,7 +878,7 @@ impl DependenciesBuilder {
     }
 
     async fn build_signable_builder_service(&mut self) -> Result<Arc<SignableBuilderService>> {
-        let mithril_stake_distribution_builder = MithrilStakeDistributionSignableBuilder::new();
+        let mithril_stake_distribution_builder = MithrilStakeDistributionSignableBuilder::default();
         let immutable_signable_builder = CardanoImmutableFilesFullSignableBuilder::new(
             self.get_immutable_digester().await?,
             self.get_logger().await?,

mithril-common/src/signable_builder/mithril_stake_distribution.rs

@@ -7,21 +7,9 @@ use crate::{
 };
 
 /// A [MithrilStakeDistributionSignableBuilder] builder
+#[derive(Default)]
 pub struct MithrilStakeDistributionSignableBuilder {}
 
-impl MithrilStakeDistributionSignableBuilder {
-    /// MithrilStakeDistribution signable builder factory
-    pub fn new() -> Self {
-        Self {}
-    }
-}
-
-impl Default for MithrilStakeDistributionSignableBuilder {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
 #[async_trait]
 impl SignableBuilder<Epoch, ProtocolMessage> for MithrilStakeDistributionSignableBuilder {
     // We just need to return an empty protocol message as the next AVK will be appended by the signing engine automatically
@@ -37,7 +25,7 @@ mod tests {
     #[tokio::test]
     async fn test_compute_signable() {
         let mithril_stake_distribution_signable_builder =
-            MithrilStakeDistributionSignableBuilder::new();
+            MithrilStakeDistributionSignableBuilder::default();
         let signable = mithril_stake_distribution_signable_builder
             .compute_signable(Epoch(1))
             .await

mithril-signer/src/runtime/runner.rs

@@ -539,7 +539,7 @@ mod tests {
         let immutable_signable_builder =
             CardanoImmutableFilesFullSignableBuilder::new(digester.clone(), slog_scope::logger());
         let mithril_stake_distribution_signable_builder =
-            MithrilStakeDistributionSignableBuilder::new();
+            MithrilStakeDistributionSignableBuilder::default();
         let signable_builder_service = Arc::new(SignableBuilderService::new(
             immutable_signable_builder,
             mithril_stake_distribution_signable_builder,

mithril-signer/src/runtime/signer_services.rs

@@ -206,7 +206,7 @@ impl<'a> ServiceBuilder for ProductionServiceBuilder<'a> {
         let immutable_snapshot_builder =
             CardanoImmutableFilesFullSignableBuilder::new(digester.clone(), slog_scope::logger());
         let mithril_stake_distribution_signable_builder =
-            MithrilStakeDistributionSignableBuilder::new();
+            MithrilStakeDistributionSignableBuilder::default();
         let signable_builder_service = Arc::new(SignableBuilderService::new(
             immutable_snapshot_builder,
             mithril_stake_distribution_signable_builder,

mithril-signer/tests/test_extensions/state_machine_tester.rs

@@ -155,7 +155,7 @@ impl StateMachineTester {
         let signable_builder =
             CardanoImmutableFilesFullSignableBuilder::new(digester.clone(), slog_scope::logger());
         let mithril_stake_distribution_signable_builder =
-            MithrilStakeDistributionSignableBuilder::new();
+            MithrilStakeDistributionSignableBuilder::default();
         let signable_builder_service = Arc::new(SignableBuilderService::new(
             signable_builder,
             mithril_stake_distribution_signable_builder,