Merge pull request #1796 from input-output-hk/ensemble/1762/preload-cardano-ctx-when-ctx-not-activated

Preload Cardano transactions based on Aggregator's Signing Capability

Author: sfauvel

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.5.35"
+version = "0.5.36"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-aggregator/Cargo.toml

@@ -14,7 +14,9 @@ use warp::Filter;
 use mithril_common::{
     api_version::APIVersionProvider,
     cardano_block_scanner::{BlockScanner, CardanoBlockScanner},
-    cardano_transactions_preloader::CardanoTransactionsPreloader,
+    cardano_transactions_preloader::{
+        CardanoTransactionsPreloader, CardanoTransactionsPreloaderActivation,
+    },
     certificate_chain::{CertificateVerifier, MithrilCertificateVerifier},
     chain_observer::{CardanoCliRunner, ChainObserver, ChainObserverBuilder, FakeObserver},
     chain_reader::{ChainBlockReader, PallasChainReader},
@@ -26,7 +28,10 @@ use mithril_common::{
         CardanoImmutableDigester, DumbImmutableFileObserver, ImmutableDigester,
         ImmutableFileObserver, ImmutableFileSystemObserver,
     },
-    entities::{CertificatePending, CompressionAlgorithm, Epoch, SignedEntityConfig},
+    entities::{
+        CertificatePending, CompressionAlgorithm, Epoch, SignedEntityConfig,
+        SignedEntityTypeDiscriminants,
+    },
     era::{
         adapters::{EraReaderAdapterBuilder, EraReaderDummyAdapter},
         EraChecker, EraMarker, EraReader, EraReaderAdapter, SupportedEra,
@@ -1337,6 +1342,10 @@ impl DependenciesBuilder {
     pub async fn create_cardano_transactions_preloader(
         &mut self,
     ) -> Result<Arc<CardanoTransactionsPreloader>> {
+        let activation = self
+            .get_signed_entity_config()?
+            .list_allowed_signed_entity_types_discriminants()
+            .contains(&SignedEntityTypeDiscriminants::CardanoTransactions);
         let cardano_transactions_preloader = CardanoTransactionsPreloader::new(
             self.get_signed_entity_lock().await?,
             self.get_transactions_importer().await?,
@@ -1345,6 +1354,7 @@ impl DependenciesBuilder {
                 .security_parameter,
             self.get_chain_observer().await?,
             self.get_logger()?,
+            Arc::new(CardanoTransactionsPreloaderActivation::new(activation)),
         );
 
         Ok(Arc::new(cardano_transactions_preloader))
@@ -1493,3 +1503,48 @@ impl DependenciesBuilder {
         self.drop_sqlite_connections().await;
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use mithril_common::entities::SignedEntityTypeDiscriminants;
+
+    use super::*;
+
+    #[tokio::test]
+    async fn cardano_transactions_preloader_activated_with_cardano_transactions_signed_entity_type_in_configuration(
+    ) {
+        assert_cardano_transactions_preloader_activation(
+            SignedEntityTypeDiscriminants::CardanoTransactions.to_string(),
+            true,
+        )
+        .await;
+        assert_cardano_transactions_preloader_activation(
+            SignedEntityTypeDiscriminants::MithrilStakeDistribution.to_string(),
+            false,
+        )
+        .await;
+    }
+
+    async fn assert_cardano_transactions_preloader_activation(
+        signed_entity_types: String,
+        expected_activation: bool,
+    ) {
+        let configuration = Configuration {
+            signed_entity_types: Some(signed_entity_types),
+            ..Configuration::new_sample()
+        };
+        let mut dep_builder = DependenciesBuilder::new(configuration);
+
+        let cardano_transactions_preloader = dep_builder
+            .create_cardano_transactions_preloader()
+            .await
+            .unwrap();
+
+        let is_activated = cardano_transactions_preloader.is_activated().await.unwrap();
+        assert_eq!(
+            expected_activation, is_activated,
+            "'is_activated' expected {}, but was {}",
+            expected_activation, is_activated
+        );
+    }
+}

mithril-aggregator/src/dependency_injection/builder.rs

@@ -1,30 +1,9 @@
 use crate::DependencyContainer;
-use mithril_common::entities::SignedEntityTypeDiscriminants;
-use serde::{Deserialize, Serialize};
-use std::{collections::BTreeSet, sync::Arc};
+use std::sync::Arc;
 use warp::Filter;
 
 use super::middlewares;
 
-#[derive(Debug, Serialize, Deserialize, PartialEq)]
-pub struct RootRouteMessage {
-    pub open_api_version: String,
-    pub documentation_url: String,
-    pub capabilities: AggregatorCapabilities,
-}
-
-#[derive(Debug, Serialize, Deserialize, PartialEq)]
-pub struct AggregatorCapabilities {
-    pub signed_entity_types: BTreeSet<SignedEntityTypeDiscriminants>,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub cardano_transactions_prover: Option<CardanoTransactionsProverCapabilities>,
-}
-
-#[derive(Debug, Serialize, Deserialize, PartialEq)]
-pub struct CardanoTransactionsProverCapabilities {
-    max_hashes_allowed_by_request: usize,
-}
-
 pub fn routes(
     dependency_manager: Arc<DependencyContainer>,
 ) -> impl Filter<Extract = (impl warp::Reply,), Error = warp::Rejection> + Clone {
@@ -54,11 +33,11 @@ mod handlers {
 
     use mithril_common::api_version::APIVersionProvider;
     use mithril_common::entities::{SignedEntityConfig, SignedEntityTypeDiscriminants};
+    use mithril_common::messages::{
+        AggregatorCapabilities, AggregatorFeaturesMessage, CardanoTransactionsProverCapabilities,
+    };
 
     use crate::http_server::routes::reply::json;
-    use crate::http_server::routes::root_routes::{
-        AggregatorCapabilities, CardanoTransactionsProverCapabilities, RootRouteMessage,
-    };
     use crate::{unwrap_to_internal_server_error, Configuration};
 
     /// Root
@@ -85,7 +64,7 @@ mod handlers {
             });
 
         Ok(json(
-            &RootRouteMessage {
+            &AggregatorFeaturesMessage {
                 open_api_version: open_api_version.to_string(),
                 documentation_url: env!("CARGO_PKG_HOMEPAGE").to_string(),
                 capabilities: AggregatorCapabilities {
@@ -102,6 +81,10 @@ mod handlers {
 mod tests {
     use crate::http_server::SERVER_BASE_PATH;
     use crate::{initialize_dependencies, DependencyContainer};
+    use mithril_common::entities::SignedEntityTypeDiscriminants;
+    use mithril_common::messages::{
+        AggregatorCapabilities, AggregatorFeaturesMessage, CardanoTransactionsProverCapabilities,
+    };
     use mithril_common::test_utils::apispec::APISpec;
     use serde_json::Value::Null;
     use std::collections::BTreeSet;
@@ -151,13 +134,14 @@ mod tests {
             .reply(&setup_router(Arc::new(dependency_manager)))
             .await;
 
-        let response_body: RootRouteMessage = serde_json::from_slice(response.body()).unwrap();
+        let response_body: AggregatorFeaturesMessage =
+            serde_json::from_slice(response.body()).unwrap();
 
         assert_eq!(response.status(), StatusCode::OK);
 
         assert_eq!(
             response_body,
-            RootRouteMessage {
+            AggregatorFeaturesMessage {
                 open_api_version: expected_open_api_version,
                 documentation_url: env!("CARGO_PKG_HOMEPAGE").to_string(),
                 capabilities: AggregatorCapabilities {
@@ -202,7 +186,8 @@ mod tests {
             .reply(&setup_router(Arc::new(dependency_manager)))
             .await;
 
-        let response_body: RootRouteMessage = serde_json::from_slice(response.body()).unwrap();
+        let response_body: AggregatorFeaturesMessage =
+            serde_json::from_slice(response.body()).unwrap();
 
         assert_eq!(response.status(), StatusCode::OK);
 

mithril-aggregator/src/http_server/routes/root_routes.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.4.26"
+version = "0.4.27"
 description = "Common types, interfaces, and utilities for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }