feat(aggregator-discovery): add HTTP timeouts

Author: jpraynaud

internal/mithril-aggregator-discovery/src/http_config_discoverer.rs

@@ -1,4 +1,4 @@
-use std::collections::HashMap;
+use std::{collections::HashMap, time::Duration};
 
 use anyhow::Context;
 use reqwest::Client;
@@ -45,6 +45,8 @@ pub struct HttpConfigAggregatorDiscoverer {
 }
 
 impl HttpConfigAggregatorDiscoverer {
+    const HTTP_TIMEOUT: Duration = Duration::from_secs(10);
+
     /// Creates a new `HttpConfigAggregatorDiscoverer` instance with the provided results.
     pub fn new(configuration_file_url: &str) -> Self {
         Self {
@@ -54,7 +56,7 @@ impl HttpConfigAggregatorDiscoverer {
 
     /// Builds a reqwest HTTP client.
     fn build_client(&self) -> StdResult<Client> {
-        let client_builder = Client::builder();
+        let client_builder = Client::builder().timeout(Self::HTTP_TIMEOUT);
         let client = client_builder.build()?;
 
         Ok(client)

internal/mithril-aggregator-discovery/src/model.rs

@@ -1,3 +1,5 @@
+use std::time::Duration;
+
 use mithril_aggregator_client::{AggregatorHttpClient, query::GetAggregatorFeaturesQuery};
 use mithril_common::{StdResult, messages::AggregatorCapabilities};
 
@@ -30,14 +32,18 @@ pub struct AggregatorEndpoint {
 }
 
 impl AggregatorEndpoint {
+    const HTTP_TIMEOUT: Duration = Duration::from_secs(5);
+
     /// Create a new AggregatorEndpoint instance
     pub fn new(url: String) -> Self {
         Self { url }
     }
 
     /// Retrieve the capabilities of the aggregator
     pub async fn retrieve_capabilities(&self) -> StdResult<AggregatorCapabilities> {
-        let aggregator_client = AggregatorHttpClient::builder(self.url.clone()).build()?;
+        let aggregator_client = AggregatorHttpClient::builder(self.url.clone())
+            .with_timeout(Self::HTTP_TIMEOUT)
+            .build()?;
 
         Ok(aggregator_client
             .send(GetAggregatorFeaturesQuery::current())