Improve test and allow deprecated in Adapter

Author: sfauvel

mithril-signer/src/message_adapters/from_pending_certificate_message.rs

@@ -55,11 +55,11 @@ impl TryFromMessageAdapter<CertificatePendingMessage, CertificatePending>
     for FromPendingCertificateMessageAdapter
 {
     /// Adapter method
+    #[allow(deprecated)]
     fn try_adapt(message: CertificatePendingMessage) -> StdResult<CertificatePending> {
         let certificate = CertificatePending {
             epoch: message.epoch,
             signed_entity_type: message.signed_entity_type,
-            // TODO XXX do not use `message` to fill those fields which must not be used anymore.
             protocol_parameters: message.protocol_parameters,
             next_protocol_parameters: message.next_protocol_parameters,
             signers: to_signers(&message.signers).with_context(|| {

mithril-signer/src/services/epoch_service.rs

@@ -125,7 +125,6 @@ impl EpochService for MithrilEpochService {
 
         self.epoch_data = Some(EpochData {
             epoch: epoch_settings.epoch,
-            // TODO XXX Do we need protocol parameters ?
             next_protocol_parameters: epoch_settings.next_protocol_parameters,
             current_signers: epoch_settings.current_signers,
             next_signers: epoch_settings.next_signers,

mithril-signer/tests/test_extensions/certificate_handler.rs

@@ -235,9 +235,8 @@ mod tests {
 
     #[tokio::test]
     async fn retrieve_epoch_settings() {
-        // TODO XXX check signers and next signers
         let (chain_observer, fake_aggregator) = init().await;
-        let fake_signers = fake_data::signers(2);
+        let fake_signers = fake_data::signers(3);
         let epoch = chain_observer.get_current_epoch().await.unwrap().unwrap();
 
         fake_aggregator.release_epoch_settings().await;
@@ -267,6 +266,20 @@ mod tests {
 
         assert_eq!(0, epoch_settings.current_signers.len());
         assert_eq!(2, epoch_settings.next_signers.len());
+
+        let epoch = chain_observer.next_epoch().await.unwrap();
+        fake_aggregator
+            .register_signer(epoch, &fake_signers.as_slice()[2])
+            .await
+            .expect("aggregator client should not fail while registering a user");
+        let epoch_settings = fake_aggregator
+            .retrieve_epoch_settings()
+            .await
+            .expect("we should have a result, None found!")
+            .expect("we should have an EpochSettings, None found!");
+
+        assert_eq!(2, epoch_settings.current_signers.len());
+        assert_eq!(1, epoch_settings.next_signers.len());
     }
 
     #[tokio::test]