Fix clippy warnings

Following release of rust 1.65.0

Author: jpraynaud

demo/protocol-demo/src/demonstrator.rs

@@ -468,7 +468,7 @@ pub fn write_artifacts<T: Serialize>(artifact_name: &str, value: &T) {
     let artifacts_file_path = env::current_dir()
         .unwrap()
         .join(path::Path::new(&artifacts_file_path_name));
-    fs::create_dir_all(&artifacts_file_path.parent().unwrap()).unwrap();
+    fs::create_dir_all(artifacts_file_path.parent().unwrap()).unwrap();
     let mut artifacts_file = fs::File::create(&artifacts_file_path).unwrap();
     write!(
         artifacts_file,

mithril-aggregator/src/dependency.rs

@@ -200,7 +200,7 @@ pub mod tests {
             db_directory: PathBuf::new(),
             snapshot_directory: PathBuf::new(),
             data_stores_directory: PathBuf::new(),
-            genesis_verification_key: key_encode_hex(&genesis_verification_key).unwrap(),
+            genesis_verification_key: key_encode_hex(genesis_verification_key).unwrap(),
             store_retention_limit: None,
         };
         let snapshot_store = Arc::new(LocalSnapshotStore::new(

mithril-aggregator/src/multi_signer.rs

@@ -830,7 +830,7 @@ impl MultiSigner for MultiSignerImpl {
                     .await
                     .ok_or_else(ProtocolError::UnavailableMessage)?;
                 let aggregate_verification_key =
-                    key_encode_hex(&self.avk.as_ref().unwrap()).map_err(ProtocolError::Codec)?;
+                    key_encode_hex(self.avk.as_ref().unwrap()).map_err(ProtocolError::Codec)?;
                 let multi_signature =
                     key_encode_hex(&multi_signature).map_err(ProtocolError::Codec)?;
                 let genesis_signature = "".to_string();

mithril-aggregator/tests/test_extensions/dependency.rs

@@ -44,7 +44,7 @@ pub async fn initialize_dependencies(
         db_directory: PathBuf::new(),
         snapshot_directory: PathBuf::new(),
         data_stores_directory: PathBuf::new(),
-        genesis_verification_key: key_encode_hex(&genesis_verification_key).unwrap(),
+        genesis_verification_key: key_encode_hex(genesis_verification_key).unwrap(),
         store_retention_limit: None,
     };
     let certificate_pending_store = Arc::new(CertificatePendingStore::new(Box::new(

mithril-client/src/aggregator.rs

@@ -176,7 +176,7 @@ impl AggregatorHandler for AggregatorHTTPClient {
             Ok(response) => match response.status() {
                 StatusCode::OK => {
                     let local_path = archive_file_path(digest, &self.network)?;
-                    fs::create_dir_all(&local_path.parent().unwrap())?;
+                    fs::create_dir_all(local_path.parent().unwrap())?;
                     let mut local_file = fs::File::create(&local_path)?;
                     let bytes_total = response.content_length().ok_or_else(|| {
                         AggregatorHandlerError::RemoteServerTechnical(
@@ -300,14 +300,14 @@ mod tests {
             .unwrap()
             .join(path::Path::new(source_directory_name))
             .join(path::Path::new(data_file_name));
-        fs::create_dir_all(&source_file_path.parent().unwrap()).unwrap();
+        fs::create_dir_all(source_file_path.parent().unwrap()).unwrap();
         let mut source_file = fs::File::create(&source_file_path).unwrap();
         write!(source_file, "{}", data_expected).unwrap();
         let archive_file = fs::File::create(&archive_file_path).unwrap();
         let archive_encoder = GzEncoder::new(&archive_file, Compression::default());
         let mut archive_builder = tar::Builder::new(archive_encoder);
         archive_builder
-            .append_dir_all(".", &source_file_path.parent().unwrap())
+            .append_dir_all(".", source_file_path.parent().unwrap())
             .unwrap();
         archive_builder.into_inner().unwrap().finish().unwrap();
     }

mithril-common/src/certificate_chain/certificate_verifier.rs

@@ -221,7 +221,7 @@ impl CertificateVerifier for MithrilCertificateVerifier {
         {
             Some(next_aggregate_verification_key)
                 if valid_certificate_has_different_epoch_as_previous(
-                    *next_aggregate_verification_key,
+                    next_aggregate_verification_key,
                 ) =>
             {
                 Ok(Some(previous_certificate.to_owned()))

mithril-common/src/crypto_helper/cardano/opcert.rs

@@ -112,7 +112,7 @@ impl OpCert {
     /// Compute protocol party id as pool id bech 32
     pub fn compute_protocol_party_id(&self) -> Result<ProtocolPartyId, OpCertError> {
         let mut hasher = Blake2b::<U28>::new();
-        hasher.update(&self.cold_vk.as_bytes());
+        hasher.update(self.cold_vk.as_bytes());
         let mut pool_id = [0u8; 28];
         pool_id.copy_from_slice(hasher.finalize().as_slice());
         bech32::encode("pool", pool_id.to_base32(), Variant::Bech32)

mithril-common/src/crypto_helper/tests_setup.rs

@@ -161,7 +161,7 @@ pub fn setup_signers_from_stake_distribution(
             (
                 SignerWithStake::new(
                     party_id,
-                    key_encode_hex(&protocol_initializer.verification_key())
+                    key_encode_hex(protocol_initializer.verification_key())
                         .expect("key_encode_hex of verification_key should not fail"),
                     protocol_initializer
                         .verification_key_signature()

mithril-common/src/digesters/cardano_immutable_digester.rs

@@ -31,7 +31,7 @@ impl CardanoImmutableDigester {
 impl ImmutableDigester for CardanoImmutableDigester {
     async fn compute_digest(&self, beacon: &Beacon) -> Result<String, ImmutableDigesterError> {
         let up_to_file_number = beacon.immutable_file_number;
-        let immutables = ImmutableFile::list_completed_in_dir(&*self.db_directory)?
+        let immutables = ImmutableFile::list_completed_in_dir(&self.db_directory)?
             .into_iter()
             .filter(|f| f.number <= up_to_file_number)
             .collect::<Vec<_>>();

mithril-common/src/digesters/immutable_file.rs

@@ -127,9 +127,10 @@ mod tests {
 
         if parent_dir.exists() {
             fs::remove_dir_all(&parent_dir)
-                .expect(&*format!("Could not remove dir {:?}", parent_dir));
+                .unwrap_or_else(|_| panic!("Could not remove dir {:?}", parent_dir));
         }
-        fs::create_dir_all(&parent_dir).expect(&*format!("Could not create dir {:?}", parent_dir));
+        fs::create_dir_all(&parent_dir)
+            .unwrap_or_else(|_| panic!("Could not create dir {:?}", parent_dir));
 
         parent_dir
     }