fix: prevent conflicts between tests that verify the archive produced using a CompressedArchiveSnapshotter implementation.

Also remove useless `Arc::new()` in `should_create_a_valid_archive_with_gzip_snapshotter` and `should_create_a_valid_archive_with_zstandard_snapshotter` tests.

Author: dlachaume

mithril-aggregator/src/services/snapshotter/appender.rs

@@ -70,6 +70,8 @@ impl TarAppender for AppenderEntries {
 mod tests {
     use std::path::Path;
 
+    use uuid::Uuid;
+
     use crate::services::snapshotter::test_tools::*;
     use crate::services::{
         CompressedArchiveSnapshotter, Snapshotter, SnapshotterCompressionAlgorithm,
@@ -89,13 +91,14 @@ mod tests {
         let directory_not_to_archive_path = create_dir(&source, "directory_not_to_archive");
         let file_not_to_archive_path = create_file(&source, "file_not_to_archive.txt");
 
-        let snapshotter = CompressedArchiveSnapshotter::new(
+        let mut snapshotter = CompressedArchiveSnapshotter::new(
             source,
             destination,
             SnapshotterCompressionAlgorithm::Gzip,
             TestLogger::stdout(),
         )
         .unwrap();
+        snapshotter.set_sub_temp_dir(Uuid::new_v4().to_string());
 
         let snapshot = snapshotter
             .snapshot_subset(
@@ -165,13 +168,14 @@ mod tests {
         let directory_to_archive_path = create_dir(&source, "directory_to_archive");
         let file_to_archive_path = create_file(&source, "directory_to_archive/file_to_archive.txt");
 
-        let snapshotter = CompressedArchiveSnapshotter::new(
+        let mut snapshotter = CompressedArchiveSnapshotter::new(
             source,
             destination,
             SnapshotterCompressionAlgorithm::Gzip,
             TestLogger::stdout(),
         )
         .unwrap();
+        snapshotter.set_sub_temp_dir(Uuid::new_v4().to_string());
 
         let snapshot = snapshotter
             .snapshot_subset(

mithril-aggregator/src/services/snapshotter/compressed_archive_snapshotter.rs

@@ -348,6 +348,8 @@ impl CompressedArchiveSnapshotter {
 mod tests {
     use std::sync::Arc;
 
+    use uuid::Uuid;
+
     use mithril_common::digesters::DummyCardanoDbBuilder;
 
     use mithril_common::test_utils::assert_equivalent;
@@ -486,15 +488,14 @@ mod tests {
             .append_immutable_trio()
             .build();
 
-        let snapshotter = Arc::new(
-            CompressedArchiveSnapshotter::new(
-                db_directory.clone(),
-                pending_snapshot_directory.clone(),
-                SnapshotterCompressionAlgorithm::Gzip,
-                TestLogger::stdout(),
-            )
-            .unwrap(),
-        );
+        let mut snapshotter = CompressedArchiveSnapshotter::new(
+            db_directory.clone(),
+            pending_snapshot_directory.clone(),
+            SnapshotterCompressionAlgorithm::Gzip,
+            TestLogger::stdout(),
+        )
+        .unwrap();
+        snapshotter.set_sub_temp_dir(Uuid::new_v4().to_string());
 
         let appender = AppenderDirAll { db_directory };
         snapshotter
@@ -527,15 +528,14 @@ mod tests {
             .append_immutable_trio()
             .build();
 
-        let snapshotter = Arc::new(
-            CompressedArchiveSnapshotter::new(
-                db_directory.clone(),
-                pending_snapshot_directory.clone(),
-                ZstandardCompressionParameters::default().into(),
-                TestLogger::stdout(),
-            )
-            .unwrap(),
-        );
+        let mut snapshotter = CompressedArchiveSnapshotter::new(
+            db_directory.clone(),
+            pending_snapshot_directory.clone(),
+            ZstandardCompressionParameters::default().into(),
+            TestLogger::stdout(),
+        )
+        .unwrap();
+        snapshotter.set_sub_temp_dir(Uuid::new_v4().to_string());
 
         let appender = AppenderDirAll { db_directory };
         snapshotter