Synchronise most of signer & aggregator ctx repository code

Author: Alenar

mithril-aggregator/src/database/provider/cardano_transaction/get_cardano_transaction.rs

@@ -3,13 +3,12 @@ use std::ops::Range;
 use sqlite::Value;
 
 use mithril_common::entities::{BlockNumber, BlockRange, TransactionHash};
+#[cfg(test)]
+use mithril_persistence::sqlite::GetAllCondition;
 use mithril_persistence::sqlite::{
     Provider, SourceAlias, SqLiteEntity, SqliteConnection, WhereCondition,
 };
 
-#[cfg(test)]
-use mithril_persistence::sqlite::GetAllCondition;
-
 use crate::database::record::CardanoTransactionRecord;
 
 /// Simple queries to retrieve [CardanoTransaction] from the sqlite database.

mithril-aggregator/src/database/repository/cardano_transaction_repository.rs

@@ -343,13 +343,13 @@ impl BlockRangeRootRetriever for CardanoTransactionRepository {
         let provider = GetBlockRangeRootProvider::new(&self.connection);
         let filters = provider.get_up_to_block_number_condition(block_number);
         let block_range_roots = provider.find(filters)?;
-        let block_range_roots = block_range_roots
+        let iterator = block_range_roots
             .into_iter()
             .map(|record| -> (BlockRange, MKTreeNode) { record.into() })
             .collect::<Vec<_>>() // TODO: remove this collect when we should ba able return the iterator directly
             .into_iter();
 
-        Ok(Box::new(block_range_roots))
+        Ok(Box::new(iterator))
     }
 }
 

mithril-signer/src/database/repository/cardano_transaction_repository.rs

@@ -273,6 +273,8 @@ impl BlockRangeRootRetriever for CardanoTransactionRepository {
         &self,
         up_to_beacon: ImmutableFileNumber,
     ) -> StdResult<Box<dyn Iterator<Item = (BlockRange, MKTreeNode)>>> {
+        // Get the highest block number for the given immutable number.
+        // This is a temporary fix that will be removed when the retrieval is based on block number instead of immutable number.
         let block_number = self
             .get_highest_block_number_for_immutable_number(up_to_beacon)
             .await?