Add context for signed_entity db provider calling functions

Author: Damien LACHAUME / PALO-IT

mithril-aggregator/src/database/provider/signed_entity.rs

@@ -374,7 +374,7 @@ pub trait SignedEntityStorer: Sync + Send {
     ) -> StdResult<Option<SignedEntityRecord>>;
 
     /// Get signed entities type by certificates ids
-    async fn get_signed_entity_by_certificates_ids<'a>(
+    async fn get_signed_entities_by_certificates_ids<'a>(
         &self,
         certificates_ids: &[&'a str],
     ) -> StdResult<Vec<SignedEntityRecord>>;
@@ -449,7 +449,7 @@ impl SignedEntityStorer for SignedEntityStoreAdapter {
         Ok(signed_entity)
     }
 
-    async fn get_signed_entity_by_certificates_ids<'a>(
+    async fn get_signed_entities_by_certificates_ids<'a>(
         &self,
         certificates_ids: &[&'a str],
     ) -> StdResult<Vec<SignedEntityRecord>> {
@@ -855,7 +855,7 @@ mod tests {
             .collect();
 
         let queried_records = store
-            .get_signed_entity_by_certificates_ids(&certificates_ids)
+            .get_signed_entities_by_certificates_ids(&certificates_ids)
             .await
             .expect("querying signed entity record by certificates ids should not fail");
 

mithril-aggregator/src/services/signed_entity.rs

@@ -2,6 +2,7 @@
 //!
 //! This service is responsible of dealing with [SignedEntity] type.
 //! It creates [Artifact] that can be accessed by clients.
+use anyhow::Context;
 use async_trait::async_trait;
 use chrono::Utc;
 use slog_scope::info;
@@ -144,7 +145,7 @@ impl SignedEntityService for MithrilSignedEntityService {
 
         self.signed_entity_storer
             .store_signed_entity(&signed_entity)
-            .await?;
+            .await.with_context(|| "Signed Entity Service can not store signed entity with type: '{signed_entity_type}'")?;
 
         Ok(())
     }
@@ -159,7 +160,13 @@ impl SignedEntityService for MithrilSignedEntityService {
                 &SignedEntityTypeDiscriminants::CardanoImmutableFilesFull,
                 total,
             )
-            .await?;
+            .await
+            .with_context(|| {
+                format!(
+                    "Signed Entity Service can not get last signed entities with type: '{:?}'",
+                    &SignedEntityTypeDiscriminants::CardanoImmutableFilesFull
+                )
+            })?;
         let mut signed_entities: Vec<SignedEntity<Snapshot>> = Vec::new();
 
         for record in signed_entities_records {
@@ -179,7 +186,13 @@ impl SignedEntityService for MithrilSignedEntityService {
                 &SignedEntityTypeDiscriminants::MithrilStakeDistribution,
                 total,
             )
-            .await?;
+            .await
+            .with_context(|| {
+                format!(
+                    "Signed Entity Service can not get last signed entities with type: '{:?}'",
+                    &SignedEntityTypeDiscriminants::MithrilStakeDistribution
+                )
+            })?;
         let mut signed_entities: Vec<SignedEntity<MithrilStakeDistribution>> = Vec::new();
 
         for record in signed_entities_records {
@@ -196,8 +209,10 @@ impl SignedEntityService for MithrilSignedEntityService {
         let entity: Option<SignedEntity<Snapshot>> = match self
             .signed_entity_storer
             .get_signed_entity(signed_entity_id)
-            .await?
-        {
+            .await
+            .with_context(|| {
+                "Signed Entity Service can not get signed entity with id: '{signed_entity_id}'"
+            })? {
             Some(entity) => Some(entity.try_into()?),
             None => None,
         };
@@ -212,8 +227,10 @@ impl SignedEntityService for MithrilSignedEntityService {
         let entity: Option<SignedEntity<MithrilStakeDistribution>> = match self
             .signed_entity_storer
             .get_signed_entity(signed_entity_id)
-            .await?
-        {
+            .await
+            .with_context(|| {
+                "Signed Entity Service can not get signed entity with id: '{signed_entity_id}'"
+            })? {
             Some(entity) => Some(entity.try_into()?),
             None => None,
         };

mithril-aggregator/src/tools/certificates_hash_migrator.rs

@@ -129,8 +129,11 @@ impl CertificatesHashMigrator {
             .collect();
         let mut records_to_migrate = self
             .signed_entity_storer
-            .get_signed_entity_by_certificates_ids(&old_hashes)
-            .await?;
+            .get_signed_entities_by_certificates_ids(&old_hashes)
+            .await
+            .with_context(|| {
+                "Certificates Hash Migrator can not get signed entities by certificates ids with hashes: '{old_hashes}'"
+            })?;
 
         debug!("🔧 Certificate Hash Migrator: updating signed entities certificate_ids to new computed hash");
         for signed_entity_record in records_to_migrate.iter_mut() {
@@ -155,7 +158,8 @@ impl CertificatesHashMigrator {
         debug!("🔧 Certificate Hash Migrator: updating migrated signed entities in the database");
         self.signed_entity_storer
             .update_signed_entities(records_to_migrate)
-            .await?;
+            .await
+            .with_context(|| "Certificates Hash Migrator can not update signed entities")?;
 
         Ok(())
     }
@@ -165,7 +169,9 @@ impl CertificatesHashMigrator {
         self.certificate_repository
             .delete_certificates(&old_certificates.iter().collect::<Vec<_>>())
             .await
-            .with_context(|| "Certificate Hash Migrator can not delete certificates")?;
+            .with_context(|| {
+                "Certificates Hash Migrator can not delete certificates with hashes: '{old_hashes}'"
+            })?;
 
         Ok(())
     }
@@ -277,7 +283,10 @@ mod test {
 
                     signed_entity_store
                         .store_signed_entity(&signed_entity_record)
-                        .await?;
+                        .await
+                        .with_context(|| {
+                            "Certificates Hash Migrator can not store signed entity"
+                        })?;
 
                     Some(signed_entity_record)
                 }
@@ -408,7 +417,8 @@ mod test {
             } else {
                 let record = signed_entity_store
                     .get_signed_entity_by_certificate_id(&certificate.hash)
-                    .await?;
+                    .await
+                    .with_context(|| "Certificates Hash Migrator can not get signed entity type by certificate id with hash: '{&certificate.hash}'")?;
                 result.push((certificate, record));
             }
         }