feat: make allow_unparsable_block configurable on Signer node

Add 'allow_unparsable_block' clap argument and Configuration parameter.

Author: dlachaume

mithril-signer/src/aggregator_client.rs

@@ -443,6 +443,7 @@ mod tests {
             enable_metrics_server: true,
             metrics_server_ip: "0.0.0.0".to_string(),
             metrics_server_port: 9090,
+            allow_unparsable_block: false,
         };
         let era_checker = EraChecker::new(SupportedEra::dummy(), Epoch(1));
         let api_version_provider = APIVersionProvider::new(Arc::new(era_checker));

mithril-signer/src/configuration.rs

@@ -90,6 +90,11 @@ pub struct Configuration {
 
     /// Metrics HTTP Server listening port.
     pub metrics_server_port: u16,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on production networks.
+    pub allow_unparsable_block: bool,
 }
 
 impl Configuration {
@@ -120,6 +125,7 @@ impl Configuration {
             enable_metrics_server: true,
             metrics_server_ip: "0.0.0.0".to_string(),
             metrics_server_port: 9090,
+            allow_unparsable_block: false,
         }
     }
 

mithril-signer/src/main.rs

@@ -75,6 +75,12 @@ pub struct Args {
     /// Metrics HTTP server listening port.
     #[clap(long, env = "METRICS_SERVER_PORT", default_value_t = 9090)]
     metrics_server_port: u16,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on production networks.
+    #[clap(long)]
+    allow_unparsable_block: bool,
 }
 
 impl Args {
@@ -136,6 +142,8 @@ async fn main() -> StdResult<()> {
         .with_context(|| "configuration error: could not set `reset_digests_cache`")?
         .set_default("enable_metrics_server", args.enable_metrics_server)
         .with_context(|| "configuration error: could not set `enable_metrics_server`")?
+        .set_default("allow_unparsable_block", args.allow_unparsable_block)
+        .with_context(|| "configuration error: could not set `allow_unparsable_block`")?
         .add_source(DefaultConfiguration::default())
         .add_source(
             config::File::with_name(&format!(

mithril-signer/src/runtime/runner.rs

@@ -599,6 +599,7 @@ mod tests {
             enable_metrics_server: true,
             metrics_server_ip: "0.0.0.0".to_string(),
             metrics_server_port: 9090,
+            allow_unparsable_block: false,
         };
 
         SignerRunner::new(

mithril-signer/src/runtime/signer_services.rs

@@ -9,9 +9,9 @@ use mithril_common::{
     crypto_helper::{OpCert, ProtocolPartyId, SerDeShelleyFileFormat},
     digesters::{
         cache::{ImmutableFileDigestCacheProvider, JsonImmutableFileDigestCacheProviderBuilder},
-        ImmutableFileObserver,
+        CardanoImmutableDigester, ImmutableDigester, ImmutableFileObserver,
+        ImmutableFileSystemObserver,
     },
-    digesters::{CardanoImmutableDigester, ImmutableDigester, ImmutableFileSystemObserver},
     era::{EraChecker, EraReader},
     signable_builder::{
         CardanoImmutableFilesFullSignableBuilder, CardanoTransactionsSignableBuilder,
@@ -257,11 +257,11 @@ impl<'a> ServiceBuilder for ProductionServiceBuilder<'a> {
             ));
         let mithril_stake_distribution_signable_builder =
             Arc::new(MithrilStakeDistributionSignableBuilder::default());
-        // TODO: 'allow_unparsable_block' parameter should be configurable
-        let allow_unparsable_block = false;
         let transaction_parser = Arc::new(CardanoTransactionParser::new(
             slog_scope::logger(),
-            allow_unparsable_block,
+            self.config
+                .get_network()?
+                .allow_unparsable_block(self.config.allow_unparsable_block)?,
         ));
         let transaction_store = Arc::new(CardanoTransactionRepository::new(
             transaction_sqlite_connection,
@@ -385,6 +385,7 @@ mod tests {
             enable_metrics_server: true,
             metrics_server_ip: "0.0.0.0".to_string(),
             metrics_server_port: 9090,
+            allow_unparsable_block: false,
         };
 
         assert!(!stores_dir.exists());